Skip to content
This repository has been archived by the owner on Oct 18, 2022. It is now read-only.

Count Display API is not consistent between components #31

Closed
elwayman02 opened this issue Sep 16, 2015 · 1 comment
Closed

Count Display API is not consistent between components #31

elwayman02 opened this issue Sep 16, 2015 · 1 comment

Comments

@elwayman02
Copy link
Contributor

The count display for twitter shares is:

{{twitter-share count='horizontal'}}

With vertical as the other option, displaying the count on the right and top, respectively.

However, for linkedin shares, the API is:

{{linkedin-share count='top'}}

With right as the other option.

It would make more sense for the Twitter-Share component to align with the Linkedin-Share API.

@elwayman02
Copy link
Contributor Author

I'm also not sure why twitter-share has a none option for count, since the default component with no options displays exactly the same.

@locks locks mentioned this issue Aug 20, 2016
@locks locks closed this as completed in #41 Sep 27, 2016
locks added a commit that referenced this issue Sep 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant