-
Notifications
You must be signed in to change notification settings - Fork 30
Fix tests #41
Conversation
Can you also remove the |
Will do! We still have some failing tests, I believe due to CSP, investigating. |
My attempt trying to debug the issue with failed tests ended up with the following results. The problems start with: Ember.$.getScript("//platform.linkedin.com/in.js?async=true", function success() {
IN.shareHandlerName = shareHandlerName;
IN.Event.on(IN, 'systemReady', Ember.run.bind(null, resolve, IN));
IN.init();
}); It loads couple of nasty JS files and one of them (
In the browser It'd look like: Going deeper in the code, it breaks on At the same time, if you load dummy/app |
As @anvyst mentions, the manual tests seem to work but not the automated ones. Thoughts on how to proceed? :X |
Add missing config properties to {{facebook-like}}
…already inserted into the page
Social Plugins - The following are now deprecated and will no longer render after June 23, 2015: * Facepile Plugin source: https://developers.facebook.com/docs/apps/changelog
Fixes #23. Fixes #31. Fixes #36. Fixes #45.
I believe this will require a major version bump, as the
facepile
component had to be removed due to the API being deprecated by Facebook. You can see more detail in the related commit message.Twitter's share component also got the counts removed.