Skip to content
This repository has been archived by the owner on Oct 18, 2022. It is now read-only.

Deprecation warnings on Ember 2.7.0 #45

Closed
sevab opened this issue Sep 9, 2016 · 3 comments
Closed

Deprecation warnings on Ember 2.7.0 #45

sevab opened this issue Sep 9, 2016 · 3 comments

Comments

@sevab
Copy link
Contributor

sevab commented Sep 9, 2016

Some deprecation warnings are thrown in regards to services when using the addon with Ember 2.7.0.

screen shot 2016-09-09 at 12 02 33
@ianpetzer
Copy link

@sevab Was also just looking at this.
I think it might be fixed by this: #43

@sevab
Copy link
Contributor Author

sevab commented Sep 9, 2016

@ianpetzer thanks! Upgraded to ba826017b6a62a53d5a5cdb5145e00941d95de91, and the first one is now fixed, although still getting isServiceFactory deprecation.

@locks locks mentioned this issue Sep 15, 2016
Merged
@sevab
Copy link
Contributor Author

sevab commented Sep 19, 2016

76fc2fa fixes everything.

@locks locks closed this as completed in #41 Sep 27, 2016
locks added a commit that referenced this issue Sep 27, 2016
@locks
Merge pull request #41 from plyfe/fix-tests
e435b31 
Fixes #23. Fixes #31. Fixes #36. Fixes #45.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianpetzer @sevab