This repository has been archived by the owner on Oct 18, 2022. It is now read-only.
Converts Services to Ember.Service extensions #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Injects services via `Ember.inject` instead of initializer * Removes Facebook facepile, Facebook deprecated/removed it * Fixes tests
|
Tests intermittently failed locally |
|
Just confirm, Facebook's Facepile stopped working June 23rd, 2015. The failing tests on Travis should be because it is still building with Phantom 1.9. Rebasing this PR should probably fix it. I'll do a rebase this side as well to see. |
|
@kennethkalmer What branch should this be rebased against? I'm not seeing anything with Phantom 2.0 |
|
I'm seeing deprecations in Ember 1.13.x and this pull request has the fixes, is there anything I can do to get it over the line? The PR looks correct. |
This was referenced Aug 18, 2016
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.injectinstead of initializer