Update fabrictable new opcert stage #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#19187) * Accept numeric IDs for cluster codes when parsing required cluster entries in idl validator * Make parser accept numeric values in the grammar for required clusters * Restyle
project-chip#19008) * Add a BitMask class that adds more functionality beyond bit flags * Use bit-mask class in zap * Zap regen * Update to make things compile * Add BitMask constructors and more support in generic test validation types * More updates for compilation - chip tool seems to compile now * Restyle * Fix all clusters compile * Fix compilation for direct value assignment to a mask * Add default copy constructor for BitMask * Undo pigweed update * Convert one more flag to mask for compile on TI * Review comments: better documentation, add unit tests * Simplify NumericAttributeTraits for BitMask * Remove unused asserts * Slight comment update * Slight comment update * Zap regen
…ject-chip#19161) The identifier returned by bt_id_create() will be GT/EQ to 0 on successful Signed-off-by: chao.an <anchao@xiaomi.com>
This fixes a bug where we would claim commands in our AcceptedCommandList that we did not actually implement if we happened to be mis-configured to not implement a mandatory command. Enables the mandatory SendKey command in the Keypad Input cluster in all-clusters-app, to keep passing existing tests. Enables the mandatory NavigateTarget command in the Target Navigator cluster in all-clusters-app, to keep passing existing tests.
* Fix command timeouts during commissioning.
Several fixes here:
1. AutoCommissioner has a comment about how per spec everything during
commissioning needs at least a 30s timeout, and it was passing that to
PerformCommissioningStep, but DeviceCommissioner was ignoring the "timeout"
parameter for a bunch of the cases, including crucially for AddNOC and
CSRRequest. Those can take a while to run, and were hitting the
now-much-lower default 2s timeout. The fix here is to stop ignoring the
passed-in value.
2. The passed-in timeout value computation in AutoCommissioner was not quite
right. It was set to max(30s, network-connect-time), but the network connect
time is the processing time on the server, not the total time including
transport latency. Fix the computation of the timeout to:
a. Take the network connect times for the network enable steps, a "slow
crypto" time of 15s for the AddNOC and CSRRequest steps, and the default
IM timeout for all other steps and treat that as the server processing
time.
b. Add the transport timeout bits from our device's session to that server
processing time.
c. If the result is less than the spec-mandated 30s timeout, use 30s,
otherwise use the result we computed.
3. Assuming that BLE has 0 transport latency is wrong. Not clear what the right
value is, but for now setting it to the same as TCP.
Fixes project-chip#19135
* Address review comments.
* Address review comment
…ject-chip#19141) Found during investigation of project-chip#15409 but there may be more problems left in that issue. If we get into EstablishPASEConnection and find an existing commissionee for the peer address (which is easy for BLE, where the peer address is basically a singleton), but the device id does not match the passed-in one, we should not reuse that device. If we try to, Commission will fail to find the commissionee device by device id and fail out.
* [K32W0] Use PDM SaveOnIdle Lengthy flash operations are postponed on the idle task. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com> * Restyled by clang-format * Fix KVS Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com> * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
* Use tizen_sdk_sysroot instead of sysroot arg during tizen build. * Fix tizen sdk build to support toolchain output dir * Add Tizen builds optionally to unified build * Add generation of compile_commands for tizen platform * Add compile_commands path to intellisense configuration * Add GN Language Server * Fix unit integration test
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Flash NOP device was disabled during the last nRF Connect SDK version update, but it turn out to cause MPU fault during DFU over SMP. Restored enabling flash NOP device.
* [project-chip#18407] Update attributes and feature map for lock-app * Update auto-generated files
…ip#19219) Bumps [third_party/mbedtls/repo](https://github.com/ARMmbed/mbedtls) from `bdd6905` to `7bda291`. - [Release notes](https://github.com/ARMmbed/mbedtls/releases) - [Commits](Mbed-TLS/mbedtls@bdd6905...7bda291) --- updated-dependencies: - dependency-name: third_party/mbedtls/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… the last endpoint is removed from the group. (project-chip#19221)
Broke with last pigweed roll, disable global RPC mutex.
…ip#19220) Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `e61718e` to `834e876`. - [Release notes](https://github.com/google/pigweed/releases) - [Commits](google/pigweed@e61718e...834e876) --- updated-dependencies: - dependency-name: third_party/pigweed/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The optional fields should be optional instead of forcing consumers to provide garbage values.
* Make test cluster attributes and commands optional
This comes specifically from linter complaining about unimplemented
bits:
- `unsupported` attribute missing (and this is on purpose)
- TestSimpleArgument, TestStructArrayArgument and
TestComplexNullableOptional commands
* Python code seems to depend on optionality. Regen
* Remove some optionality based on review comments
* zap regen
…roject-chip#19195) * Make watermark feature enum visible, use it * Make sure platforms with a `ResetWatermarks` return true on the support method * Add featuremap as access interface for software diagnostics, resort items
* Added DL scripts and manual scripts * Added Auto generated scripts * Restyled by whitespace * updated scripts * Added Auto generated files * Restyled by clang-format * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
…variables. (project-chip#19193) Adds support for having the expected value in a min/max constraint be a saveAs value in darwin-framework-tool. Fixes project-chip#19110
…ctive mode (project-chip#19238) * [chip-tool] Support double quotes for arguments with spaces This is especially useful to pair to a SSID with spaces. * Restyled * Use correct allocation size * Add comment about arg[0]
* Adds BOOt button as switch to toggle LED * Restyled by whitespace Co-authored-by: Restyled.io <commits@restyled.io>
…chip#19328) * Add API to invalid sessions/exchanges for UpdateNOC command * Complete the idea * Add purge all fabric API * Resolve comments: adjust function name * Restyle * Fix rebase conflict * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Resolve comments Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* * Reworked the entire pcc controller zap file to be spec compliant * Fixed issue project-chip#19178 * * Re-ran the zap_regen_all.py tool
* Chef - Remove redundant hash_string in sample_app_util rename func * Chef - Add debugg output on exception to stateful_shell * Chef - Add choices for device arg * Chef - Add 13 sample apps
…ject-chip#19749) Initialize CASESessionManager's mrpLocalConfig in Server::Init()
This will produce native arm64 binaries by default instead of x64, which will not be able to link with an arm64 openssl installed by brew.
…ST (project-chip#19689) CONFIG_IM_BUILD_FOR_UNIT_TEST started getting used in other unit tests other than IM. A more appropriate name is CONFIG_BUILD_FOR_HOST_UNIT_TEST.
This pulls in project-chip/zap@fd3adab, which just changes the ordering of output for some queries. I verified, with "git diff --color-moved" that all the generated code changes are things being reordered as a result.
…ject-chip#19795) * [DGSW] Add SupportsWatermarks method that returns true - Also fixes feature-map, kWaterMarks bit will be set * [DGWiFi] Handle WiFi-Diagnostics events - After receiving WiFi-Diagnostic events, call WiFiDiagnosticsDelegate functions * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
…t-chip#19754) add MBEDTLS_X509_CSR_WRITE_C conditional build Signed-off-by: Qingsong Gou <gouqs@hotmail.com>
* Initial commit * Review feedback * Fixes to the YAML to make window covering work
…p#19697) Credentials::GetDefaultDACVerifier returns a singleton object, initialized the very first time the function is called. The Darwin framework wants to be able to shut down and restart with a new PAA trust store, which means not relying on this initialized-once singleton. The fixes to DeviceControllerSystemState shutdown were needed to make the tests (which start up a factory, then shut it down without bringing up any controllers, which is a valid thing to do) pass.
…9659) This way we won't get spurious timeouts from clock changes.
- FabricTable management during commissioning did not properly handle the fact that committing needs to only be done on CommissioningComplete, which prevented the AddTrustedRootCertificate, UpdateNOC and AddNOC command semantics to be implemented properly and prevented proper state observation of operational credential clusters server Fixes project-chip#7695 Issue project-chip#8905 Fixes project-chip#18633 Issue project-chip#17208 Fixes project-chip#15585 This PR: - Removes direct access to FabricInfo from everywhere, which caused possibly stale FabricInfo references during commissioning. - Remove immediate committing of fabric table on UpdateNOC. - Make Fabrics, NOCs and TrustedRootCertificates attributes reflect proper partial state during fail-safe, by using the shadow data capabilities of OperationalCertificateStore and by updates to FabricInfo - Make it possible to unit test fabric table by providing the necessary lifecycle public APIs to test every modality of the commissioning flow - Make Server and DeviceController use OperationalCertificateStore to allow proper external lifecycle management of the operational cert chain. - Update all examples/controller code to new API - Remove dangerous internal APIs from FabricTable and replace with direct accessors where needed - Add more of the necessary spec validations to the UpdateNOC and AddNOC flows Testing done: - Updated all unit tests, all pass - Cert tests still pass as before - Working on further integration tests and unit tests as a follow-up noting that current state has not regressed on existing test coverage, and that new usage of OperationalCertificateStore class in FabricTable gains a large amount of additional coverage transitively via some of the existing tests making use of FabricTable.
…es. (project-chip#19730) Two changes here: 1) In chip_tests_iterate_expected_list, we were marking each individual value as an array (because "this.isArray" would be true in general when this helper is used). That caused asTypedLiteral to fail to map it to an integer basic type and hence we were not adding with the proper suffixes, and that lead to signed-to-unsigned comparison errors. This is the actual bugfix. 2) In asTypedLiteral, we really should be suffixing uint8_t with "U". It's not clear why compilers don't complain about signed-to-unsigned compares for that type the way they do for uint16/32/64_t, but conceptually this is the right thing to do. Fixes project-chip#19726
* Enable the COTA feature for TC_DL tests * Update auto-generated files
…it_id> on linux platform (project-chip#19710)" (project-chip#19786) This reverts commit 8da6fc8.
…e-new-opcert-stage
- Remove needless ones - Make the callbacks do nothing by default to avoid more "Intentionally left blank" - Renamed to actually reflect what is happening
Fabric commit / revert is being refactored to only persist fabric data when we actually commit on receipt of CommissioningComplete. This reworks Last known Good Time to use the same strategy. Now, instead of persisting both last known good time and a fail-safe backup at the time of certificate installation, a single, updated last known good time is stored in RAM at the time of certificate installation. Then, on commit, this is persisted, but never before.
tcarmelveilleux
pushed a commit
that referenced
this pull request
Jul 11, 2022
It's not safe to access line editing state from the IO thread while
inside readline() on the main thread.
Remove the code that attempts to redraw readline after printing logs.
This avoids segfaults during logging at the cost of those logs
overwriting the prompt (this is not trivial to fix as readline
is a blocking API).
==================
WARNING: ThreadSanitizer: data race (pid=63005)
Write of size 1 at 0x55f81c7745ff by main thread:
#0 InteractiveStartCommand::ParseCommand(char*) ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 (chip-tool+0x874911)
#1 InteractiveStartCommand::RunCommand() ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:85 (chip-tool+0x874594)
#2 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:408 (chip-tool+0x83e478)
#3 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839)
#4 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7)
#5 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288)
#6 main <null> (chip-tool+0x569c0a)
Previous read of size 1 at 0x55f81c7745ff by thread T5 (mutexes: write M185):
#0 LoggingCallback ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:46 (chip-tool+0x874479)
#1 chip::Logging::LogV(unsigned char, unsigned char, char const*, __va_list_tag*) ../../src/lib/support/logging/CHIPLogging.cpp:221 (chip-tool+0x8ee4dc)
#2 chip::Logging::Log(unsigned char, unsigned char, char const*, ...) ../../src/lib/support/logging/CHIPLogging.cpp:172 (chip-tool+0x8ee30a)
#3 chip::app::ReadClient::RefreshLivenessCheckTimer() <null> (chip-tool+0x8b1746)
#4 chip::app::ReadClient::ProcessSubscribeResponse(chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:845 (chip-tool+0x8b20ec)
#5 chip::app::ReadClient::OnMessageReceived(chip::Messaging::ExchangeContext*, chip::PayloadHeader const&, chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:409 (chip-tool+0x8ae2a4)
#6 chip::Messaging::ExchangeContext::HandleMessage(unsigned int, chip::PayloadHeader const&, chip::BitFlags<chip::Messaging::MessageFlagValues, unsigned int>, chip::System::PacketBufferHandle&&) <null> (chip-tool+0xa0517a)
#7 operator()<chip::Messaging::ExchangeContext> ../../src/messaging/ExchangeMgr.cpp:219 (chip-tool+0xa08c73)
#8 Call ../../src/lib/support/Pool.h:126 (chip-tool+0xa0912d)
#9 chip::internal::HeapObjectList::ForEachNode(void*, chip::Loop (*)(void*, void*)) ../../src/lib/support/Pool.cpp:127 (chip-tool+0x8ee05a)
#10 ForEachActiveObject<chip::Messaging::ExchangeManager::OnMessageReceived(const chip::PacketHeader&, const chip::PayloadHeader&, const chip::SessionHandle&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&)::<lambda(auto:2*)> > ../../src/lib/support/Pool.h:396 (chip-tool+0xa08d10)
#11 chip::Messaging::ExchangeManager::OnMessageReceived(chip::PacketHeader const&, chip::PayloadHeader const&, chip::SessionHandle const&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&) ../../src/messaging/ExchangeMgr.cpp:212 (chip-tool+0xa07e91)
#12 chip::SessionManager::SecureUnicastMessageDispatch(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:616 (chip-tool+0xa1548b)
#13 chip::SessionManager::OnMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:443 (chip-tool+0xa14426)
#14 chip::TransportMgrBase::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/TransportMgrBase.cpp:76 (chip-tool+0xa17dfa)
#15 chip::Transport::Base::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/raw/Base.h:102 (chip-tool+0xb19728)
#16 chip::Transport::UDP::OnUdpReceive(chip::Inet::UDPEndPoint*, chip::System::PacketBufferHandle&&, chip::Inet::IPPacketInfo const*) ../../src/transport/raw/UDP.cpp:122 (chip-tool+0xb1a48b)
#17 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>) ../../src/inet/UDPEndPointImplSockets.cpp:688 (chip-tool+0xb00aa0)
#18 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>, long) ../../src/inet/UDPEndPointImplSockets.cpp:569 (chip-tool+0xafff89)
#19 chip::System::LayerImplSelect::HandleEvents() ../../src/system/SystemLayerImplSelect.cpp:406 (chip-tool+0xb07563)
#20 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:181 (chip-tool+0x98a227)
#21 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75)
#22 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c)
Location is global '(anonymous namespace)::gIsCommandRunning' of size 1 at 0x55f81c7745ff (chip-tool+0x000000c485ff)
Mutex M185 (0x55f81c776180) created at:
#0 pthread_mutex_lock ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:4240 (libtsan.so.0+0x4f30a)
#1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_LockChipStack() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:78 (chip-tool+0x989e90)
#2 chip::DeviceLayer::PlatformManager::LockChipStack() ../../src/include/platform/PlatformManager.h:410 (chip-tool+0x988fa5)
#3 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:170 (chip-tool+0x98a147)
#4 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75)
#5 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c)
Thread T5 (tid=63013, running) created by main thread at:
#0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x5ad75)
#1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_StartEventLoopTask() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:231 (chip-tool+0x98a40a)
#2 chip::DeviceLayer::PlatformManager::StartEventLoopTask() ../../src/include/platform/PlatformManager.h:375 (chip-tool+0xaacca2)
#3 chip::Controller::DeviceControllerFactory::ServiceEvents() ../../src/controller/CHIPDeviceControllerFactory.cpp:331 (chip-tool+0xab0417)
#4 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:403 (chip-tool+0x83e353)
#5 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839)
#6 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7)
#7 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288)
#8 main <null> (chip-tool+0x569c0a)
SUMMARY: ThreadSanitizer: data race ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 in InteractiveStartCommand::ParseCommand(char*)
==================
tcarmelveilleux
pushed a commit
that referenced
this pull request
Oct 24, 2023
…ist". (project-chip#29666) The typical failure there looks like this: ==29620==ERROR: LeakSanitizer: detected memory leaks Direct leak of 88 byte(s) in 1 object(s) allocated from: #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12) #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789) #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db) #3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa) #4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8) #5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1) #6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44) #7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343) #8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992) #9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7) #10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894) #11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e) #12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac) #13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25) #14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2) #15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6) #16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603) #17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81) #18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659) #19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d) #20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c) #21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Last known Good Time commit / revert strategy does not align to new fabric commit / revert strategy, which stages pending fabric info in RAM and only persists at commit.
Change overview
Align Last Known Good Time commit / revert strategy to new fabric commit / revert strategy, holding pending Last Known Good Time in RAM and only persisting at commit.
Testing
TestFabricTable was updated for compatibility with the new approach, but retaining similar test coverage as before. The updated test passes.