This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
[vtctld do not merge] Custom build for vtctld development (cherry-picks on top of 9.0) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[vtctld] Migrate cell getters Signed-off-by: Andrew Mason <amason@slack-corp.com>
[vtctld] migrate tablet getters Signed-off-by: Andrew Mason <amason@slack-corp.com>
…nd_pkg [vtctld] vtctldclient command pkg Signed-off-by: Andrew Mason <amason@slack-corp.com>
[vtctld] Add GetSrvVSchema command Signed-off-by: Andrew Mason <amason@slack-corp.com>
[vtctld] Migrate GetSchema Signed-off-by: Andrew Mason <amason@slack-corp.com>
[vtctld] Migrate ListBackups as GetBackups in new vtctld server Signed-off-by: Andrew Mason <amason@slack-corp.com>
[vtctld] Migrate GetVSchema to VtctldServer Signed-off-by: Andrew Mason <amason@slack-corp.com>
[vtctld] Migrate topo management RPCs Signed-off-by: Andrew Mason <amason@slack-corp.com>
…ce_errors [vtctldclient] Set `SilenceErrors` on the root command, so we don't double-log
[vtctld | tests only] testtmclient refactor Note: Manually deleted api_test.go due to cherry-pick conflict Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Provide named function for squashing usage errors; start using it Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Note (@rafael): This one required a bunch of manual intervention [vtctld] Add v0 GetWorkflows rpc and workflow/vexec packages Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
[vtctld] Migrate GetSrvKeyspace as GetSrvKeyspaces in VtctldServer Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
…cation_positions [vtctld] Migrate ShardReplicationPositions Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
[vtctl|vtctldserver] List/Get Tablets timeouts Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
ajm188
approved these changes
May 19, 2021
| @@ -2770,13 +2709,14 @@ func commandValidateSchemaShard(ctx context.Context, wr *wrangler.Wrangler, subF | |||
| if *excludeTables != "" { | |||
| excludeTableArray = strings.Split(*excludeTables, ",") | |||
| } | |||
| return wr.ValidateSchemaShard(ctx, keyspace, shard, excludeTableArray, *includeViews) | |||
| return wr.ValidateSchemaShard(ctx, keyspace, shard, excludeTableArray, *includeViews, *includeVSchema) | |||
There was a problem hiding this comment.
The only conflict that was potentially concerning to me was around making sure we had Malcolm's work, and it looks to me like we've got the right changes, so I'm good to go on this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are merge conlficts, but given that this branch we don't plan to merge, it should be ok to ignore.