-
Notifications
You must be signed in to change notification settings - Fork 136
Merging Mobile Phase-II changes to Prod #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid showing this button under the dialog when we scroll dialog
… comment hash in URL and smooth scrolling to such comments replaced screen breakpoints in react components with constants
…en if there is not Submit for Review button
# Conflicts: # src/components/Feed/FeedMobile.jsx # src/projects/detail/containers/FeedContainer.js
…obile design earlier
This reverts commit 7313b3d.
Feature/connect mobile
…and 10 in notification center and mobile notifications view
…cording changes to react-components commit dbd0ed6fb84e28cdd9bcdae0125abaf8fc4e570d
This reverts commit c8d2dab.
Feature/connect mobile
vikasrohit
approved these changes
May 2, 2018
vikasrohit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes related to https://github.com/appirio-tech/connect-app/milestone/49