Feature/connect mobile #1979
Merged
Feature/connect mobile #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid showing this button under the dialog when we scroll dialog
… comment hash in URL and smooth scrolling to such comments replaced screen breakpoints in react components with constants
…en if there is not Submit for Review button
# Conflicts: # src/components/Feed/FeedMobile.jsx # src/projects/detail/containers/FeedContainer.js
…obile design earlier
This reverts commit 7313b3d.
Collaborator
Author
gondzo
approved these changes
Apr 30, 2018
Collaborator
gondzo
left a comment
gondzo
left a comment
There was a problem hiding this comment.
Looks great, except for that notifications old/new handling that should be removed. Merging to dev, but we still need to fix that issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tickets from Mobile connect milestone are accomplished https://github.com/appirio-tech/connect-app/milestone/49
Except of non-critical issue #1969