Skip to content

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Sep 22, 2024

Summary by CodeRabbit

  • 新功能

    • 新增接口 TransformOutput,提供更结构化的数据处理。
  • 删除

    • 移除多个与树摇相关的文件和模块,简化了代码结构。
  • 重构

    • 精简了 remove_useless_stmts.rs 文件,移除未使用的导入和函数。

@coderabbitai
Copy link

coderabbitai bot commented Sep 22, 2024

Walkthrough

本次更改涉及多个文件的修改和删除,主要集中在 mako crate 的树摇功能上。具体而言,移除了不再需要的模块和文件,简化了配置和逻辑,同时引入了一个新的接口以增强类型定义。此外,CI 工作流中的环境变量设置也进行了调整,以简化测试过程。

Changes

文件路径 更改摘要
.github/workflows/ci.yml 移除了 Test E2E 步骤中的 RUST_BACKTRACE 环境变量。
crates/mako/src/plugins/tree_shaking.rs 移除了 collect_explicit_prop 模块的导入。
crates/mako/src/plugins/tree_shaking/collect_explicit_prop.rs 删除了 IdExplicitPropAccessCollector 结构体及其相关实现。
crates/mako/src/plugins/tree_shaking/remove_useless_stmts.rs 移除了未使用的导入和 optimize_import_namespace 函数。
crates/mako/src/plugins/tree_shaking/shake.rs 修改了 optimize_modules 函数,直接调用 shake_module,移除了 HELPERS.set 块。
e2e/fixtures/tree-shaking.import_namespace/expect.js 删除了包含断言的文件,用于验证 JavaScript 模块的内容。
e2e/fixtures/tree-shaking.import_namespace/mako.config.json 删除了与优化相关的配置文件。
e2e/fixtures/tree-shaking.import_namespace/src/index.tsx 删除了包含控制台日志的文件,演示了导入函数的用法。
e2e/fixtures/tree-shaking.import_namespace/src/mod.js 删除了 shouldKeep1shouldKeep2shouldNotKeep 三个函数。
packages/mako/binding.d.ts 新增了 TransformOutput 接口,包含 code 和可选的 map 属性。

Possibly related PRs

Poem

在树下兔子跳,
代码简化真妙,
模块不再烦恼,
新接口来报到。
兔子乐开怀,
祝贺更改真精彩! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Tip

Early access features: enabled

We are currently testing new code review model(s) that may lead to higher noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range and nitpick comments (1)
packages/mako/binding.d.ts (1)

6-9: 新接口 TransformOutput 看起来不错

这个新的接口定义清晰,结构合理。它似乎与代码转换输出有关,可能用于处理源映射。

建议:

  1. 考虑为这个接口添加一些注释,解释它的用途和属性的含义,特别是 map 属性的可选性。
  2. 确保在使用这个接口的地方更新相关文档。
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 457f3ed and 8a65b9f.

Files selected for processing (10)
  • .github/workflows/ci.yml (0 hunks)
  • crates/mako/src/plugins/tree_shaking.rs (0 hunks)
  • crates/mako/src/plugins/tree_shaking/collect_explicit_prop.rs (0 hunks)
  • crates/mako/src/plugins/tree_shaking/remove_useless_stmts.rs (2 hunks)
  • crates/mako/src/plugins/tree_shaking/shake.rs (1 hunks)
  • e2e/fixtures/tree-shaking.import_namespace/expect.js (0 hunks)
  • e2e/fixtures/tree-shaking.import_namespace/mako.config.json (0 hunks)
  • e2e/fixtures/tree-shaking.import_namespace/src/index.tsx (0 hunks)
  • e2e/fixtures/tree-shaking.import_namespace/src/mod.js (0 hunks)
  • packages/mako/binding.d.ts (1 hunks)
Files not reviewed due to no reviewable changes (7)
  • .github/workflows/ci.yml
  • crates/mako/src/plugins/tree_shaking.rs
  • crates/mako/src/plugins/tree_shaking/collect_explicit_prop.rs
  • e2e/fixtures/tree-shaking.import_namespace/expect.js
  • e2e/fixtures/tree-shaking.import_namespace/mako.config.json
  • e2e/fixtures/tree-shaking.import_namespace/src/index.tsx
  • e2e/fixtures/tree-shaking.import_namespace/src/mod.js
Additional comments not posted (6)
crates/mako/src/plugins/tree_shaking/remove_useless_stmts.rs (6)

Line range hint 1-11: 导入语句的清理很好

移除未使用的导入有助于提高代码的清晰度和可维护性。剩余的导入看起来都是必要的,这是一个很好的改进。


Line range hint 13-108: remove_useless_stmts 函数的修改是合理的

函数的主要逻辑保持不变,移除了 optimize_import_namespace 函数的调用,这与整体的重构方向一致。函数仍然能够有效地处理无用语句和说明符的移除。


Line range hint 110-159: 没有变化,代码保持原样

这部分代码没有进行任何修改,保持原样是合适的。


Line range hint 161-233: 没有变化,代码保持原样

这部分代码没有进行任何修改,保持原样是合适的。


Line range hint 235-308: 建议检查并更新测试套件

虽然现有的测试没有变化,但由于移除了 optimize_import_namespace 函数,可能需要相应地调整测试套件。建议检查是否有与被移除功能相关的测试需要删除或修改,以及是否需要为当前实现添加新的测试用例。


Line range hint 1-308: 总体修改看起来合理,但需要验证功能完整性

移除 optimize_import_namespace 函数及其相关导入是这次更改的主要内容。这表明处理导入命名空间的方法发生了变化。虽然修改看起来是合理的,但建议验证这个改动是否会对树摇(tree-shaking)插件的整体功能产生负面影响。

请确保:

  1. 所有之前由 optimize_import_namespace 处理的场景现在都能被正确处理。
  2. 这个改动不会导致未使用的导入被错误地保留在代码中。
  3. 树摇功能在各种复杂的导入场景下仍然能够正常工作。

为了验证这些变更的影响,建议运行以下脚本:

这个脚本将帮助我们确认测试覆盖率是否充分,是否有遗漏的相关代码,以及集成测试是否需要更新。

@codecov
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.93%. Comparing base (457f3ed) to head (8a65b9f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1606      +/-   ##
==========================================
- Coverage   62.11%   61.93%   -0.19%     
==========================================
  Files         129      128       -1     
  Lines       15561    15405     -156     
==========================================
- Hits         9666     9541     -125     
+ Misses       5895     5864      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stormslowly stormslowly merged commit a485358 into master Sep 23, 2024
@stormslowly stormslowly deleted the bug/revert_import_namespace branch September 23, 2024 01:04
Jinbao1001 added a commit that referenced this pull request Sep 24, 2024
Jinbao1001 added a commit that referenced this pull request Oct 12, 2024
* Revert "revert:  import namespace optimize  (#1606)"

This reverts commit a485358.

* fix: hash not stable

* fix: deps sort not stable

* fix: deps sort not stable

* fix: deps sort not stable

* fix: delete binding

* fix: var name

* chore: iter to into

* fix: format
elrrrrrrr pushed a commit that referenced this pull request Jul 9, 2025
* fix: env_replacer should not replace user defined variable in scope (#1577)

* fix: env_replacer should not replace user defined variable in scope

* test: add test cases for env_replacer

* chore: code style

* release: @umijs/mako@0.8.11

* chore: bundler-mako@0.8.11

* docs: add changelog for v0.8.11

* fix(tree-shaking): detect export var side effects (#1579)

* test: ✅ add a failure test

* fix: 🐛 add is pure detection in export var decl

* fix: bad output when chunk_loading_global containing quotation mark (#1582)

* chore: ➕ add a subdot cli tool script (#1585)

* fix(win): copy don't work under windows (#1587)

* fix(win): module id should be win_pathed (#1588)

* feat(tree-shaking): optimize import namespace used all exports to partial used of source modules (#1584)

* test: ✅ add failure test case

* feat: ✨ add collect prop explicit field

* feat: ✨ collect explicit member prop access to optizmize used export in dep module
replace USE ALL export to partial used exports

* fix: dedestructuring before collect ExplicitProps

* test: ✅ add back trace env var

* test: ✅ update test case

* fix: 🐛 add globals and helpers

---------

Co-authored-by: Jinbao1001 <nodewebli@gmail.com>

* fix: merge mako config (#1578)

* fix: merge mako config

* fix: merge mako config

* fix:clear deps should not panic when module not found (#1581)

* fix:clear deps should not panic when module not found

* chore: use tracing warn

* fix: delete log

* Revert "fix: merge mako config (#1578)" (#1589)

This reverts commit c08821d.

* fix: watch too many file error (#1550)

* fix: watch too many file error

* chore: delete print

* chore: delete log

* release: @umijs/mako@0.8.8-rc.1

* fix: conflict

* feat: support numeric module Id (#1561)

* feat: moduleIdStrategy support numberous

* fix: typos

* fix: typos

* fix: change name

* fix: typos

* release: @umijs/mako@0.8.12

* chore: fix typo and doc (#1591)

* fix: chunk_loading_global  (#1590)

* fix: bad entry output when chunk_loading_global containing singe quote

* test: add test cases for chunk_loading_global

* docs: update

* chore: update lock

* chore: remove useless dependencies (#1595)

* refactor: 🔥 rm ci warn logs (#1596)

* fix: devServer put static serve proxy after umi proxy middleware  (#1558)

* fix: fix umi load html file failed,

* test: add umi devServer test case

* fix: typo

* fix: hmr on hyper-static-file error

* fix: import expect.mjs error on github workflow.

* fix: import expect.mjs error on github workflow.

* fix: 🐛 expect for error case

* fix: 🐛 dev.hmr dont stop

* fix: 🐛 add OKAM env

* fix: 🐛 wait for mako server

* fix: 🐛 kill by children process

* test: ✅ add umi.css

* refactor: 🎨 unify expect file

* feat: export killMakoDevServer from test-hmr.mjs, make it public for all test case

* test: ✅ unify expect file

* chore: ➕ use express-http-proxy for static proxy

* feat: ✨ better mako static proxy

* test: ✅ support umi dev test with local mako

* chore: ⬆️ update pnpm-lock

* chore: 🎨

* fix: 🐛 ignore children process killed error

---------

Co-authored-by: huanyu.why <huanyu.why@antgroup.com>
Co-authored-by: pshu <pishu.spf@antfin.com>

* fix(tree-shaking): object spread transform should go before deconstructing (#1598)

* fix: 🐛 deconstructing needs object spread transform first

* test: ✅ add guardian syntax

* release: @umijs/mako@0.8.13-canary.20240918.1

* chore: bundler-mako@0.8.13-canary.20240918.1

* chore: 🎨 thread name  after mako (#1601)

* refactor: 🎨 rayon is not friendly to js users

* chore: ✏️ rename tokio worker with mako

* revert:  import namespace optimize  (#1606)

* Revert "fix(tree-shaking): object spread transform should go before deconstructing (#1598)"

This reverts commit 9434d99.

* Revert "feat(tree-shaking): optimize import namespace used all exports to partial used of source modules (#1584)"

This reverts commit 81a52f8.

* chore: 🔧 update mako clean script

* release: @umijs/mako@0.8.13

* chore: bundler-mako@0.8.13

* docs: change log 0923 (#1607)

* docs: 📝 change log

* docs: 📝 change log 0923

* chore: ✏️

* fix: 🐛 turn off express-http-proxy's keep alive (#1612)

* fix: 🐛 turn off express-http-proxy's keep alive

* refactor: 🔥 remove timeout config

* release: @umijs/mako@0.8.14

* chore: bundler-mako@0.8.14

* refactor: napi threadsafe function (#1608)

* refactor: napi threadsafe function

* chore: update binding typings

* refactor: code pieces

* fix: catch napi tsfn promise rejection

* chore: update binding typings

* docs: 📝  change log 20240925 (#1613)

* feat: disable webp to base64 (#1602)

* feat: init

* fix: context

* fix: no use

* fix: typos

* fix: typos

* fix: typos

* fix: typos

* fix(bundler-mako): experimental config should be merged deeply (#1617)

* refactor: config codes organization (#1618)

* refactor: config codes organization

* fix: typos

* refactor: config parse error

* fix: clickToComponent don't work (#1620)

* fix: duplicate_package_checker panic when no package.json is supplied (#1621)

* fix: file_stem index out of bound (#1623)

* feat: add resolve_id plugin hook (#1625)

* feat: add resolve_id plugin hook

* chore: update docs

* feat: add external

* release: @umijs/mako@0.8.15

* chore: bundler-mako@0.8.15

* docs: changelog for 0.8.15

* chore: update the release instruction (#1627)

* refactor: code-splitting config (#1629)

* feat: add loadInclude plugin hook (#1630)

* feat: add { isEntry } for resolve_id plugin hook (#1631)

* feat/upgrade swc (#1444)

* 🚧

* 🚧 a basic working version

* chore: 🚨 lint happy

* refactor: 🎨 adjust to new swc

* refactor: 🎨 remove deprecated methods

* chore: 🚨 lint happy

* feat: ✨ update swc emotion

* chore: 🔧 remove useless profile in sub crate

* chore: 🔧 add back emotion plugin

* refactor: 🎨 add back merge source map

* test: ✅ hot update js file served by hyper static, it use text/javascript

* chore: 🔧 lock update

* chore: 🔧 clean up swc core feature

* refactor: 🎨 fix breaking change of ctxt of span

* fix: 🐛 ctxt apply mark

* refactor: 🎨 use DUMMY CTXT instead of SyntaxContext::empty()

* chore: ⬆️  temperal use mdxjs from kdy branch

* feat: ✨ re-enable mdxjs

* feat: ✨ swc_core 0.100.1

* chore: 🙈  ignore fmt in fixtures

* chore: 🚨 lint happy

* chore: ⬆️  swc_common

* chore: ✏️ typo

* release: @umijs/mako@0.8.1-canary.20240812.1

* chore: bundler-mako@0.8.1-canary.20240812.1

* chore: ⬆️ swc_core 0.100.6

* release: @umijs/mako@0.8.1-canary.20240814.2

* chore: bundler-mako@0.8.1-canary.20240814.2

* chore: 🚨 lint happy

* chore: 🔧 CI build bindings

* chore: 🔧 fix build docker

* refactor: 🔥 remove  aarch64-unknown-linux-gnu

* chore: 🔧 create tar

* chore: 🙈

* release: @umijs/mako@0.8.3-canary.20240820.1

* chore: bundler-mako@0.8.3-canary.20240820.1

* chore: 🔧 wrong donwload param

* chore: 🔧 upload download actions should be same version

* chore: 🔧 try codecov in ci

* refactor: 🔥 remove unnecessary target

* refactor: 🎨 use swc comments

* fix: 🐛 after upgrade to swc_core it should remove paren before minifiy

* refactor: 🎨 move dummy ctxt defintion to ast mod

* chore: 🚨 lint happy

* release: @umijs/mako@0.8.8-canary.20240902.1

* chore: bundler-mako@0.8.8-canary.20240902.1

* release: @umijs/mako@0.8.8-canary.20240903.3

* chore: bundler-mako@0.8.8-canary.20240903.3

* refactor: 🎨 use VisitMut + Fold code style

* chore: ⬆️ update pnpm-lock

* chore: 🙈

* revert: ⏪ delete musl bindin

* release: @umijs/mako@0.8.9-canary.20240909.1

* chore: bundler-mako@0.8.9-canary.20240909.1

* release: @umijs/mako@0.8.11-canary.20240910.1

* chore: bundler-mako@0.8.11-canary.20240910.1

* fix: 🐛 use chars() instead of bytes()

* fix: 🐛 unescape html entity by html escape crate

* release: @umijs/mako@0.8.14-canary.20240924.1

* chore: bundler-mako@0.8.14-canary.20240924.1

* release: @umijs/mako@0.8.15-canary.20240927.1

* chore: bundler-mako@0.8.15-canary.20240927.1

* fix: hash not stable (&revert import * as optimize)   (#1610)

* Revert "revert:  import namespace optimize  (#1606)"

This reverts commit a485358.

* fix: hash not stable

* fix: deps sort not stable

* fix: deps sort not stable

* fix: deps sort not stable

* fix: delete binding

* fix: var name

* chore: iter to into

* fix: format

* release: @umijs/mako@0.9.0

* chore: bundler-mako@0.9.0

* docs: 📝  changelog 0.9.0

* fix: duplicate_package_checker panic when package.json has no version field (#1634)

* feat: magic comment chunk name (#1628)

* refactor: code-splitting config

* feat: support magic comment chunk name basically

* fix: magic comment chunk name for webworker

* refactor: use ImportOptions to represent option from magic comments

* fix: dep replacer when magic comments chunk name existed

* test: update test cases for magic comments chunk name

* fix: dep replacer when dynamic import depencies is missing

* chore: remove useless codes

* refactor: code styles

* docs: add todo for ChunkId

* test: fix visitors::dynamic_import::tests::test_dynamic_import

* test: fix test::hmr

* fix: dep replacer when dynamic import css modules or moduleIdStrategy is hashed

* chore: remove meaning less changes

* test: enable magic comment chunk name in fixtures/umi

* docs: add docs for magic comment chunk name

* feat: support webpackIgnore and makoIgnore magic comment (#1636)

* feat: support webpackIgnore and makoIgnore magic comment

* chore: fmt

* chore: rename magic_comment_chunk_name to magic_comment

* chore: fix typo

* feat: add transform plugin hook (#1637)

* feat: add transform plugin hook

* docs: add docs

* chore: fmt

* chore: perf

* feat: add transformInclude plugin hook (#1639)

* feat: add transformInclude plugin hook

* chore: fmt

* Fix: import namespace optimize panic with nested for of stmt (#1640)

* test: ✅ add import namespace optimize panic test case

* fix: 🐛 fix nested for of stmt panic

* release: @umijs/mako@0.9.2-canary.20241016.1

* chore: bundler-mako@0.9.2-canary.20241016.1

* release: @umijs/mako@0.9.2

* chore: bundler-mako@0.9.2

* docs: 📝  changelog 0.9.2

* feat: add buildEnd plugin hook (#1644)

* feat: add enforce plugin hook (#1646)

* feat: add enforce plugin hook

* chore: code style

* chore: code style

* chore: fix lint

* chore: 🎨 add missing binding type

* release: @umijs/mako@0.9.3-canary.20241016.1

* chore: bundler-mako@0.9.3-canary.20241016.1

* feat: add writeBundle plugin hook (#1650)

* feat: add watch_changes plugin hook (#1651)

* feat: add watch_changes plugin hook

* chore: fix lint

* chore: fix ts define

* fix: mako on windows don't work (#1652)

* fix: devtool sourcemap explosion in windows (#1653)

* chore: remove dead code

* fix: should not re-group when span changed (#1654)

* fix: umd should be import as cjs (#1642)

* fix: umd should be import as cjs

* refactor: 🎨 just short circuit typeof define to prevent define takes effect

* revert: ⏪ binding.d.ts

---------

Co-authored-by: pshu <pishu.spf@antfin.com>

* fix: 🐛 add process.env.SOCKET_SERVER define to prevent process polyfilll (#1655)

* release: @umijs/mako@0.9.3-canary.20241023.1

* chore: bundler-mako@0.9.3-canary.20241023.1

* release: @umijs/mako@0.9.3

* chore: bundler-mako@0.9.3

* docs: changelog for 0.9.3

* fix: hmr with magic comment chunk name (#1663)

* feat: enable magicComment features by default (#1667)

* feat(bundler-mako): add moduleIdStrategy to supportMakoConfigKeys (#1664)

* fix: async module in circular dependence (#1659)

* test: ✅ add test async module in circular dependencies

* refactor: 🎨 handle async polution by traversal

* refactor: 🎨 use default over expect

* feat: compatible codeSplitting config with umi (#1669)

* feat: compatible codeSplitting config with umi

* test: fix e2e code-splitting.granular

* fix: umi codeSplitting: depPerChunk

* Feat/benchmark workflows (#1671)

* feat: benchmark-workflows

* fix: 修改Github Secrets

* release: @umijs/mako@0.9.4

* chore: bundler-mako@0.9.4

* docs: 📝 changelog 0.9.4

* chore: Optional parameters (#1679)

* chore: Optional parameters

* Update index.ts

* fix: skip module should skip async module (#1662)

* release: @umijs/mako@0.9.5

* chore: bundler-mako@0.9.5

* docs: update changelog

* docs: update changelog

* feat(ssu): handle dependence changing while watching (#1690)

* refactor: 🎨 add after update aspect for rebuild cached modules

* refactor: 🎨 add next_build aspect in build_my_modify

* feat: ✨ 区分 ssu firstbuild 和  updating 两者状态

* fix: pnpm workspace watch too many files (#1684)

* fix: ✅ ts annotated declare variable treat as top level variable (#1682)

* test: ✅ add ts declare annotated variable as top level

* refactor: 🎨 mv clean syntax context to visitors folder

* fix: 🐛 strip ts/tsx first, then do normal transform

* feat: move ensure runtime to entry  (#1660)

* feat: ✨ add ensure2 replace in dynamic replace

* feat: ✨ ensure 2 runtime

* feat: ✨ add experimental centralEnsure config

* refactor: 🎨 add struct ReslvedReplaceInfo

* feat: ✨ add central ensure plugin

* refactor: 🎨 extract module ensure map

* refactor: 🎨 add back chunk id in replace info

* refactor: 🎨 fix case one source with different import type

* refactor: 🎨 extract hmr runtime update code aspect

* release: @umijs/mako@0.9.6-canary.20241107.1

* chore: bundler-mako@0.9.6-canary.20241107.1

* feat: keep unresolved nodejs require (#1689)

* fix: regexpr for nodejs intenal modules igonre

* feat: not replace unresolved nodejs require to __mako_require__

* fix: define util require should be __mako_require__

* feat: add expreriental.keep_unresolved_node_require

* feat: add expreriental.ignore_non_literal_require

* chore: 🔥 remove unused fn

* release: @umijs/mako@0.9.6

* chore: bundler-mako@0.9.6

* docs: changelog for 0.9.6

* fix(SSU): 🐛 in case external not avaible to all  entries (#1698)

* fix(SSU): 🐛 in case external not avaible to all  entries

* refactor: 🎨 explict ignore the error

* fix: devserver response header add cacheControl no-cache (#1692)

* fix: add no-cache

* feat: add cross origin

* fix: resonse header add cors and no_cache for all branch (#1699)

* fix: judge devServer instead of writeToDisk

* fix: add branch header

* refactor: 🎨 static file with 0 ages

---------

Co-authored-by: pshu <pishu.spf@antfin.com>

* release: @umijs/mako@0.9.7

* chore: bundler-mako@0.9.7

* docs: 📝  update changelog for 0.9.7

* chore: ✏️ remove some if (#1706)

* fix: optimization.concatenateModules dts lost (#1708)

* refactor: 🔥 enter ensure 使用 chunk sync dep 减少首屏 chunk 数量 (#1707)

* fix: 🐛 typing of stats (#1712)

* fix: 🐛 detect circular deps output file content (#1715)

* chore: update @umijs/mako typings

* feat: ensure esm imports exists when mode is production (#1709)

* feat: ensure esm imports exists when mode is production

* release: @umijs/mako@0.9.8

* chore: bundler-mako@0.9.8

* docs: update docs

* fix: node ignores (#1716)

* feat: supports publicPath: auto (#1717)

* feat: auto resolve entry file extension (#1718)

* feat: auto resolve entry file extension

* fix: remove useless clone

* Fix/context module source with first empty quasis (#1719)

* test: ✅ add first empty quasis template string module source case

* fix: 🐛 first emtpy quasis case

* fix: inline css config deserialize (#1720)

* fix: node ignore should support node: prefixed only built-in modules (#1721)

* release: @umijs/mako@0.9.9

* docs: suggest using volta to manage node and pnpm's version

* chore: bundler-mako@0.9.9

* docs: update CHANGELOG.md

* feat: supports umd export (#1723)

* feat: supports umd export

* fix: umd config binding typing

* fix: typos

* fix: umd export

* chore: update typings

* fix: replace the "typeof __webpack_require__" content (#1688)

* fix: replace the "typeof __webpack_require__" content

* fix: add some other webpack string name

* fix: 增加对typeof  表达式的处理

* fix: delete log

* fix: rename

---------

Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>

* fix: umd config deserialization (#1726)

* feat: support case sensitive (#1714)

* feat: add CaseSensitivePlugin

* FIX: update path check

* fix: clippy error

* fix: 调整判断

* fix: 修复目录读取

* fix: 修改参数名称

* fix: 调整测试方式添加e2e断言,并增加配置项只有mac系统下才需要开启相关配置

* fix: 删除过滤条件

* fix: 删除多余测试文件,增加更新内容

* fix:  删除多余log

* fix: 测试执行

* fix: 添加测试系统

* fix: 调整顺序

* fix: 添加测试系统

* fix: 非mac环境断言

* fix: 引用遗漏

* fix: 断言

* fix: 删除默认

* fix: 默认配置

* fix: 测试覆盖

* Revert "fix: 测试覆盖"

This reverts commit b0a2e66.

---------

Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>

* refactor: 🔥 remove unecessary transform (#1727)

* feat: output filename (#1725)

* refactor: 🎨 add file name template and chunk name in ChunkFile struct

* feat: ✨ add config to output#filename

* feat: ✨ render filename when output#filename configed

* feat: ✨ calc hash in ast impl for entry

* test: ✅ add test case

* test: ✅ add ut

* chore: 🔧 disable codecov error

* refactor: 🎨 remove clone

* fix: 🐛 hash when necessary

* chore: 🔧 add codecov.yml

* release: @umijs/mako@0.9.10-canary.20241218.1

* chore: ⬆️ update pnpm-lock

* feat: native plugin init  (#1691)

* feat: init rust plugin

* chore: delete print

* Rename cargo.toml to Cargo.toml

* chore: update

* fix: type

* fix: plugin options string

* fix: cfg test

* release: @umijs/mako@0.10.0

* chore: bundler-mako@0.10.0

* docs: 📝 changelog 2024.12.20

* chore: 🔧 for quick setup dep to debug (#1733)

* fix: support optional chaining in environment variable (#1730)

* fix: support optional chaining in environment variable

* test(): add edge cases for optional chaining in env_replacer

* refactor: 🎨 no need to resolve empty url in css (#1732)

* refactor: 🎨 no need to resolve empty url in css

* refactor: 🎨 add test case

* feat: support unplugin context (#1728)

* feat: support plugin context

* fix: napi context

* chore: revert changes

* chore: improve

* feat: add error

* feat: warn and error support object

* feat: support emit_file

* ci: fix test

* chore: improve

* chore: update test

* chore: format

* chore: don't support add watch file

* feat: load and transform adapter, and add unplugin-replace example

* chore: test unplugin-icons

* chore: update pnpm-lock.yaml

* docs: improve

---------

Co-authored-by: xusd320 <xusd320@gmail.com>

* fix: legacy octal escape is not permitted in strict mode (#1736)

* fix: legacy octal escape is not permitted in strict mode

* fix: e2e inline css

* release: @umijs/mako@0.11.0

* chore: bundler-mako@0.11.0

* fix: pnpm lock

* docs: 📝 changelog 2024.12.26

* Revert "feat: support unplugin context (#1728)" (#1737)

This reverts commit 3dd6d9d.

* release: @umijs/mako@0.11.1

* chore: bundler-mako@0.11.1

* feat: support unplugin context (#1741)

* feat: support plugin context

* fix: napi context

* chore: revert changes

* chore: improve

* feat: add error

* feat: warn and error support object

* feat: support emit_file

* ci: fix test

* chore: improve

* chore: update test

* chore: format

* chore: don't support add watch file

* feat: load and transform adapter, and add unplugin-replace example

* chore: test unplugin-icons

* chore: update pnpm-lock.yaml

* docs: improve

---------

Co-authored-by: xusd320 <xusd320@gmail.com>

* fix: #1007 (#1738)

support BinaryExpression

Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>

* fix: win path problem with context module and require context (#1742)

* chore(mako): add debug notice for local builds (#1743)

* fix: normalize Windows paths in ModuleId constructors (#1744)

* fix: normalize Windows paths in Compiler output path handling (#1745)

* fix: typos

* release: @umijs/mako@0.11.2

* chore: bundler-mako@0.11.2

* docs: update CHANGELOG.md

* feat(create-mako): refactor create-mako (#1751)

* chore: add issue and pull request templates for better contribution guidelines (#1753)

* fix: ensure parent directories are created when writing to disk in MemoryChunkFileCache (#1755)

* chore: release @umijs/tools

* release: @umijs/mako@0.11.3

* chore: update the release introduction

* ci: fix ci (#1758)

* chore: upgrade @umijs/tools and do github release and changelog generate and translation by script

* docs: changelog for 0.11.3

* chore: add check-ecosystem-usages script (#1759)

* fix: analyze don't work in safari (#1761)

* fix(mako): cli delay exit (#1762)

* dep: @umijs/tools@0.1.23

* fix: load wasm (#1705)

* fix: 修复load .wasm文件对importObject的处理

* fix: 删除没必要的输出

* fix: 修改生成的成员表达式js代码

* fix: 变量重命名

* fix: 修复代码lint报错

* test: 补充wasm_runtime测试用例

* chore: 补充import js方式的示例

* chore: 修改import js示例wasm产物格式

* chore: wasmparser依赖包在配置文件的位置

* chore: 删除多余的.wasm load逻辑

---------

Co-authored-by: xusd320 <xusd320@gmail.com>

* fix: chunk groups' order when building mpa (#1763)

* feat(copy): support advanced copy configuration with custom target paths (#1711)

* feat(copy): support advanced copy configuration with custom target paths

- Add CopyConfig enum to support both basic and advanced copy modes
- Basic mode: maintains backward compatibility with string[] format
- Advanced mode: supports {from: string, to: string} format for custom paths
- Update copy plugin to handle both configuration formats
- Ensure target directories are created automatically

Example config:
{
  'copy': [
    'public',                              // basic mode
    { 'from': 'assets', 'to': 'static' }  // advanced mode
  ]
}

* fix(copy): prevent path traversal in copy plugin

Add path canonicalization and validation to ensure target paths remain within the destination directory

* chore: Update `copy` config type in Mako bundler

- Updated the type of the `copy` property in the `BuildParams` interface to support both `string` and `{ from: string; to: string }`.
- Ensured the `copy` configuration is properly validated to handle both types.

* docs: Update `copy` config type in documentation

- Updated the `copy` property type in the configuration documentation to reflect the change from `string[]` to `(string | { from: string; to: string })[]`.
- Clarified that the `copy` configuration can now accept both strings and objects with `from` and `to` properties.

* test(copy): add e2e tests for copy plugin from/to pattern

- Update config.copy test fixtures to cover from/to pattern
- Add assertions for copied files in new location
- Adjust copy plugin path validation

* fix(copy): improve path validation and cleanup for copy plugin

- Add directory cleanup when path validation fails
- Use canonicalized paths for more reliable path validation
- Add concatenateModules option type to BuildParams

* fix: ci (#1768)

* release: @umijs/mako@0.11.4

* chore: bump version

* docs: 📝 changelog 2025.02.12

* chore: update changelog 2025.02.12

* fix: plugin context gc (#1769)

* fix: mako已经支持了scss 但是没有支持module.scss文件 (#1770)

Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>

* feat: add module federation plugin (#1764)

* feat: support module federation

* feat: mf exposes to remote entries

* chore: code styles

* feat: mf container entry impl

* fix: mf container entry

* fix: mf runtime initOptions

* feat: add containter references

* feat: impl mf remote

* feat: improve mf exposes

* fix: mf exposes runtime factory

* fix: mf plugin execution order

* chore: update mf demo

* feat: generate mf manifest in rust

* fix: remote stats.json

* refactor: code styles

* chore: add some FIXME

* refactor: mf plugin mods files

* refactor: mf plugin mods files

* chore: remove dead code

* --wip-- [skip ci]

* fix: remote stats.json

* fix: typos

* chore: simpify mf runtime codes fmt

* refactor: mf containter plugin

* feat: mf shared workaround

* feat: mf shared workaround

* fix: runtime template and remove some useless codes

* fix: mf dev server

* fix: mf shared config

* feat: supports chunk group exclude

* feat: mf patch code splitting

* feat: mf shared manifest

* feat: add config hash for mf shared module

* chore: update mako typings

* chore: code styles

* chore: fix typo

* chore: code styles

* perf: improve performance

* chore: code styles

* chore: rename types

* feat: add options to disable mf manifest

* feat: entry config should be defined as BTreeMap

* fix: mf shared consume and supports eager config

* fix: mf shared eager

* fix: not generate chunk for mf remote module

* fix: typos

* feat: add entry filename supports

* chore: remove meaning less changes

* fix: entry filename and mf config

* release: @umijs/mako@0.11.4-canary.20250206.0

* fix: ignore shared dep when it is been external

* Revert "release: @umijs/mako@0.11.4-canary.20250206.0"

This reverts commit d3105d9.

* release: @umijs/mako@0.11.4-canary.20250207.0

* fix: skip serialize mf manifest remoteEntry if none

* fix: mf manifest remoteEntry address

* Revert "release: @umijs/mako@0.11.4-canary.20250207.0"

This reverts commit 6179982.

* fix: typo

* fix: mako mf manifest publicPath

* fix: mf manifest panic

* fix: mf typings

* test: add e2e test for mf

* fix: typo

* chore: update README

* fix: update mf bingding typings

* fix: typings

* fix: should not generate mf remotes runtime when remotes is empty

* chore: remote wrong comment

* feat: add chunk matcher for mf

* fix: mf binding typings

* chore: remove debug print statements

* docs: update moduleFederation configuration docs

* fix: mf config docs

* chore: update CONTRIBUTING.md

* release: @umijs/mako@0.11.5

* chore: update CHANGELOG.md and versions

* feat: support to disable camel2DashComponentName of transformImport (#1773)

* feat: support to disable camel2DashComponentName of transformImport

* fix: typings

* fix: 修复sass/less-loader的路径解析 (#1771)

* fix: 支持webpack中sass-loader的路径解析

* chore: 调整目录

* chore: 移除注释等

* chore: 引入loader-runner

* chore: sass-loader

* chore: 修改loader返回空值处理

* test: 设置loader resolver的别名

* chore: update lock

* fix: loader options

* refactor: 提取插件代码

* fix: getResolve

* fix: 修复runLoaders中的错误处理逻辑

* release: @umijs/mako@0.11.6

* fix: pnpm-lock

* chore: update changelog for v0.11.6

* chore: update changelog for v0.11.6

* chore: update changelog for v0.11.6

* fix: watch less and sass dependencies (#1779)

* chore: stash

* chore: stash

* feat: LessModuleGraph

* feat: less-import-plugin

* chore: 删除多余代码

* fix: 兼容url()

* chore: plugin

* feat: add beforeRebuild hook

* ci: clippy format

* fix: paths去重

* fix: rename _path

* chore: rust层增加临时过滤文件方式

* chore: 提取createParallelLoader

* refactor: before_rebuild hook (#1785)

* refactor: before_rebuild hook -n

* fix: typos

* feat: postcss-loader (#1787)

* feat: 支持postcss-loader

* chore: 合并postcss到options传给render

* chore: 更新.gitignore以排除less.postcss的node_modules目录

* feat: 添加PostCSS插件支持并更新相关类型定义

* refactor: 简化Less和Sass插件中的选项传递

* docs: 添加postcss支持的配置说明

* feat: 添加对PostCSS的支持,更新相关插件以集成postLoaders

* feat: 更新Less和Sass插件以移除postLoaders,增强PostCSS支持

* test: 补充postcss测试用例

* fix: use transpiled hmr runtime (#1813)

* fix: use transpiled hmr runtime (#1814)

* release: @umijs/mako@0.11.7

* fix: package-lock.json

* fix: use transpiled hmr runtime entry (#1815)

* fix: disable parallel sassLoader because sassOptions.function cann't be shared cross workers (#1816)

* release: @umijs/mako@0.11.8

* fix: package-lock.json

* fix: package-lock.json

* fix: typos

* chore: update changelog for v0.11.8

* fix: less,sass,postcss loader panic (#1818)

* release: @umijs/mako@0.11.9

* fix: package-lock.json

* chore: update changelog for v0.11.9

* fix: worker threads panic on linux (#1823)

* release: @umijs/mako@0.11.10

* fix: package-lock.json

* chore: update changelog for v0.11.10

* fix: dev支持inline-source-map (#1859)

Co-authored-by: dongqing.mdq <dongqing.mdq@antgroup.com>

* release: @umijs/mako@0.11.11

* fix: package-lock.json

* chore: update changelog for v0.11.11

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* fix: less resolve alias (#1906)

* docs: update README.md (#1907)

* Update README.md

* Apply suggestions from code review

Co-authored-by: Peach <scdzwyxst@gmail.com>

* Update README.md

* Update README.md

---------

Co-authored-by: Peach <scdzwyxst@gmail.com>

* Update README.md

* Update README.md

* release: @umijs/mako@0.11.12

* feat: update pnpm log

* chore: update changelog for v0.11.12

* fix: panic on docker linux (#1909)

* doc: add openomy (#1910)

* release: @umijs/mako@0.11.13

* chore: update changelog for v0.11.13

* chore: remove codecov

* chore: update examples/multiple-entries-heavy

* feat: support inline-source-map devtool option (#1965)

Co-authored-by: hanzebang.hzb <hanzebang.hzb@antgroup.com>

* chore: truncate old codes

---------

Co-authored-by: pshu <pishu.spf@antfin.com>
Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
Co-authored-by: Jinbao1001 <nodewebli@gmail.com>
Co-authored-by: money <hualigushi@163.com>
Co-authored-by: eisonhower <why490078184@gmail.com>
Co-authored-by: huanyu.why <huanyu.why@antgroup.com>
Co-authored-by: PeachScript <scdzwyxst@gmail.com>
Co-authored-by: Wu-kung <1434246346@qq.com>
Co-authored-by: 聪小陈 <xiaohuoni@users.noreply.github.com>
Co-authored-by: akitaSummer <akitasummer@outlook.com>
Co-authored-by: Shi Kuan <shikuan1992@gmail.com>
Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>
Co-authored-by: yezao <75713784+yezaoshu@users.noreply.github.com>
Co-authored-by: 御风 <18012261618@126.com>
Co-authored-by: bqxbqx <132878537+BQXBQX@users.noreply.github.com>
Co-authored-by: miaodongqing <dongqing_miao@163.com>
Co-authored-by: dongqing.mdq <dongqing.mdq@antgroup.com>
Co-authored-by: kiner-tang(星河) <1127031143@qq.com>
Co-authored-by: hanzebang <46307343+hanzebang@users.noreply.github.com>
Co-authored-by: hanzebang.hzb <hanzebang.hzb@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant