fix: load wasm #1705
Merged
fix: load wasm #1705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough该拉取请求引入了对 Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Outside diff range and nitpick comments (14)
examples/import-resources/minus-wasm-pack/index.js (1)
1-3: 建议添加错误处理机制当前的WebAssembly初始化过程没有错误处理机制。建议添加try-catch块来处理可能的初始化失败情况。
建议修改如下：
import { __wbg_set_wasm } from './index_bg.js'; import * as wasm from './index_bg.wasm'; -__wbg_set_wasm(wasm); +try { + __wbg_set_wasm(wasm); +} catch (error) { + console.error('WebAssembly初始化失败:', error); + throw error; +}examples/import-resources/minus-wasm-pack/index.d.ts (4)
1-2: 代码规范配置需要明确原因建议在注释中说明禁用 lint 规则的具体原因，这样可以帮助其他开发者理解为什么需要禁用这些规则。
-/* tslint:disable */ -/* eslint-disable */ +/* tslint:disable -- 由于 WebAssembly 生成的代码可能不符合规范要求 */ +/* eslint-disable -- 由于 WebAssembly 生成的代码可能不符合规范要求 */
3-5: greet 函数缺少功能说明文档函数的 JSDoc 注释是空的，建议添加函数的用途说明。
/** + * 显示问候信息 */
6-9: greet2 函数文档需要补充参数说明JSDoc 注释中虽然标注了参数类型，但缺少参数用途的说明。
/** + * 显示带有指定名称的问候信息 * @param {string} name + * @param {string} name 要显示的用户名称 */
10-15: minus 函数文档需要完善建议补充函数的具体用途说明和返回值的含义。
/** + * 计算两个数字的差值 * @param {number} a + * @param {number} a 被减数 * @param {number} b + * @param {number} b 减数 * @returns {number} + * @returns {number} 返回 a - b 的结果 */examples/import-resources/minus-wasm-pack/index_bg.wasm.d.ts (3)
1-2: 建议添加文件级别的 JSDoc 注释为了提高代码的可维护性，建议在禁用 lint 规则的同时添加文件说明，解释这个 WebAssembly 模块的用途。
/* tslint:disable */ /* eslint-disable */ +/** + * @file WebAssembly 模块类型声明 + * @description 该文件定义了 WebAssembly 模块导出的内存和函数接口 + */
4-6: 建议为公共函数添加 JSDoc 文档公共函数缺少参数说明和使用示例，这对使用者不够友好。
+/** + * @param a 第一个数字 + * @param b 第二个数字 + */ export function greet2(a: number, b: number): void; +/** + * 计算两个数字的差值 + * @param a 被减数 + * @param b 减数 + * @returns 差值 + */ export function minus(a: number, b: number): number; +/** + * 打招呼函数 + */ export function greet(): void;
7-13: 注意内存分配函数的使用安全性
__wbindgen_malloc和__wbindgen_realloc是关键的内存管理函数，建议：
- 添加警告注释，说明这些是内部使用的函数
- 确保这些函数不会被外部直接调用
建议添加以下注释：
+/** + * @internal + * 仅供 wasm-bindgen 内部使用的内存分配函数 + * @private + */ export function __wbindgen_malloc(a: number, b: number): number; +/** + * @internal + * 仅供 wasm-bindgen 内部使用的内存重分配函数 + * @private + */ export function __wbindgen_realloc( a: number, b: number, c: number, d: number, ): number;examples/import-resources/index.tsx (1)
10-10: WebAssembly 模块导入方式建议优化建议使用具名导入来明确导入的具体函数，这样可以减小打包体积并提高代码可读性。
建议修改为：
-import * as wasm from './minus-wasm-pack'; +import { minus } from './minus-wasm-pack';examples/import-resources/minus-wasm-pack/index_bg.js (2)
8-9: 建议修改模块加载方式使用
(0, module.require)('util').TextDecoder可能会导致兼容性问题。建议直接使用require('util').TextDecoder，以提高代码的可读性和可靠性。
16-16: 移除不必要的空解码操作
cachedTextDecoder.decode();没有传入参数，可能没有实际作用。建议移除这行代码，以简化代码。crates/mako/src/plugins/wasm_runtime.rs (3)
42-42: 建议改进文件扩展名的检查方式在第42行，使用
file.path.to_string_lossy().ends_with(".wasm")来判断文件是否为.wasm文件，这种方式可能不够严谨。建议使用extension方法获取文件扩展名，以避免可能的误判。建议修改如下：
- if file.path.to_string_lossy().ends_with(".wasm") { + if file.path.extension().and_then(|ext| ext.to_str()) == Some("wasm") {
60-66: 简化import_objs_map的更新逻辑在处理导入对象映射时，可以使用
EntryAPI 来简化代码，提高代码的可读性和效率。建议修改如下：
- if let Some(import_obj) = import_objs_map.get_mut(module) { - import_obj.push(name.to_string()); - } else { - import_objs_map.insert(module, vec![name.to_string()]); - } + import_objs_map.entry(module) + .or_insert_with(Vec::new) + .push(name.to_string());
54-73: 考虑处理其他类型的Payload目前仅处理了
Payload::ImportSection，可能会遗漏其他重要的段信息。建议考虑处理更多类型的Payload，以增强对WebAssembly文件的支持。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockexamples/import-resources/minus-wasm-pack/index_bg.wasmis excluded by!**/*.wasm
📒 Files selected for processing (7)
crates/mako/Cargo.toml(1 hunks)crates/mako/src/plugins/wasm_runtime.rs(2 hunks)examples/import-resources/index.tsx(2 hunks)examples/import-resources/minus-wasm-pack/index.d.ts(1 hunks)examples/import-resources/minus-wasm-pack/index.js(1 hunks)examples/import-resources/minus-wasm-pack/index_bg.js(1 hunks)examples/import-resources/minus-wasm-pack/index_bg.wasm.d.ts(1 hunks)
🔇 Additional comments (6)
examples/import-resources/minus-wasm-pack/index.js (2)
1-3: 导入顺序和初始化逻辑正确！
WebAssembly模块的导入和初始化顺序符合最佳实践。
4-4: 请确认导出策略的安全性
使用export *可能会暴露一些不应该公开的内部实现细节。建议明确列出需要导出的函数和变量。
运行以下脚本来检查index_bg.js中导出的所有内容：
✅ Verification successful
export * 导出策略在此场景中是安全的
经过分析，index_bg.js 中导出的内容都是 WebAssembly 绑定所必需的：
- 公共 API 函数：
greet()、greet2(name)、minus(a, b) - WebAssembly 内部绑定函数：
__wbg_set_wasm、__wbg_alert_*、__wbg_prompt_*
这些导出都是由 wasm-bindgen 工具自动生成的标准绑定代码，没有暴露任何不应该公开的实现细节。使用 export * 在这种自动生成的绑定代码场景下是合适且安全的。
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 描述：检查index_bg.js中的所有导出内容
# 搜索所有export语句
rg "export" "examples/import-resources/minus-wasm-pack/index_bg.js"
Length of output: 309
Script:
#!/bin/bash
# 检查index_bg.js中导出函数的具体实现
ast-grep --pattern 'export function $name($$$) { $$$ }'
Length of output: 150
Script:
#!/bin/bash
# 检查index_bg.js文件的完整内容
cat examples/import-resources/minus-wasm-pack/index_bg.js
Length of output: 2971
examples/import-resources/minus-wasm-pack/index.d.ts (1)
1-15: 验证 WebAssembly 模块导出函数的完整性
需要确保声明文件中的函数与 WebAssembly 模块导出的函数完全匹配。
✅ Verification successful
Let me gather more information about the implementation of these functions to verify their completeness.
WebAssembly 模块导出函数验证完成
根据 index_bg.js 中的实现，我们可以确认声明文件中的三个函数 greet()、greet2(name) 和 minus(a, b) 都有对应的 WebAssembly 绑定实现：
greet()直接调用 wasm.greet()greet2(name)通过字符串传递机制调用底层 WebAssembly 函数minus(a, b)调用 wasm.minus() 并返回计算结果
声明文件中的类型定义与实际实现完全匹配。
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 描述：验证 .wasm 文件导出的函数与声明文件是否匹配
# 使用 wasmparser 检查 .wasm 文件的导出函数
fd -e wasm . examples/import-resources/minus-wasm-pack/ -x wasmparser {} | grep -A 5 "export"
# 检查相关的 JavaScript 胶水代码
rg -t js "export function (greet|greet2|minus)" examples/import-resources/minus-wasm-pack/
Length of output: 479
Script:
#!/bin/bash
# 检查 index_bg.js 中的函数实现
rg -A 5 "export function (greet|greet2|minus)" examples/import-resources/minus-wasm-pack/index_bg.js
# 检查是否有其他相关的实现文件
fd . examples/import-resources/minus-wasm-pack/ -x file {}
# 查找可能的 Rust 源代码
fd -e rs . examples/import-resources/minus-wasm-pack/
Length of output: 753
examples/import-resources/minus-wasm-pack/index_bg.wasm.d.ts (1)
3-3: 建议添加内存配置说明
WebAssembly.Memory 的配置对性能有重要影响。建议添加注释说明内存的初始大小和最大大小限制。
运行以下脚本检查相关的 Rust 代码中的内存配置：
examples/import-resources/index.tsx (1)
36-39: 🛠️ Refactor suggestion
验证 WASM 函数调用的错误处理
当前代码直接调用 wasm.minus 函数但没有进行错误处理。WebAssembly 函数可能会抛出异常，建议添加错误处理逻辑。
建议修改为：
<h2>
- Test import .wasm file(generated by wasm-pack) async: {num1} - {num2} ={' '}
- {wasm.minus(num1, num2)}
+ Test import .wasm file(generated by wasm-pack) async: {num1} - {num2} = {' '}
+ {(() => {
+ try {
+ return wasm.minus(num1, num2);
+ } catch (error) {
+ console.error('WASM 减法运算失败:', error);
+ return '计算出错';
+ }
+ })()}
</h2>让我验证一下这个 WASM 函数的实现：
examples/import-resources/minus-wasm-pack/index_bg.js (1)
127-133: 验证直接调用浏览器函数的安全性
直接调用 alert 和 prompt 等浏览器函数可能存在安全风险。建议验证这些函数的使用是否符合安全最佳实践，防止可能的 XSS 攻击或恶意代码执行。
crates/mako/Cargo.toml
Outdated
| serde = { workspace = true } | ||
| serde_json = { workspace = true } | ||
| url = { version = "2.5.0" } | ||
| wasmparser = "0.207.0" |
There was a problem hiding this comment.
💡 Codebase verification
建议更新 wasmparser 依赖版本
当前使用的版本 (0.207.0) 已过时。最新的稳定版本是 0.220.0，建议：
- 更新到最新版本
- 使用版本范围声明以自动获取补丁更新：
wasmparser = "^0.220.0"
安全检查显示该包没有已知的安全漏洞。
🔗 Analysis chain
建议检查 wasmparser 的版本选择
建议考虑以下几点：
- 使用版本范围声明（例如
^0.207.0）来自动接收补丁版本的更新 - 确认当前选择的版本是否为最新的稳定版本
运行以下脚本来验证版本信息：
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 检查 wasmparser 包的最新版本和安全公告
# 从 crates.io 获取最新版本信息
curl -s https://crates.io/api/v1/crates/wasmparser | jq -r '.crate.max_stable_version'
# 检查安全公告
gh api graphql -f query='
{
securityVulnerabilities(first: 5, ecosystem: RUST, package: "wasmparser") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'
Length of output: 439
Comment on lines
68
to
69
| println!("import error"); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
改进错误处理，提供详细的错误信息
当前在解析导入时，如果发生错误，仅打印了"import error"，这可能不足以帮助调试。建议在错误信息中包含具体的错误详情。
建议修改如下：
- println!("import error");
+ eprintln!("Import parsing error: {:?}", e);Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (3)
crates/mako/src/plugins/wasm_runtime.rs (3)
55-68: WASM导入解析逻辑实现合理代码使用
wasmparser库来解析WASM文件的导入部分，实现逻辑清晰。建议添加错误日志，以便调试问题。if let Ok(Import { module, name, ty }) = import { + log::debug!("处理WASM导入: module={}, name={}", module, name); if let Some(import_obj) = import_objs_map.get_mut(module) {
70-89: 建议优化字符串处理效率当前实现中的字符串拼接可以通过使用
String的预分配来优化性能。- let mut js_imports_str = String::new(); - let mut import_objs_str = String::new(); + let mut js_imports_str = String::with_capacity(import_objs_map.len() * 50); + let mut import_objs_str = String::with_capacity(import_objs_map.len() * 100);
106-110: 建议添加类型注释为了提高代码可读性，建议为生成的JavaScript内容添加类型注释。
return Ok(Some(Content::Js(JsContent { content, + // 生成的JavaScript代码包含WASM模块的导入和导出 ..Default::default() })));
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
crates/mako/src/plugins/wasm_runtime.rs(2 hunks)
🔇 Additional comments (2)
crates/mako/src/plugins/wasm_runtime.rs (2)
1-11: 导入声明看起来不错！
代码引入了适当的依赖项来处理WebAssembly文件的解析和导入处理。使用wasmparser作为WASM解析器是个不错的选择。
94-104:
函数名拼写错误
_interopreRequireWasm存在拼写错误，应该是_interopRequireWasm。
- "module.exports = require._interopreRequireWasm(exports, \"{}\")",
+ "module.exports = require._interopRequireWasm(exports, \"{}\")",- "module.exports = require._interopreRequireWasm(exports, \"{}\", {{{}}})",
+ "module.exports = require._interopRequireWasm(exports, \"{}\", {{{}}})",
Comment on lines
41
to
54
| let file = param.file; | ||
| if file.path.to_string_lossy().ends_with(".wasm") { | ||
| let final_file_name = format!( | ||
| "{}.{}.{}", | ||
| file.get_file_stem(), | ||
| file.get_content_hash()?, | ||
| file.extname | ||
| ); | ||
| let origin_path = file.pathname.to_string_lossy().to_string(); | ||
| _context.emit_assets(origin_path, final_file_name.clone()); | ||
|
|
||
| let mut buffer = Vec::new(); | ||
| File::open(file.path.as_path())?.read_to_end(&mut buffer)?; | ||
| // Parse wasm file to get imports |
There was a problem hiding this comment.
🛠️ Refactor suggestion
建议改进错误处理和内存管理
当前实现存在以下需要注意的地方：
- 文件操作缺少详细的错误处理，建议添加具体的错误信息
- 将整个WASM文件读入内存可能会对大文件造成问题
建议修改如下：
- File::open(file.path.as_path())?.read_to_end(&mut buffer)?;
+ File::open(&file.path)
+ .map_err(|e| anyhow::anyhow!("无法打开WASM文件 {}: {}", file.path.display(), e))?
+ .read_to_end(&mut buffer)
+ .map_err(|e| anyhow::anyhow!("读取WASM文件失败: {}", e))?;对于大文件，可以考虑使用流式处理或设置最大文件大小限制。
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| let file = param.file; | |
| if file.path.to_string_lossy().ends_with(".wasm") { | |
| let final_file_name = format!( | |
| "{}.{}.{}", | |
| file.get_file_stem(), | |
| file.get_content_hash()?, | |
| file.extname | |
| ); | |
| let origin_path = file.pathname.to_string_lossy().to_string(); | |
| _context.emit_assets(origin_path, final_file_name.clone()); | |
| let mut buffer = Vec::new(); | |
| File::open(file.path.as_path())?.read_to_end(&mut buffer)?; | |
| // Parse wasm file to get imports | |
| let file = param.file; | |
| if file.path.to_string_lossy().ends_with(".wasm") { | |
| let final_file_name = format!( | |
| "{}.{}.{}", | |
| file.get_file_stem(), | |
| file.get_content_hash()?, | |
| file.extname | |
| ); | |
| let origin_path = file.pathname.to_string_lossy().to_string(); | |
| _context.emit_assets(origin_path, final_file_name.clone()); | |
| let mut buffer = Vec::new(); | |
| File::open(&file.path) | |
| .map_err(|e| anyhow::anyhow!("无法打开WASM文件 {}: {}", file.path.display(), e))? | |
| .read_to_end(&mut buffer) | |
| .map_err(|e| anyhow::anyhow!("读取WASM文件失败: {}", e))?; | |
| // Parse wasm file to get imports |
Contributor
Author
|
@sorrycc review |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
crates/mako/src/plugins/wasm_runtime.rs (1)
75-98: 优化字符串构建效率当前代码中的字符串拼接可以通过使用
String的预分配来优化性能。建议：- let mut js_imports_str = String::new(); + let mut js_imports_str = String::with_capacity(import_objs_map.len() * 50); - let mut import_objs_str = String::new(); + let mut import_objs_str = String::with_capacity(import_objs_map.len() * 100);另外，考虑使用
join来替代多次push_str：let js_imports_str = import_objs_map .iter() .enumerate() .map(|(index, (key, _))| { format!( "import * as module{} from \"{}\";\n", index, key ) }) .collect::<String>();
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
crates/mako/src/plugins/wasm_runtime.rs(2 hunks)
🔇 Additional comments (3)
crates/mako/src/plugins/wasm_runtime.rs (3)
1-11: 导入声明看起来不错！
导入的模块和类型都是必要的，并且组织得当。
41-54: 改进文件操作的错误处理和内存管理
当前的文件操作缺少详细的错误处理，且对大文件的处理可能存在内存问题。建议：
- File::open(&file.path)?.read_to_end(&mut buffer)?;
+ File::open(&file.path)
+ .map_err(|e| anyhow::anyhow!("无法打开WASM文件 {}: {}", file.path.display(), e))?
+ .read_to_end(&mut buffer)
+ .map_err(|e| anyhow::anyhow!("读取WASM文件失败: {}", e))?;101-102: 修正函数名拼写错误
_interopreRequireWasm 应该修改为 _interopRequireWasm。
Comment on lines
55
to
73
| let mut import_objs_map: HashMap<&str, Vec<String>> = HashMap::new(); | ||
| for payload in Parser::new(0).parse_all(&buffer) { | ||
| if let Ok(Payload::ImportSection(imports)) = payload { | ||
| for import in imports { | ||
| if let Ok(Import { | ||
| module, | ||
| name, | ||
| ty: _, | ||
| }) = import | ||
| { | ||
| if let Some(import_obj) = import_objs_map.get_mut(module) { | ||
| import_obj.push(name.to_string()); | ||
| } else { | ||
| import_objs_map.insert(module, vec![name.to_string()]); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
优化WASM导入解析的错误处理
当前代码在处理导入时的错误处理可以更加完善。建议：
- if let Ok(Import { module, name, ty: _ }) = import
+ match import {
+ Ok(Import { module, name, ty: _ }) => {
+ if let Some(import_obj) = import_objs_map.get_mut(module) {
+ import_obj.push(name.to_string());
+ } else {
+ import_objs_map.insert(module, vec![name.to_string()]);
+ }
+ },
+ Err(e) => log::warn!("解析WASM导入时出错: {}", e)
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| let mut import_objs_map: HashMap<&str, Vec<String>> = HashMap::new(); | |
| for payload in Parser::new(0).parse_all(&buffer) { | |
| if let Ok(Payload::ImportSection(imports)) = payload { | |
| for import in imports { | |
| if let Ok(Import { | |
| module, | |
| name, | |
| ty: _, | |
| }) = import | |
| { | |
| if let Some(import_obj) = import_objs_map.get_mut(module) { | |
| import_obj.push(name.to_string()); | |
| } else { | |
| import_objs_map.insert(module, vec![name.to_string()]); | |
| } | |
| } | |
| } | |
| } | |
| } | |
| let mut import_objs_map: HashMap<&str, Vec<String>> = HashMap::new(); | |
| for payload in Parser::new(0).parse_all(&buffer) { | |
| if let Ok(Payload::ImportSection(imports)) = payload { | |
| for import in imports { | |
| match import { | |
| Ok(Import { module, name, ty: _ }) => { | |
| if let Some(import_obj) = import_objs_map.get_mut(module) { | |
| import_obj.push(name.to_string()); | |
| } else { | |
| import_objs_map.insert(module, vec![name.to_string()]); | |
| } | |
| }, | |
| Err(e) => log::warn!("解析WASM导入时出错: {}", e) | |
| } | |
| } | |
| } | |
| } |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
crates/mako/src/plugins/wasm_runtime.rs (2)
80-96: 建议优化字符串构建逻辑当前的字符串构建方式使用了多个
push_str和format!调用，可以考虑使用更高效的方式。建议使用
itertools来优化代码：+ use itertools::Itertools; - for (index, (key, value)) in wasm_import_object_map.iter().enumerate() { - module_import_code.push_str(&format!(/*...*/)); - wasm_import_object_code.push_str(&format!(/*...*/)); - } + let (module_imports, object_entries): (Vec<_>, Vec<_>) = wasm_import_object_map + .iter() + .enumerate() + .map(|(idx, (key, value))| ( + format!("import * as module{} from \"{}\";", idx, key), + format!("\"{}\": {{ {} }}", + key, + value.iter() + .map(|name| format!("\"{0}\": module{1}[\"{0}\"]", name, idx)) + .join(", ") + ) + )) + .unzip(); + + let module_import_code = module_imports.join("\n"); + let wasm_import_object_code = object_entries.join(", ");
57-75: 建议添加导入数量限制当前实现没有限制单个WASM模块可以导入的函数数量，这可能导致内存问题。
建议添加合理的限制：
+ const MAX_IMPORTS_PER_MODULE: usize = 1000; let mut wasm_import_object_map: HashMap<&str, Vec<String>> = HashMap::new(); + let mut total_imports = 0; for payload in Parser::new(0).parse_all(&buffer) { if let Ok(Payload::ImportSection(imports)) = payload { + if total_imports >= MAX_IMPORTS_PER_MODULE { + return Err(anyhow::anyhow!("导入数量超过限制")); + } for import in imports { + total_imports += 1;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
crates/mako/src/plugins/wasm_runtime.rs(2 hunks)
🔇 Additional comments (3)
crates/mako/src/plugins/wasm_runtime.rs (3)
1-11: 导入声明看起来不错！
所选用的依赖项都是合适的，特别是wasmparsercrate对于解析WebAssembly文件是一个很好的选择。
54-56: 建议改进错误处理
当前的错误处理过于简单，缺少具体的上下文信息，这可能会增加调试难度。
建议修改为：
- File::open(&file.path)?.read_to_end(&mut buffer)?;
+ File::open(&file.path)
+ .map_err(|e| anyhow::anyhow!("无法打开WASM文件 {}: {}", file.path.display(), e))?
+ .read_to_end(&mut buffer)
+ .map_err(|e| anyhow::anyhow!("读取WASM文件失败: {}", e))?;103-110: 函数名称拼写错误
_interopreRequireWasm 应该是 _interopRequireWasm。
建议修改：
- "module.exports = require._interopreRequireWasm(exports, \"{}\")"
+ "module.exports = require._interopRequireWasm(exports, \"{}\")"
Comment on lines
61
to
72
| if let Ok(Import { | ||
| module, | ||
| name, | ||
| ty: _, | ||
| }) = import | ||
| { | ||
| if let Some(import_object) = wasm_import_object_map.get_mut(module) { | ||
| import_object.push(name.to_string()); | ||
| } else { | ||
| wasm_import_object_map.insert(module, vec![name.to_string()]); | ||
| } | ||
| } |
There was a problem hiding this comment.
建议添加导入名称的安全验证
当前代码直接使用了WASM模块中的导入名称，但没有进行任何验证，这可能存在安全风险。
建议添加名称验证：
+ fn is_valid_import_name(name: &str) -> bool {
+ // 只允许字母、数字、下划线和美元符号
+ name.chars().all(|c| c.is_alphanumeric() || c == '_' || c == '$')
+ }
if let Ok(Import { module, name, ty: _ }) = import {
+ if !is_valid_import_name(name) {
+ log::warn!("跳过不安全的导入名称: {}", name);
+ continue;
+ }
if let Some(import_object) = wasm_import_object_map.get_mut(module) {Committable suggestion skipped: line range outside the PR's diff.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1705 +/- ##
==========================================
+ Coverage 54.81% 55.03% +0.22%
==========================================
Files 180 180
Lines 18081 18146 +65
==========================================
+ Hits 9911 9987 +76
+ Misses 8170 8159 -11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
crates/mako/src/plugins/wasm_runtime.rs (2)
134-151: 改进测试用例的健壮性当前的测试用例存在以下问题：
- 使用了硬编码的文件路径
- 缺少错误情况的测试
- 对生成内容的验证不够完整
建议添加以下测试场景：
- 使用测试资源目录和环境变量来管理测试文件
- 添加对无效WASM文件的测试
- 添加对生成的JavaScript代码结构的详细验证
示例改进：
#[test] fn test_wasm_runtime_load_invalid_wasm() { let plugin = WasmRuntimePlugin {}; let context = Arc::new(Context::default()); let temp_dir = tempfile::tempdir().unwrap(); let invalid_wasm_path = temp_dir.path().join("invalid.wasm"); std::fs::write(&invalid_wasm_path, b"invalid wasm content").unwrap(); let file = File::new(invalid_wasm_path.to_string_lossy().to_string(), context.clone()); let param = PluginLoadParam { file: &file }; let result = plugin.load(¶m, &context); assert!(result.is_err()); }
35-124: 考虑重构为更模块化的结构当前的实现将所有逻辑都放在了
load方法中，建议将功能拆分为更小的模块：
- WASM文件处理
- 导入对象解析
- JavaScript代码生成
建议创建以下模块结构：
mod wasm { pub struct WasmFile { buffer: Vec<u8>, imports: HashMap<String, Vec<String>>, } impl WasmFile { pub fn load(path: &Path) -> Result<Self>; pub fn parse_imports(&mut self) -> Result<()>; } } mod js { pub struct CodeGenerator { imports: HashMap<String, Vec<String>>, } impl CodeGenerator { pub fn generate_module_imports(&self) -> String; pub fn generate_export_statement(&self, filename: &str) -> String; } }这样的结构将：
- 提高代码的可维护性
- 便于单元测试
- 使功能边界更清晰
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
crates/mako/src/plugins/wasm_runtime.rs(2 hunks)
🔇 Additional comments (3)
crates/mako/src/plugins/wasm_runtime.rs (3)
106-107:
修复函数名拼写错误
函数名_interopreRequireWasm存在拼写错误，应为_interopRequireWasm。
建议修改如下：
- "module.exports = require._interopreRequireWasm(exports, \"{}\")",
+ "module.exports = require._interopRequireWasm(exports, \"{}\")",54-55: 🛠️ Refactor suggestion
改进文件读取的错误处理和内存管理
当前的文件读取实现存在以下问题：
- 错误处理不够详细，无法快速定位问题
- 对大型WASM文件可能会造成内存压力
建议修改如下：
- let mut buffer = Vec::new();
- File::open(&file.path)?.read_to_end(&mut buffer)?;
+ let mut buffer = Vec::with_capacity(1024 * 1024); // 预分配1MB
+ File::open(&file.path)
+ .map_err(|e| anyhow::anyhow!("无法打开WASM文件 {}: {}", file.path.display(), e))?
+ .take(10 * 1024 * 1024) // 限制最大读取10MB
+ .read_to_end(&mut buffer)
+ .map_err(|e| anyhow::anyhow!("读取WASM文件失败: {}", e))?;Likely invalid or redundant comment.
58-78: 🛠️ Refactor suggestion
优化WASM导入解析的错误处理和日志记录
当前的导入解析缺少适当的错误处理和日志记录，这可能会导致调试困难。
建议修改如下：
Parser::new(0).parse_all(&buffer).for_each(|payload| {
- if let Ok(Payload::ImportSection(imports)) = payload {
+ match payload {
+ Ok(Payload::ImportSection(imports)) => {
imports.into_iter_with_offsets().for_each(|import| {
- if let Ok((
- _,
- Import {
- module,
- name,
- ty: _,
- },
- )) = import
- {
+ match import {
+ Ok((_, Import { module, name, ty })) => {
+ log::debug!("处理WASM导入: module={}, name={}", module, name);
if let Some(import_object) = wasm_import_object_map.get_mut(module) {
import_object.push(name.to_string());
} else {
wasm_import_object_map.insert(module, vec![name.to_string()]);
}
+ }
+ Err(e) => log::warn!("解析WASM导入时出错: {}", e)
}
});
+ }
+ Ok(_) => (),
+ Err(e) => log::error!("解析WASM文件时出错: {}", e)
}
});Likely invalid or redundant comment.
Contributor
|
rust wasm 里 import js 文件能 work 么 ？ |
Contributor
Author
可以，example补上了 |
xusd320
approved these changes
Jan 18, 2025
elrrrrrrr
pushed a commit
that referenced
this pull request
Jul 9, 2025
* fix: env_replacer should not replace user defined variable in scope (#1577) * fix: env_replacer should not replace user defined variable in scope * test: add test cases for env_replacer * chore: code style * release: @umijs/mako@0.8.11 * chore: bundler-mako@0.8.11 * docs: add changelog for v0.8.11 * fix(tree-shaking): detect export var side effects (#1579) * test: ✅ add a failure test * fix: 🐛 add is pure detection in export var decl * fix: bad output when chunk_loading_global containing quotation mark (#1582) * chore: ➕ add a subdot cli tool script (#1585) * fix(win): copy don't work under windows (#1587) * fix(win): module id should be win_pathed (#1588) * feat(tree-shaking): optimize import namespace used all exports to partial used of source modules (#1584) * test: ✅ add failure test case * feat: ✨ add collect prop explicit field * feat: ✨ collect explicit member prop access to optizmize used export in dep module replace USE ALL export to partial used exports * fix: dedestructuring before collect ExplicitProps * test: ✅ add back trace env var * test: ✅ update test case * fix: 🐛 add globals and helpers --------- Co-authored-by: Jinbao1001 <nodewebli@gmail.com> * fix: merge mako config (#1578) * fix: merge mako config * fix: merge mako config * fix:clear deps should not panic when module not found (#1581) * fix:clear deps should not panic when module not found * chore: use tracing warn * fix: delete log * Revert "fix: merge mako config (#1578)" (#1589) This reverts commit c08821d. * fix: watch too many file error (#1550) * fix: watch too many file error * chore: delete print * chore: delete log * release: @umijs/mako@0.8.8-rc.1 * fix: conflict * feat: support numeric module Id (#1561) * feat: moduleIdStrategy support numberous * fix: typos * fix: typos * fix: change name * fix: typos * release: @umijs/mako@0.8.12 * chore: fix typo and doc (#1591) * fix: chunk_loading_global (#1590) * fix: bad entry output when chunk_loading_global containing singe quote * test: add test cases for chunk_loading_global * docs: update * chore: update lock * chore: remove useless dependencies (#1595) * refactor: 🔥 rm ci warn logs (#1596) * fix: devServer put static serve proxy after umi proxy middleware (#1558) * fix: fix umi load html file failed, * test: add umi devServer test case * fix: typo * fix: hmr on hyper-static-file error * fix: import expect.mjs error on github workflow. * fix: import expect.mjs error on github workflow. * fix: 🐛 expect for error case * fix: 🐛 dev.hmr dont stop * fix: 🐛 add OKAM env * fix: 🐛 wait for mako server * fix: 🐛 kill by children process * test: ✅ add umi.css * refactor: 🎨 unify expect file * feat: export killMakoDevServer from test-hmr.mjs, make it public for all test case * test: ✅ unify expect file * chore: ➕ use express-http-proxy for static proxy * feat: ✨ better mako static proxy * test: ✅ support umi dev test with local mako * chore: ⬆️ update pnpm-lock * chore: 🎨 * fix: 🐛 ignore children process killed error --------- Co-authored-by: huanyu.why <huanyu.why@antgroup.com> Co-authored-by: pshu <pishu.spf@antfin.com> * fix(tree-shaking): object spread transform should go before deconstructing (#1598) * fix: 🐛 deconstructing needs object spread transform first * test: ✅ add guardian syntax * release: @umijs/mako@0.8.13-canary.20240918.1 * chore: bundler-mako@0.8.13-canary.20240918.1 * chore: 🎨 thread name after mako (#1601) * refactor: 🎨 rayon is not friendly to js users * chore: ✏️ rename tokio worker with mako * revert: import namespace optimize (#1606) * Revert "fix(tree-shaking): object spread transform should go before deconstructing (#1598)" This reverts commit 9434d99. * Revert "feat(tree-shaking): optimize import namespace used all exports to partial used of source modules (#1584)" This reverts commit 81a52f8. * chore: 🔧 update mako clean script * release: @umijs/mako@0.8.13 * chore: bundler-mako@0.8.13 * docs: change log 0923 (#1607) * docs: 📝 change log * docs: 📝 change log 0923 * chore: ✏️ * fix: 🐛 turn off express-http-proxy's keep alive (#1612) * fix: 🐛 turn off express-http-proxy's keep alive * refactor: 🔥 remove timeout config * release: @umijs/mako@0.8.14 * chore: bundler-mako@0.8.14 * refactor: napi threadsafe function (#1608) * refactor: napi threadsafe function * chore: update binding typings * refactor: code pieces * fix: catch napi tsfn promise rejection * chore: update binding typings * docs: 📝 change log 20240925 (#1613) * feat: disable webp to base64 (#1602) * feat: init * fix: context * fix: no use * fix: typos * fix: typos * fix: typos * fix: typos * fix(bundler-mako): experimental config should be merged deeply (#1617) * refactor: config codes organization (#1618) * refactor: config codes organization * fix: typos * refactor: config parse error * fix: clickToComponent don't work (#1620) * fix: duplicate_package_checker panic when no package.json is supplied (#1621) * fix: file_stem index out of bound (#1623) * feat: add resolve_id plugin hook (#1625) * feat: add resolve_id plugin hook * chore: update docs * feat: add external * release: @umijs/mako@0.8.15 * chore: bundler-mako@0.8.15 * docs: changelog for 0.8.15 * chore: update the release instruction (#1627) * refactor: code-splitting config (#1629) * feat: add loadInclude plugin hook (#1630) * feat: add { isEntry } for resolve_id plugin hook (#1631) * feat/upgrade swc (#1444) * 🚧 * 🚧 a basic working version * chore: 🚨 lint happy * refactor: 🎨 adjust to new swc * refactor: 🎨 remove deprecated methods * chore: 🚨 lint happy * feat: ✨ update swc emotion * chore: 🔧 remove useless profile in sub crate * chore: 🔧 add back emotion plugin * refactor: 🎨 add back merge source map * test: ✅ hot update js file served by hyper static, it use text/javascript * chore: 🔧 lock update * chore: 🔧 clean up swc core feature * refactor: 🎨 fix breaking change of ctxt of span * fix: 🐛 ctxt apply mark * refactor: 🎨 use DUMMY CTXT instead of SyntaxContext::empty() * chore: ⬆️ temperal use mdxjs from kdy branch * feat: ✨ re-enable mdxjs * feat: ✨ swc_core 0.100.1 * chore: 🙈 ignore fmt in fixtures * chore: 🚨 lint happy * chore: ⬆️ swc_common * chore: ✏️ typo * release: @umijs/mako@0.8.1-canary.20240812.1 * chore: bundler-mako@0.8.1-canary.20240812.1 * chore: ⬆️ swc_core 0.100.6 * release: @umijs/mako@0.8.1-canary.20240814.2 * chore: bundler-mako@0.8.1-canary.20240814.2 * chore: 🚨 lint happy * chore: 🔧 CI build bindings * chore: 🔧 fix build docker * refactor: 🔥 remove aarch64-unknown-linux-gnu * chore: 🔧 create tar * chore: 🙈 * release: @umijs/mako@0.8.3-canary.20240820.1 * chore: bundler-mako@0.8.3-canary.20240820.1 * chore: 🔧 wrong donwload param * chore: 🔧 upload download actions should be same version * chore: 🔧 try codecov in ci * refactor: 🔥 remove unnecessary target * refactor: 🎨 use swc comments * fix: 🐛 after upgrade to swc_core it should remove paren before minifiy * refactor: 🎨 move dummy ctxt defintion to ast mod * chore: 🚨 lint happy * release: @umijs/mako@0.8.8-canary.20240902.1 * chore: bundler-mako@0.8.8-canary.20240902.1 * release: @umijs/mako@0.8.8-canary.20240903.3 * chore: bundler-mako@0.8.8-canary.20240903.3 * refactor: 🎨 use VisitMut + Fold code style * chore: ⬆️ update pnpm-lock * chore: 🙈 * revert: ⏪ delete musl bindin * release: @umijs/mako@0.8.9-canary.20240909.1 * chore: bundler-mako@0.8.9-canary.20240909.1 * release: @umijs/mako@0.8.11-canary.20240910.1 * chore: bundler-mako@0.8.11-canary.20240910.1 * fix: 🐛 use chars() instead of bytes() * fix: 🐛 unescape html entity by html escape crate * release: @umijs/mako@0.8.14-canary.20240924.1 * chore: bundler-mako@0.8.14-canary.20240924.1 * release: @umijs/mako@0.8.15-canary.20240927.1 * chore: bundler-mako@0.8.15-canary.20240927.1 * fix: hash not stable (&revert import * as optimize) (#1610) * Revert "revert: import namespace optimize (#1606)" This reverts commit a485358. * fix: hash not stable * fix: deps sort not stable * fix: deps sort not stable * fix: deps sort not stable * fix: delete binding * fix: var name * chore: iter to into * fix: format * release: @umijs/mako@0.9.0 * chore: bundler-mako@0.9.0 * docs: 📝 changelog 0.9.0 * fix: duplicate_package_checker panic when package.json has no version field (#1634) * feat: magic comment chunk name (#1628) * refactor: code-splitting config * feat: support magic comment chunk name basically * fix: magic comment chunk name for webworker * refactor: use ImportOptions to represent option from magic comments * fix: dep replacer when magic comments chunk name existed * test: update test cases for magic comments chunk name * fix: dep replacer when dynamic import depencies is missing * chore: remove useless codes * refactor: code styles * docs: add todo for ChunkId * test: fix visitors::dynamic_import::tests::test_dynamic_import * test: fix test::hmr * fix: dep replacer when dynamic import css modules or moduleIdStrategy is hashed * chore: remove meaning less changes * test: enable magic comment chunk name in fixtures/umi * docs: add docs for magic comment chunk name * feat: support webpackIgnore and makoIgnore magic comment (#1636) * feat: support webpackIgnore and makoIgnore magic comment * chore: fmt * chore: rename magic_comment_chunk_name to magic_comment * chore: fix typo * feat: add transform plugin hook (#1637) * feat: add transform plugin hook * docs: add docs * chore: fmt * chore: perf * feat: add transformInclude plugin hook (#1639) * feat: add transformInclude plugin hook * chore: fmt * Fix: import namespace optimize panic with nested for of stmt (#1640) * test: ✅ add import namespace optimize panic test case * fix: 🐛 fix nested for of stmt panic * release: @umijs/mako@0.9.2-canary.20241016.1 * chore: bundler-mako@0.9.2-canary.20241016.1 * release: @umijs/mako@0.9.2 * chore: bundler-mako@0.9.2 * docs: 📝 changelog 0.9.2 * feat: add buildEnd plugin hook (#1644) * feat: add enforce plugin hook (#1646) * feat: add enforce plugin hook * chore: code style * chore: code style * chore: fix lint * chore: 🎨 add missing binding type * release: @umijs/mako@0.9.3-canary.20241016.1 * chore: bundler-mako@0.9.3-canary.20241016.1 * feat: add writeBundle plugin hook (#1650) * feat: add watch_changes plugin hook (#1651) * feat: add watch_changes plugin hook * chore: fix lint * chore: fix ts define * fix: mako on windows don't work (#1652) * fix: devtool sourcemap explosion in windows (#1653) * chore: remove dead code * fix: should not re-group when span changed (#1654) * fix: umd should be import as cjs (#1642) * fix: umd should be import as cjs * refactor: 🎨 just short circuit typeof define to prevent define takes effect * revert: ⏪ binding.d.ts --------- Co-authored-by: pshu <pishu.spf@antfin.com> * fix: 🐛 add process.env.SOCKET_SERVER define to prevent process polyfilll (#1655) * release: @umijs/mako@0.9.3-canary.20241023.1 * chore: bundler-mako@0.9.3-canary.20241023.1 * release: @umijs/mako@0.9.3 * chore: bundler-mako@0.9.3 * docs: changelog for 0.9.3 * fix: hmr with magic comment chunk name (#1663) * feat: enable magicComment features by default (#1667) * feat(bundler-mako): add moduleIdStrategy to supportMakoConfigKeys (#1664) * fix: async module in circular dependence (#1659) * test: ✅ add test async module in circular dependencies * refactor: 🎨 handle async polution by traversal * refactor: 🎨 use default over expect * feat: compatible codeSplitting config with umi (#1669) * feat: compatible codeSplitting config with umi * test: fix e2e code-splitting.granular * fix: umi codeSplitting: depPerChunk * Feat/benchmark workflows (#1671) * feat: benchmark-workflows * fix: 修改Github Secrets * release: @umijs/mako@0.9.4 * chore: bundler-mako@0.9.4 * docs: 📝 changelog 0.9.4 * chore: Optional parameters (#1679) * chore: Optional parameters * Update index.ts * fix: skip module should skip async module (#1662) * release: @umijs/mako@0.9.5 * chore: bundler-mako@0.9.5 * docs: update changelog * docs: update changelog * feat(ssu): handle dependence changing while watching (#1690) * refactor: 🎨 add after update aspect for rebuild cached modules * refactor: 🎨 add next_build aspect in build_my_modify * feat: ✨ 区分 ssu firstbuild 和 updating 两者状态 * fix: pnpm workspace watch too many files (#1684) * fix: ✅ ts annotated declare variable treat as top level variable (#1682) * test: ✅ add ts declare annotated variable as top level * refactor: 🎨 mv clean syntax context to visitors folder * fix: 🐛 strip ts/tsx first, then do normal transform * feat: move ensure runtime to entry (#1660) * feat: ✨ add ensure2 replace in dynamic replace * feat: ✨ ensure 2 runtime * feat: ✨ add experimental centralEnsure config * refactor: 🎨 add struct ReslvedReplaceInfo * feat: ✨ add central ensure plugin * refactor: 🎨 extract module ensure map * refactor: 🎨 add back chunk id in replace info * refactor: 🎨 fix case one source with different import type * refactor: 🎨 extract hmr runtime update code aspect * release: @umijs/mako@0.9.6-canary.20241107.1 * chore: bundler-mako@0.9.6-canary.20241107.1 * feat: keep unresolved nodejs require (#1689) * fix: regexpr for nodejs intenal modules igonre * feat: not replace unresolved nodejs require to __mako_require__ * fix: define util require should be __mako_require__ * feat: add expreriental.keep_unresolved_node_require * feat: add expreriental.ignore_non_literal_require * chore: 🔥 remove unused fn * release: @umijs/mako@0.9.6 * chore: bundler-mako@0.9.6 * docs: changelog for 0.9.6 * fix(SSU): 🐛 in case external not avaible to all entries (#1698) * fix(SSU): 🐛 in case external not avaible to all entries * refactor: 🎨 explict ignore the error * fix: devserver response header add cacheControl no-cache (#1692) * fix: add no-cache * feat: add cross origin * fix: resonse header add cors and no_cache for all branch (#1699) * fix: judge devServer instead of writeToDisk * fix: add branch header * refactor: 🎨 static file with 0 ages --------- Co-authored-by: pshu <pishu.spf@antfin.com> * release: @umijs/mako@0.9.7 * chore: bundler-mako@0.9.7 * docs: 📝 update changelog for 0.9.7 * chore: ✏️ remove some if (#1706) * fix: optimization.concatenateModules dts lost (#1708) * refactor: 🔥 enter ensure 使用 chunk sync dep 减少首屏 chunk 数量 (#1707) * fix: 🐛 typing of stats (#1712) * fix: 🐛 detect circular deps output file content (#1715) * chore: update @umijs/mako typings * feat: ensure esm imports exists when mode is production (#1709) * feat: ensure esm imports exists when mode is production * release: @umijs/mako@0.9.8 * chore: bundler-mako@0.9.8 * docs: update docs * fix: node ignores (#1716) * feat: supports publicPath: auto (#1717) * feat: auto resolve entry file extension (#1718) * feat: auto resolve entry file extension * fix: remove useless clone * Fix/context module source with first empty quasis (#1719) * test: ✅ add first empty quasis template string module source case * fix: 🐛 first emtpy quasis case * fix: inline css config deserialize (#1720) * fix: node ignore should support node: prefixed only built-in modules (#1721) * release: @umijs/mako@0.9.9 * docs: suggest using volta to manage node and pnpm's version * chore: bundler-mako@0.9.9 * docs: update CHANGELOG.md * feat: supports umd export (#1723) * feat: supports umd export * fix: umd config binding typing * fix: typos * fix: umd export * chore: update typings * fix: replace the "typeof __webpack_require__" content (#1688) * fix: replace the "typeof __webpack_require__" content * fix: add some other webpack string name * fix: 增加对typeof 表达式的处理 * fix: delete log * fix: rename --------- Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> * fix: umd config deserialization (#1726) * feat: support case sensitive (#1714) * feat: add CaseSensitivePlugin * FIX: update path check * fix: clippy error * fix: 调整判断 * fix: 修复目录读取 * fix: 修改参数名称 * fix: 调整测试方式添加e2e断言，并增加配置项只有mac系统下才需要开启相关配置 * fix: 删除过滤条件 * fix: 删除多余测试文件，增加更新内容 * fix: 删除多余log * fix: 测试执行 * fix: 添加测试系统 * fix: 调整顺序 * fix: 添加测试系统 * fix: 非mac环境断言 * fix: 引用遗漏 * fix: 断言 * fix: 删除默认 * fix: 默认配置 * fix: 测试覆盖 * Revert "fix: 测试覆盖" This reverts commit b0a2e66. --------- Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> * refactor: 🔥 remove unecessary transform (#1727) * feat: output filename (#1725) * refactor: 🎨 add file name template and chunk name in ChunkFile struct * feat: ✨ add config to output#filename * feat: ✨ render filename when output#filename configed * feat: ✨ calc hash in ast impl for entry * test: ✅ add test case * test: ✅ add ut * chore: 🔧 disable codecov error * refactor: 🎨 remove clone * fix: 🐛 hash when necessary * chore: 🔧 add codecov.yml * release: @umijs/mako@0.9.10-canary.20241218.1 * chore: ⬆️ update pnpm-lock * feat: native plugin init (#1691) * feat: init rust plugin * chore: delete print * Rename cargo.toml to Cargo.toml * chore: update * fix: type * fix: plugin options string * fix: cfg test * release: @umijs/mako@0.10.0 * chore: bundler-mako@0.10.0 * docs: 📝 changelog 2024.12.20 * chore: 🔧 for quick setup dep to debug (#1733) * fix: support optional chaining in environment variable (#1730) * fix: support optional chaining in environment variable * test(): add edge cases for optional chaining in env_replacer * refactor: 🎨 no need to resolve empty url in css (#1732) * refactor: 🎨 no need to resolve empty url in css * refactor: 🎨 add test case * feat: support unplugin context (#1728) * feat: support plugin context * fix: napi context * chore: revert changes * chore: improve * feat: add error * feat: warn and error support object * feat: support emit_file * ci: fix test * chore: improve * chore: update test * chore: format * chore: don't support add watch file * feat: load and transform adapter, and add unplugin-replace example * chore: test unplugin-icons * chore: update pnpm-lock.yaml * docs: improve --------- Co-authored-by: xusd320 <xusd320@gmail.com> * fix: legacy octal escape is not permitted in strict mode (#1736) * fix: legacy octal escape is not permitted in strict mode * fix: e2e inline css * release: @umijs/mako@0.11.0 * chore: bundler-mako@0.11.0 * fix: pnpm lock * docs: 📝 changelog 2024.12.26 * Revert "feat: support unplugin context (#1728)" (#1737) This reverts commit 3dd6d9d. * release: @umijs/mako@0.11.1 * chore: bundler-mako@0.11.1 * feat: support unplugin context (#1741) * feat: support plugin context * fix: napi context * chore: revert changes * chore: improve * feat: add error * feat: warn and error support object * feat: support emit_file * ci: fix test * chore: improve * chore: update test * chore: format * chore: don't support add watch file * feat: load and transform adapter, and add unplugin-replace example * chore: test unplugin-icons * chore: update pnpm-lock.yaml * docs: improve --------- Co-authored-by: xusd320 <xusd320@gmail.com> * fix: #1007 (#1738) support BinaryExpression Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> * fix: win path problem with context module and require context (#1742) * chore(mako): add debug notice for local builds (#1743) * fix: normalize Windows paths in ModuleId constructors (#1744) * fix: normalize Windows paths in Compiler output path handling (#1745) * fix: typos * release: @umijs/mako@0.11.2 * chore: bundler-mako@0.11.2 * docs: update CHANGELOG.md * feat(create-mako): refactor create-mako (#1751) * chore: add issue and pull request templates for better contribution guidelines (#1753) * fix: ensure parent directories are created when writing to disk in MemoryChunkFileCache (#1755) * chore: release @umijs/tools * release: @umijs/mako@0.11.3 * chore: update the release introduction * ci: fix ci (#1758) * chore: upgrade @umijs/tools and do github release and changelog generate and translation by script * docs: changelog for 0.11.3 * chore: add check-ecosystem-usages script (#1759) * fix: analyze don't work in safari (#1761) * fix(mako): cli delay exit (#1762) * dep: @umijs/tools@0.1.23 * fix: load wasm (#1705) * fix: 修复load .wasm文件对importObject的处理 * fix: 删除没必要的输出 * fix: 修改生成的成员表达式js代码 * fix: 变量重命名 * fix: 修复代码lint报错 * test: 补充wasm_runtime测试用例 * chore: 补充import js方式的示例 * chore: 修改import js示例wasm产物格式 * chore: wasmparser依赖包在配置文件的位置 * chore: 删除多余的.wasm load逻辑 --------- Co-authored-by: xusd320 <xusd320@gmail.com> * fix: chunk groups' order when building mpa (#1763) * feat(copy): support advanced copy configuration with custom target paths (#1711) * feat(copy): support advanced copy configuration with custom target paths - Add CopyConfig enum to support both basic and advanced copy modes - Basic mode: maintains backward compatibility with string[] format - Advanced mode: supports {from: string, to: string} format for custom paths - Update copy plugin to handle both configuration formats - Ensure target directories are created automatically Example config: { 'copy': [ 'public', // basic mode { 'from': 'assets', 'to': 'static' } // advanced mode ] } * fix(copy): prevent path traversal in copy plugin Add path canonicalization and validation to ensure target paths remain within the destination directory * chore: Update `copy` config type in Mako bundler - Updated the type of the `copy` property in the `BuildParams` interface to support both `string` and `{ from: string; to: string }`. - Ensured the `copy` configuration is properly validated to handle both types. * docs: Update `copy` config type in documentation - Updated the `copy` property type in the configuration documentation to reflect the change from `string[]` to `(string | { from: string; to: string })[]`. - Clarified that the `copy` configuration can now accept both strings and objects with `from` and `to` properties. * test(copy): add e2e tests for copy plugin from/to pattern - Update config.copy test fixtures to cover from/to pattern - Add assertions for copied files in new location - Adjust copy plugin path validation * fix(copy): improve path validation and cleanup for copy plugin - Add directory cleanup when path validation fails - Use canonicalized paths for more reliable path validation - Add concatenateModules option type to BuildParams * fix: ci (#1768) * release: @umijs/mako@0.11.4 * chore: bump version * docs: 📝 changelog 2025.02.12 * chore: update changelog 2025.02.12 * fix: plugin context gc (#1769) * fix: mako已经支持了scss 但是没有支持module.scss文件 (#1770) Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> * feat: add module federation plugin (#1764) * feat: support module federation * feat: mf exposes to remote entries * chore: code styles * feat: mf container entry impl * fix: mf container entry * fix: mf runtime initOptions * feat: add containter references * feat: impl mf remote * feat: improve mf exposes * fix: mf exposes runtime factory * fix: mf plugin execution order * chore: update mf demo * feat: generate mf manifest in rust * fix: remote stats.json * refactor: code styles * chore: add some FIXME * refactor: mf plugin mods files * refactor: mf plugin mods files * chore: remove dead code * --wip-- [skip ci] * fix: remote stats.json * fix: typos * chore: simpify mf runtime codes fmt * refactor: mf containter plugin * feat: mf shared workaround * feat: mf shared workaround * fix: runtime template and remove some useless codes * fix: mf dev server * fix: mf shared config * feat: supports chunk group exclude * feat: mf patch code splitting * feat: mf shared manifest * feat: add config hash for mf shared module * chore: update mako typings * chore: code styles * chore: fix typo * chore: code styles * perf: improve performance * chore: code styles * chore: rename types * feat: add options to disable mf manifest * feat: entry config should be defined as BTreeMap * fix: mf shared consume and supports eager config * fix: mf shared eager * fix: not generate chunk for mf remote module * fix: typos * feat: add entry filename supports * chore: remove meaning less changes * fix: entry filename and mf config * release: @umijs/mako@0.11.4-canary.20250206.0 * fix: ignore shared dep when it is been external * Revert "release: @umijs/mako@0.11.4-canary.20250206.0" This reverts commit d3105d9. * release: @umijs/mako@0.11.4-canary.20250207.0 * fix: skip serialize mf manifest remoteEntry if none * fix: mf manifest remoteEntry address * Revert "release: @umijs/mako@0.11.4-canary.20250207.0" This reverts commit 6179982. * fix: typo * fix: mako mf manifest publicPath * fix: mf manifest panic * fix: mf typings * test: add e2e test for mf * fix: typo * chore: update README * fix: update mf bingding typings * fix: typings * fix: should not generate mf remotes runtime when remotes is empty * chore: remote wrong comment * feat: add chunk matcher for mf * fix: mf binding typings * chore: remove debug print statements * docs: update moduleFederation configuration docs * fix: mf config docs * chore: update CONTRIBUTING.md * release: @umijs/mako@0.11.5 * chore: update CHANGELOG.md and versions * feat: support to disable camel2DashComponentName of transformImport (#1773) * feat: support to disable camel2DashComponentName of transformImport * fix: typings * fix: 修复sass/less-loader的路径解析 (#1771) * fix: 支持webpack中sass-loader的路径解析 * chore: 调整目录 * chore: 移除注释等 * chore: 引入loader-runner * chore: sass-loader * chore: 修改loader返回空值处理 * test: 设置loader resolver的别名 * chore: update lock * fix: loader options * refactor: 提取插件代码 * fix: getResolve * fix: 修复runLoaders中的错误处理逻辑 * release: @umijs/mako@0.11.6 * fix: pnpm-lock * chore: update changelog for v0.11.6 * chore: update changelog for v0.11.6 * chore: update changelog for v0.11.6 * fix: watch less and sass dependencies (#1779) * chore: stash * chore: stash * feat: LessModuleGraph * feat: less-import-plugin * chore: 删除多余代码 * fix: 兼容url() * chore: plugin * feat: add beforeRebuild hook * ci: clippy format * fix: paths去重 * fix: rename _path * chore: rust层增加临时过滤文件方式 * chore: 提取createParallelLoader * refactor: before_rebuild hook (#1785) * refactor: before_rebuild hook -n * fix: typos * feat: postcss-loader (#1787) * feat: 支持postcss-loader * chore: 合并postcss到options传给render * chore: 更新.gitignore以排除less.postcss的node_modules目录 * feat: 添加PostCSS插件支持并更新相关类型定义 * refactor: 简化Less和Sass插件中的选项传递 * docs: 添加postcss支持的配置说明 * feat: 添加对PostCSS的支持，更新相关插件以集成postLoaders * feat: 更新Less和Sass插件以移除postLoaders，增强PostCSS支持 * test: 补充postcss测试用例 * fix: use transpiled hmr runtime (#1813) * fix: use transpiled hmr runtime (#1814) * release: @umijs/mako@0.11.7 * fix: package-lock.json * fix: use transpiled hmr runtime entry (#1815) * fix: disable parallel sassLoader because sassOptions.function cann't be shared cross workers (#1816) * release: @umijs/mako@0.11.8 * fix: package-lock.json * fix: package-lock.json * fix: typos * chore: update changelog for v0.11.8 * fix: less,sass,postcss loader panic (#1818) * release: @umijs/mako@0.11.9 * fix: package-lock.json * chore: update changelog for v0.11.9 * fix: worker threads panic on linux (#1823) * release: @umijs/mako@0.11.10 * fix: package-lock.json * chore: update changelog for v0.11.10 * fix: dev支持inline-source-map (#1859) Co-authored-by: dongqing.mdq <dongqing.mdq@antgroup.com> * release: @umijs/mako@0.11.11 * fix: package-lock.json * chore: update changelog for v0.11.11 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * fix: less resolve alias (#1906) * docs: update README.md (#1907) * Update README.md * Apply suggestions from code review Co-authored-by: Peach <scdzwyxst@gmail.com> * Update README.md * Update README.md --------- Co-authored-by: Peach <scdzwyxst@gmail.com> * Update README.md * Update README.md * release: @umijs/mako@0.11.12 * feat: update pnpm log * chore: update changelog for v0.11.12 * fix: panic on docker linux (#1909) * doc: add openomy (#1910) * release: @umijs/mako@0.11.13 * chore: update changelog for v0.11.13 * chore: remove codecov * chore: update examples/multiple-entries-heavy * feat: support inline-source-map devtool option (#1965) Co-authored-by: hanzebang.hzb <hanzebang.hzb@antgroup.com> * chore: truncate old codes --------- Co-authored-by: pshu <pishu.spf@antfin.com> Co-authored-by: chencheng (云谦) <sorrycc@gmail.com> Co-authored-by: Jinbao1001 <nodewebli@gmail.com> Co-authored-by: money <hualigushi@163.com> Co-authored-by: eisonhower <why490078184@gmail.com> Co-authored-by: huanyu.why <huanyu.why@antgroup.com> Co-authored-by: PeachScript <scdzwyxst@gmail.com> Co-authored-by: Wu-kung <1434246346@qq.com> Co-authored-by: 聪小陈 <xiaohuoni@users.noreply.github.com> Co-authored-by: akitaSummer <akitasummer@outlook.com> Co-authored-by: Shi Kuan <shikuan1992@gmail.com> Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> Co-authored-by: yezao <75713784+yezaoshu@users.noreply.github.com> Co-authored-by: 御风 <18012261618@126.com> Co-authored-by: bqxbqx <132878537+BQXBQX@users.noreply.github.com> Co-authored-by: miaodongqing <dongqing_miao@163.com> Co-authored-by: dongqing.mdq <dongqing.mdq@antgroup.com> Co-authored-by: kiner-tang（星河） <1127031143@qq.com> Co-authored-by: hanzebang <46307343+hanzebang@users.noreply.github.com> Co-authored-by: hanzebang.hzb <hanzebang.hzb@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1422
Summary by CodeRabbit
load方法，增强了WasmRuntimePlugin的功能，支持动态解析和生成 JavaScript 导入语句。greet和greet2函数，提供额外的功能接口。minus函数，支持两个数字的减法运算。wasmparser。