fix: hash not stable (&revert import * as optimize) #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a485358.
Walkthrough此次更改涉及多个文件的更新，主要集中在 CI 工作流的环境变量设置、模块图中依赖管理的优化、新增树摇插件功能、以及显式属性访问收集器的实现。此外，还引入了新的测试文件和配置文件，以支持模块优化和验证功能。整体上，这些更改旨在提升代码的可维护性和测试能力。 Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Outside diff range and nitpick comments (7)
e2e/fixtures/tree-shaking.import_namespace/src/mod.js (1)
5-7: 函数实现正确，但可以优化表达。
shouldKeep2函数实现了输入值的加倍操作。函数名同样暗示在树摇过程中应该保留此函数。建议将实现改为更直观的乘法操作：
export function shouldKeep2(x) { - return x + x; + return 2 * x; }这样可以更清晰地表达函数的意图，即将输入值乘以2。
e2e/fixtures/tree-shaking.import_namespace/expect.js (1)
12-14: 测试断言看起来正确，但可以增加一些注释测试断言检查了"shouldKeep1"和"shouldKeep2"的存在，以及"shouldNotKeep"的不存在，这看起来是在验证树摇（tree-shaking）的有效性。这些断言清晰明了。
建议添加一些注释来解释这些字符串的含义，以及为什么它们应该被保留或移除。这将有助于其他开发者更好地理解测试的目的。例如：
// 检查应该被保留的代码 expect(content).toContain("shouldKeep1"); expect(content).toContain("shouldKeep2"); // 检查应该被树摇掉的代码 expect(content).not.toContain("shouldNotKeep");e2e/fixtures/tree-shaking.import_namespace/src/index.tsx (3)
8-14: 数组操作示例良好，但可以进行小优化这段代码很好地展示了ES6+的数组操作特性，包括初始化、解构和展开语法。"Guardian don't remove"的注释表明这些操作是有意保留的。
对于小型内联数组，可以考虑移除尾随逗号，使代码更加简洁：
-let array= [1,2,3,] +let array = [1, 2, 3]另外，建议在变量声明和等号两侧保持一致的空格，以提高可读性。
16-21: 对象操作示例良好，建议保持一致性这段代码很好地展示了ES6+的对象操作特性，包括初始化、解构和展开语法。操作正确且与之前的数组操作保持一致。
为了与数组初始化保持一致，建议在对象初始化时也使用尾随逗号：
-let object = {a: 1,b: 2,c: 3} +let object = { a: 1, b: 2, c: 3, }同时，建议在对象属性的冒号后添加空格，以提高可读性。这样的一致性有助于维护代码风格的统一。
1-21: 文件结构良好，但缺乏明确目的说明这个文件很好地展示了现代JavaScript/TypeScript的特性，包括模块导入、解构和展开语法等。代码结构清晰，易于理解。
然而，文件的具体用途在更大的应用程序上下文中并不明确。建议：
- 添加文件顶部的注释，解释此文件的目的（例如，是否为测试文件、示例代码等）。
- 如果这是一个示例或测试文件，考虑将其移动到专门的示例或测试目录中。
- 如果这是生产代码的一部分，请重新评估console.log语句的使用，并考虑添加更多的业务逻辑或将其与其他组件集成。
这些改进将有助于其他开发人员更好地理解和维护这段代码。
crates/mako/src/module_graph.rs (1)
317-329: 代码重构提高了可读性和效率这个重构很好地改进了代码。使用
retain方法使代码更加简洁和惯用。引入found标志确保只移除一个匹配的依赖项，这是一个很好的做法。考虑添加一个注释，解释为什么在处理一个边之后就立即返回。例如：
// 假设每个模块只有一个匹配的依赖项，所以在处理一个边后立即返回 return;这将有助于未来的开发者理解这个设计决策。
crates/mako/src/plugins/tree_shaking/collect_explicit_prop.rs (1)
31-32: 改进注释的可读性以提高代码理解度。第31-32行的注释内容不够清晰，建议重新表述以更好地传达含义，便于他人理解。
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- .github/workflows/ci.yml (1 hunks)
- crates/mako/src/module_graph.rs (1 hunks)
- crates/mako/src/plugins/tree_shaking.rs (1 hunks)
- crates/mako/src/plugins/tree_shaking/collect_explicit_prop.rs (1 hunks)
- crates/mako/src/plugins/tree_shaking/remove_useless_stmts.rs (3 hunks)
- crates/mako/src/plugins/tree_shaking/shake.rs (2 hunks)
- e2e/fixtures/tree-shaking.import_namespace/expect.js (1 hunks)
- e2e/fixtures/tree-shaking.import_namespace/mako.config.json (1 hunks)
- e2e/fixtures/tree-shaking.import_namespace/src/index.tsx (1 hunks)
- e2e/fixtures/tree-shaking.import_namespace/src/mod.js (1 hunks)
Additional comments not posted (10)
e2e/fixtures/tree-shaking.import_namespace/src/mod.js (2)
1-3: 函数实现正确，符合预期用途。
shouldKeep1函数实现了一个简单的平方运算。函数名暗示在树摇过程中应该保留此函数，这对于测试或演示树摇功能很有用。
9-11: 函数实现正确，但需要澄清其用途。
shouldNotKeep函数实现了一个简单的立方运算。函数名暗示在树摇过程中应该移除此函数。考虑到函数名表明它应该在树摇过程中被移除，请澄清包含此函数的目的。是否是为了验证树摇机制能够正确地识别和移除未使用的代码？
为了验证这个假设，我们可以运行以下脚本来检查项目中是否有使用这个函数的地方：
如果这个函数确实应该被移除，那么在实际的应用代码中不应该找到它的使用。
Verification successful
验证通过，函数
shouldNotKeep仅在测试中使用，不影响生产环境。
shouldNotKeep函数仅在e2e/fixtures/tree-shaking.import_namespace/expect.js中被引用。Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # 描述：搜索项目中是否有使用 shouldNotKeep 函数的地方 # 测试：搜索 shouldNotKeep 函数的使用。预期：没有匹配项或仅在测试文件中找到。 rg --type js 'shouldNotKeep'Length of output: 218
e2e/fixtures/tree-shaking.import_namespace/expect.js (1)
1-10: 导入语句和设置看起来不错！导入必要的模块和实用函数，解析构建结果并注入Jest设置的过程看起来都很合理。这为后续的测试提供了良好的基础。
e2e/fixtures/tree-shaking.import_namespace/src/index.tsx (1)
5-6: 注意控制台日志在生产环境中的使用这些控制台日志语句正确地调用了导入的函数，但在生产环境中可能会引起问题。
请确保在将代码部署到生产环境之前，移除或注释掉这些控制台日志语句。如果这些日志是为了调试目的，考虑使用更高级的日志系统或条件性日志记录。
crates/mako/src/plugins/tree_shaking.rs (1)
12-12: 新模块添加：collect_explicit_prop新增了
collect_explicit_prop模块，这可能扩展了树摇（tree shaking）插件的功能。建议进一步调查以下几点：
- 这个新模块的具体实现和用途是什么？
- 它如何与现有的树摇功能集成？
- 是否需要在
FarmTreeShake结构体中添加相应的调用？请运行以下脚本以验证新模块的使用情况：
Verification successful
建议进一步检查
collect_explicit_prop模块的实现，以确保其功能与树摇插件的整体逻辑一致。请运行以下脚本以获取该模块的代码内容：
模块
collect_explicit_prop添加验证通过
collect_explicit_prop模块已正确集成并在相关文件中使用，功能实现符合预期，且相关测试覆盖充分。Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # 描述：检查 collect_explicit_prop 模块的使用情况 # 测试：搜索 collect_explicit_prop 的使用。预期：找到该模块的实现和使用位置。 rg --type rust -e "collect_explicit_prop" -e "use (self::)?collect_explicit_prop::" crates/mako/src/Length of output: 293
Script:
#!/bin/bash # 描述：获取 collect_explicit_prop 模块的实现 cat crates/mako/src/plugins/tree_shaking/collect_explicit_prop.rsLength of output: 6338
.github/workflows/ci.yml (1)
118-119: 添加 RUST_BACKTRACE 环境变量以增强调试能力在 E2E 测试步骤中添加
RUST_BACKTRACE=full环境变量是一个很好的做法。这将有助于在测试失败时提供更详细的错误信息。考虑事项：
- 这可能会增加日志输出的大小，特别是在发生错误时。
- 在某些情况下，完整的回溯可能会暴露敏感信息，尽管在 CI 环境中这通常不是问题。
建议：
- 确保团队成员了解这一变化，以便他们能够更好地解读 CI 日志。
- 考虑是否需要在所有环境中都启用完整回溯，或者只在特定的调试构建中启用。
crates/mako/src/plugins/tree_shaking/collect_explicit_prop.rs (1)
93-95: 请确认代码兼容的最低Rust版本。第93-95行使用的
if let ... && let ...语法是在Rust 1.65.0版本中引入的。请确保项目的最低Rust版本要求满足此语法的使用。crates/mako/src/plugins/tree_shaking/remove_useless_stmts.rs (1)
118-118: 请验证新函数调用的影响在第118行，添加了对
optimize_import_namespace函数的调用。请确保此更改不会对现有功能产生负面影响，并在相关情况下进行了充分的测试。crates/mako/src/plugins/tree_shaking/shake.rs (2)
14-14: 引入必要的模块。新增了对
Helpers和HELPERS的引入，为后续使用HELPERS.set提供了支持，合理且必要。
146-153: 在HELPERS上下文中调用shake_module函数。将
shake_module函数的调用包裹在HELPERS.set(&Helpers::new(true), || { ... })中，确保在执行期间拥有一个新的Helpers实例，有助于正确管理代码生成的辅助函数，避免状态共享导致的潜在问题。
Comment on lines
+1
to
+5
| { | ||
| "optimization": { | ||
| "concatenateModules": false | ||
| } | ||
| } |
There was a problem hiding this comment.
💡 Codebase verification
配置文件中的 concatenateModules 设置不一致
在多个 mako.config.json 文件中发现 concatenateModules 设置为 true 和 false，这可能导致项目中不同部分的优化行为不一致。例如：
examples/with-antd/mako.config.json设置为truee2e/fixtures/tree-shaking.import_namespace/mako.config.json设置为false- 其他多个配置文件中也存在类似不一致的设置
建议统一 concatenateModules 的配置，以确保整个项目的优化策略一致，提升构建过程的可预测性和稳定性。
Analysis chain
配置文件添加正确，建议验证优化策略。
新增的 mako.config.json 文件结构正确，设置了 concatenateModules 为 false，这将禁用模块连接优化。
请验证此配置是否符合项目的优化目标。可以运行以下脚本来检查其他相关配置文件中是否有类似的设置：
这将帮助确保新配置与项目的整体优化策略保持一致。
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 描述：搜索其他配置文件中的 concatenateModules 设置
# 测试：搜索其他包含 concatenateModules 设置的 JSON 文件
echo "搜索其他包含 concatenateModules 设置的配置文件："
rg --type json 'concatenateModules' -g '!e2e/fixtures/tree-shaking.import_namespace/mako.config.json'
# 测试：检查是否有其他与树摇相关的配置
echo "搜索其他可能与树摇相关的配置："
rg --type json 'tree.?shaking|optimization' -g '*.config.json'
Length of output: 23073
Comment on lines
+1
to
+3
| import * as mod from "./mod"; | ||
|
|
||
| const { shouldKeep2 } = mod |
There was a problem hiding this comment.
🛠️ Refactor suggestion
考虑优化导入和解构语句
当前的导入和解构方式是正确的，但可以进行优化以提高代码的简洁性和可读性。
建议将导入和解构合并为一个语句，如下所示：
-import * as mod from "./mod";
-
-const { shouldKeep2 } = mod
+import { shouldKeep1, shouldKeep2 } from "./mod";这样可以减少代码行数，并且更明确地表示我们只需要 mod 模块中的特定函数。
Committable suggestion was skipped due to low confidence.
Comment on lines
+272
to
+273
| let mut shadow = module.clone(); | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
优化性能：避免克隆整个模块
在第272行，代码克隆了整个模块 let mut shadow = module.clone();。克隆大型模块可能带来性能开销。建议考虑是否有办法在不克隆整个模块的情况下实现相同的功能，或者仅克隆必要的部分，以提升性能。
Comment on lines
+265
to
+266
| let (sym, ctxt) = ns.rsplit_once('#').unwrap(); | ||
| (sym.into(), SyntaxContext::from_u32(ctxt.parse().unwrap())) |
There was a problem hiding this comment.
避免使用 unwrap() 导致潜在的崩溃
在第265行和266行，代码直接使用了 unwrap() 方法。如果 ns 字符串中不包含 #，或者 ctxt.parse() 解析失败，程序将会崩溃。建议使用模式匹配来处理可能的错误情况，提升代码的健壮性。
您可以修改代码如下：
- let (sym, ctxt) = ns.rsplit_once('#').unwrap();
- (sym.into(), SyntaxContext::from_u32(ctxt.parse().unwrap()))
+ if let Some((sym, ctxt_str)) = ns.rsplit_once('#') {
+ if let Ok(ctxt_num) = ctxt_str.parse() {
+ (sym.into(), SyntaxContext::from_u32(ctxt_num))
+ } else {
+ // 处理解析失败的情况
+ }
+ } else {
+ // 处理未找到 '#' 的情况
+ }Committable suggestion was skipped due to low confidence.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1610 +/- ##
==========================================
+ Coverage 55.44% 55.66% +0.22%
==========================================
Files 171 172 +1
Lines 17142 17294 +152
==========================================
+ Hits 9504 9627 +123
- Misses 7638 7667 +29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
crates/mako/src/module_graph.rs (1)
307-314: 新方法实现更加高效，但可以考虑添加错误处理和注释这个新的
rewrite_dependency方法的实现看起来更加高效和直接。它通过先删除所有现有的依赖关系，然后添加新的依赖关系，有效地重写了模块的依赖关系。然而，有几点建议可以进一步改进这个方法：
考虑添加错误处理机制。如果在执行过程中出现错误（例如，在删除旧依赖后添加新依赖时失败），可能会导致模块处于不一致的状态。
建议添加方法注释，解释该方法的目的和行为，这将有助于其他开发者理解和维护代码。
建议按照以下方式修改代码：
/// 重写指定模块的所有依赖关系。 /// /// 该方法首先移除模块的所有现有依赖，然后添加新的依赖关系。 /// /// # 参数 /// /// * `module_id` - 要重写依赖的模块ID /// * `deps` - 新的依赖关系列表 /// /// # 错误 /// /// 如果在重写过程中出现错误，将回滚所有更改并返回错误。 pub fn rewrite_dependency(&mut self, module_id: &ModuleId, deps: Vec<(&ModuleId, Dependency)>) -> Result<(), Error> { let old_deps = self.get_dependencies(module_id); // 移除所有现有依赖 let mut edges = self.get_edges(module_id, Direction::Outgoing); while let Some((edge_index, _node_index)) = edges.next(&self.graph) { self.graph.remove_edge(edge_index); } // 尝试添加新依赖 for (m, d) in deps { if let Err(e) = self.add_dependency(module_id, m, d.clone()) { // 如果出错，回滚更改 self.rewrite_dependency(module_id, old_deps)?; return Err(e); } } Ok(()) }这个修改版本添加了错误处理和回滚机制，以及详细的方法注释。
Comment on lines
332
to
333
| let deps = analyze_deps::AnalyzeDeps::analyze_deps(&info.ast, &info.file, context.clone()); | ||
| deps.unwrap().resolved_deps.iter().for_each(|r| { |
There was a problem hiding this comment.
避免使用unwrap()造成的潜在崩溃
在第332行，直接调用deps.unwrap()可能在deps为None时引发panic，导致程序崩溃。建议处理Result类型的错误，使用?操作符或模式匹配来安全地处理可能的错误。
应用以下修改以处理可能的错误：
- let deps = analyze_deps::AnalyzeDeps::analyze_deps(&info.ast, &info.file, context.clone());
- deps.unwrap().resolved_deps.iter().for_each(|r| {
+ let deps = analyze_deps::AnalyzeDeps::analyze_deps(&info.ast, &info.file, context.clone())?;
+ deps.resolved_deps.iter().for_each(|r| {并确保在函数签名中传播错误或进行适当的错误处理。
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| let deps = analyze_deps::AnalyzeDeps::analyze_deps(&info.ast, &info.file, context.clone()); | |
| deps.unwrap().resolved_deps.iter().for_each(|r| { | |
| let deps = analyze_deps::AnalyzeDeps::analyze_deps(&info.ast, &info.file, context.clone())?; | |
| deps.resolved_deps.iter().for_each(|r| { |
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- crates/mako/src/module_graph.rs (2 hunks)
- crates/mako/src/plugins/tree_shaking/shake/skip_module.rs (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- crates/mako/src/plugins/tree_shaking/shake/skip_module.rs
Additional comments not posted (1)
crates/mako/src/module_graph.rs (1)
312-314: 添加新依赖的实现方式清晰您使用
iter().for_each方法添加新的依赖，代码简洁明了，符合 Rust 的惯用风格。
Comment on lines
+307
to
+310
| pub fn rewrite_dependency(&mut self, module_id: &ModuleId, deps: Vec<(ModuleId, Dependency)>) { | ||
| let mut edges = self.get_edges(module_id, Direction::Outgoing); | ||
|
|
||
| while let Some((edge_index, _node_index)) = edges.next(&self.graph) { | ||
| let dependencies = self.graph.edge_weight_mut(edge_index).unwrap(); | ||
|
|
||
| if let Some(to_del_dep) = dependencies | ||
| .iter() | ||
| .position(|dep| *source == dep.source && dep.resolve_type.same_enum(&resolve_type)) | ||
| { | ||
| dependencies.take(&dependencies.iter().nth(to_del_dep).unwrap().clone()); | ||
|
|
||
| if dependencies.is_empty() { | ||
| self.graph.remove_edge(edge_index); | ||
| } | ||
| return; | ||
| } | ||
| self.graph.remove_edge(edge_index); |
There was a problem hiding this comment.
在迭代过程中修改图结构可能导致未定义行为
在 rewrite_dependency 方法中，您在迭代 edges 的同时删除边，这可能导致迭代器失效和未定义行为。建议在迭代之前先收集所有需要删除的边的索引，然后再进行删除操作。
建议修改代码如下：
let edges_to_remove: Vec<_> = self.get_edges(module_id, Direction::Outgoing)
.filter_map(|(edge_index, _)| Some(edge_index))
.collect();
for edge_index in edges_to_remove {
self.graph.remove_edge(edge_index);
}
Jinbao1001
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
crates/mako/src/module_graph.rs (1)
307-314: 重写依赖关系的方法实现得当，但可以进一步优化新添加的
rewrite_dependency方法很好地解决了之前在迭代过程中修改图结构可能导致的未定义行为问题。这种方法通过先删除所有现有的出边，然后重新添加新的依赖关系，避免了在迭代过程中修改图结构。然而，我们可以通过以下方式进一步优化性能：
- 使用
self.graph.edges_directed()替代self.get_edges()，这样可以直接获取边的引用，避免额外的迭代器封装。- 使用
retain方法来移除边，这样可以在一次遍历中完成所有边的移除操作。建议按照以下方式重构代码：
pub fn rewrite_dependency(&mut self, module_id: &ModuleId, deps: Vec<(ModuleId, Dependency)>) { let node_index = *self.id_index_map.get(module_id).expect("Module not found"); self.graph.retain_edges(|graph, edge_index| { graph.edge_endpoints(edge_index).map_or(true, |(source, _)| source != node_index) }); for (m, d) in deps { self.add_dependency(module_id, &m, d); } }这个优化版本减少了不必要的迭代，并使用了更高效的图操作方法。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- crates/mako/src/module_graph.rs (2 hunks)
- crates/mako/src/plugins/tree_shaking/shake/skip_module.rs (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- crates/mako/src/plugins/tree_shaking/shake/skip_module.rs
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
crates/mako/src/plugins/tree_shaking.rs (2)
Line range hint
51-90: 优化模块项替换的逻辑在
visit_mut_module_items方法中，当前实现先遍历收集需要替换的项，然后反向替换模块项列表。可以考虑直接在遍历过程中进行替换，避免反向操作，简化代码并提高效率。
Line range hint
117-129: 测试用例输入与期望输出相同在
test_non_toplevel_decl测试中，输入代码和期望输出代码相同，没有验证代码的任何变更。建议检查测试用例是否正确，或修改测试以验证非顶层声明不被拆分的行为。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- crates/mako/src/plugins/tree_shaking.rs (1 hunks)
- crates/mako/src/plugins/tree_shaking/shake/skip_module.rs (5 hunks)
🧰 Additional context used
🔇 Additional comments (6)
crates/mako/src/plugins/tree_shaking.rs (1)
Line range hint
26-36: 确认对config._tree_shaking的访问是否正确在
transform_js方法中，代码检查了context.config._tree_shaking是否有值。请确认Config结构体中是否存在名为_tree_shaking的字段，或者是否应使用tree_shaking。可以运行以下脚本来验证
Config结构体中的字段命名：crates/mako/src/plugins/tree_shaking/shake/skip_module.rs (5)
15-15: 导入新模块analyze_deps代码中引入了
analyze_deps模块，这对于依赖分析的功能实现是必要的。
170-170: 优化参数命名提升可读性将参数名从
_context修改为context，符合命名惯例，增强了代码的可读性和一致性。
186-186: 优化参数命名提升可读性
apply_replace函数中的参数从_context修改为context，与其他部分保持一致，提高了代码的清晰度。
331-340: 避免使用unwrap()可能引发的潜在崩溃第 334 行直接调用了
deps.unwrap()，如果deps为None，将导致程序panic崩溃。建议安全地处理可能的错误，使用?操作符或匹配模式来处理Result类型。
497-497: 保持参数命名一致在调用
apply_replace函数时，将参数名更新为context，与函数定义保持一致，增强了代码的一致性。
| use crate::module_graph::ModuleGraph; | ||
| use crate::plugin::{Plugin, PluginTransformJsParam}; | ||
|
|
||
| mod collect_explicit_prop; |
There was a problem hiding this comment.
建议移除未使用的模块 collect_explicit_prop
collect_explicit_prop 模块在代码中未被引用，建议移除以保持代码整洁。
| let stmt_id = to_replace.0; | ||
| let replaces = &to_replace.1; | ||
| let source = &to_replace.2; | ||
| let _source = &to_replace.2; |
There was a problem hiding this comment.
移除未使用的变量 _source
变量 _source 被声明但未在函数中使用，建议删除以简化代码。
请应用以下修改：
- let _source = &to_replace.2;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| let _source = &to_replace.2; |
elrrrrrrr
pushed a commit
that referenced
this pull request
Jul 9, 2025
* fix: env_replacer should not replace user defined variable in scope (#1577) * fix: env_replacer should not replace user defined variable in scope * test: add test cases for env_replacer * chore: code style * release: @umijs/mako@0.8.11 * chore: bundler-mako@0.8.11 * docs: add changelog for v0.8.11 * fix(tree-shaking): detect export var side effects (#1579) * test: ✅ add a failure test * fix: 🐛 add is pure detection in export var decl * fix: bad output when chunk_loading_global containing quotation mark (#1582) * chore: ➕ add a subdot cli tool script (#1585) * fix(win): copy don't work under windows (#1587) * fix(win): module id should be win_pathed (#1588) * feat(tree-shaking): optimize import namespace used all exports to partial used of source modules (#1584) * test: ✅ add failure test case * feat: ✨ add collect prop explicit field * feat: ✨ collect explicit member prop access to optizmize used export in dep module replace USE ALL export to partial used exports * fix: dedestructuring before collect ExplicitProps * test: ✅ add back trace env var * test: ✅ update test case * fix: 🐛 add globals and helpers --------- Co-authored-by: Jinbao1001 <nodewebli@gmail.com> * fix: merge mako config (#1578) * fix: merge mako config * fix: merge mako config * fix:clear deps should not panic when module not found (#1581) * fix:clear deps should not panic when module not found * chore: use tracing warn * fix: delete log * Revert "fix: merge mako config (#1578)" (#1589) This reverts commit c08821d. * fix: watch too many file error (#1550) * fix: watch too many file error * chore: delete print * chore: delete log * release: @umijs/mako@0.8.8-rc.1 * fix: conflict * feat: support numeric module Id (#1561) * feat: moduleIdStrategy support numberous * fix: typos * fix: typos * fix: change name * fix: typos * release: @umijs/mako@0.8.12 * chore: fix typo and doc (#1591) * fix: chunk_loading_global (#1590) * fix: bad entry output when chunk_loading_global containing singe quote * test: add test cases for chunk_loading_global * docs: update * chore: update lock * chore: remove useless dependencies (#1595) * refactor: 🔥 rm ci warn logs (#1596) * fix: devServer put static serve proxy after umi proxy middleware (#1558) * fix: fix umi load html file failed, * test: add umi devServer test case * fix: typo * fix: hmr on hyper-static-file error * fix: import expect.mjs error on github workflow. * fix: import expect.mjs error on github workflow. * fix: 🐛 expect for error case * fix: 🐛 dev.hmr dont stop * fix: 🐛 add OKAM env * fix: 🐛 wait for mako server * fix: 🐛 kill by children process * test: ✅ add umi.css * refactor: 🎨 unify expect file * feat: export killMakoDevServer from test-hmr.mjs, make it public for all test case * test: ✅ unify expect file * chore: ➕ use express-http-proxy for static proxy * feat: ✨ better mako static proxy * test: ✅ support umi dev test with local mako * chore: ⬆️ update pnpm-lock * chore: 🎨 * fix: 🐛 ignore children process killed error --------- Co-authored-by: huanyu.why <huanyu.why@antgroup.com> Co-authored-by: pshu <pishu.spf@antfin.com> * fix(tree-shaking): object spread transform should go before deconstructing (#1598) * fix: 🐛 deconstructing needs object spread transform first * test: ✅ add guardian syntax * release: @umijs/mako@0.8.13-canary.20240918.1 * chore: bundler-mako@0.8.13-canary.20240918.1 * chore: 🎨 thread name after mako (#1601) * refactor: 🎨 rayon is not friendly to js users * chore: ✏️ rename tokio worker with mako * revert: import namespace optimize (#1606) * Revert "fix(tree-shaking): object spread transform should go before deconstructing (#1598)" This reverts commit 9434d99. * Revert "feat(tree-shaking): optimize import namespace used all exports to partial used of source modules (#1584)" This reverts commit 81a52f8. * chore: 🔧 update mako clean script * release: @umijs/mako@0.8.13 * chore: bundler-mako@0.8.13 * docs: change log 0923 (#1607) * docs: 📝 change log * docs: 📝 change log 0923 * chore: ✏️ * fix: 🐛 turn off express-http-proxy's keep alive (#1612) * fix: 🐛 turn off express-http-proxy's keep alive * refactor: 🔥 remove timeout config * release: @umijs/mako@0.8.14 * chore: bundler-mako@0.8.14 * refactor: napi threadsafe function (#1608) * refactor: napi threadsafe function * chore: update binding typings * refactor: code pieces * fix: catch napi tsfn promise rejection * chore: update binding typings * docs: 📝 change log 20240925 (#1613) * feat: disable webp to base64 (#1602) * feat: init * fix: context * fix: no use * fix: typos * fix: typos * fix: typos * fix: typos * fix(bundler-mako): experimental config should be merged deeply (#1617) * refactor: config codes organization (#1618) * refactor: config codes organization * fix: typos * refactor: config parse error * fix: clickToComponent don't work (#1620) * fix: duplicate_package_checker panic when no package.json is supplied (#1621) * fix: file_stem index out of bound (#1623) * feat: add resolve_id plugin hook (#1625) * feat: add resolve_id plugin hook * chore: update docs * feat: add external * release: @umijs/mako@0.8.15 * chore: bundler-mako@0.8.15 * docs: changelog for 0.8.15 * chore: update the release instruction (#1627) * refactor: code-splitting config (#1629) * feat: add loadInclude plugin hook (#1630) * feat: add { isEntry } for resolve_id plugin hook (#1631) * feat/upgrade swc (#1444) * 🚧 * 🚧 a basic working version * chore: 🚨 lint happy * refactor: 🎨 adjust to new swc * refactor: 🎨 remove deprecated methods * chore: 🚨 lint happy * feat: ✨ update swc emotion * chore: 🔧 remove useless profile in sub crate * chore: 🔧 add back emotion plugin * refactor: 🎨 add back merge source map * test: ✅ hot update js file served by hyper static, it use text/javascript * chore: 🔧 lock update * chore: 🔧 clean up swc core feature * refactor: 🎨 fix breaking change of ctxt of span * fix: 🐛 ctxt apply mark * refactor: 🎨 use DUMMY CTXT instead of SyntaxContext::empty() * chore: ⬆️ temperal use mdxjs from kdy branch * feat: ✨ re-enable mdxjs * feat: ✨ swc_core 0.100.1 * chore: 🙈 ignore fmt in fixtures * chore: 🚨 lint happy * chore: ⬆️ swc_common * chore: ✏️ typo * release: @umijs/mako@0.8.1-canary.20240812.1 * chore: bundler-mako@0.8.1-canary.20240812.1 * chore: ⬆️ swc_core 0.100.6 * release: @umijs/mako@0.8.1-canary.20240814.2 * chore: bundler-mako@0.8.1-canary.20240814.2 * chore: 🚨 lint happy * chore: 🔧 CI build bindings * chore: 🔧 fix build docker * refactor: 🔥 remove aarch64-unknown-linux-gnu * chore: 🔧 create tar * chore: 🙈 * release: @umijs/mako@0.8.3-canary.20240820.1 * chore: bundler-mako@0.8.3-canary.20240820.1 * chore: 🔧 wrong donwload param * chore: 🔧 upload download actions should be same version * chore: 🔧 try codecov in ci * refactor: 🔥 remove unnecessary target * refactor: 🎨 use swc comments * fix: 🐛 after upgrade to swc_core it should remove paren before minifiy * refactor: 🎨 move dummy ctxt defintion to ast mod * chore: 🚨 lint happy * release: @umijs/mako@0.8.8-canary.20240902.1 * chore: bundler-mako@0.8.8-canary.20240902.1 * release: @umijs/mako@0.8.8-canary.20240903.3 * chore: bundler-mako@0.8.8-canary.20240903.3 * refactor: 🎨 use VisitMut + Fold code style * chore: ⬆️ update pnpm-lock * chore: 🙈 * revert: ⏪ delete musl bindin * release: @umijs/mako@0.8.9-canary.20240909.1 * chore: bundler-mako@0.8.9-canary.20240909.1 * release: @umijs/mako@0.8.11-canary.20240910.1 * chore: bundler-mako@0.8.11-canary.20240910.1 * fix: 🐛 use chars() instead of bytes() * fix: 🐛 unescape html entity by html escape crate * release: @umijs/mako@0.8.14-canary.20240924.1 * chore: bundler-mako@0.8.14-canary.20240924.1 * release: @umijs/mako@0.8.15-canary.20240927.1 * chore: bundler-mako@0.8.15-canary.20240927.1 * fix: hash not stable (&revert import * as optimize) (#1610) * Revert "revert: import namespace optimize (#1606)" This reverts commit a485358. * fix: hash not stable * fix: deps sort not stable * fix: deps sort not stable * fix: deps sort not stable * fix: delete binding * fix: var name * chore: iter to into * fix: format * release: @umijs/mako@0.9.0 * chore: bundler-mako@0.9.0 * docs: 📝 changelog 0.9.0 * fix: duplicate_package_checker panic when package.json has no version field (#1634) * feat: magic comment chunk name (#1628) * refactor: code-splitting config * feat: support magic comment chunk name basically * fix: magic comment chunk name for webworker * refactor: use ImportOptions to represent option from magic comments * fix: dep replacer when magic comments chunk name existed * test: update test cases for magic comments chunk name * fix: dep replacer when dynamic import depencies is missing * chore: remove useless codes * refactor: code styles * docs: add todo for ChunkId * test: fix visitors::dynamic_import::tests::test_dynamic_import * test: fix test::hmr * fix: dep replacer when dynamic import css modules or moduleIdStrategy is hashed * chore: remove meaning less changes * test: enable magic comment chunk name in fixtures/umi * docs: add docs for magic comment chunk name * feat: support webpackIgnore and makoIgnore magic comment (#1636) * feat: support webpackIgnore and makoIgnore magic comment * chore: fmt * chore: rename magic_comment_chunk_name to magic_comment * chore: fix typo * feat: add transform plugin hook (#1637) * feat: add transform plugin hook * docs: add docs * chore: fmt * chore: perf * feat: add transformInclude plugin hook (#1639) * feat: add transformInclude plugin hook * chore: fmt * Fix: import namespace optimize panic with nested for of stmt (#1640) * test: ✅ add import namespace optimize panic test case * fix: 🐛 fix nested for of stmt panic * release: @umijs/mako@0.9.2-canary.20241016.1 * chore: bundler-mako@0.9.2-canary.20241016.1 * release: @umijs/mako@0.9.2 * chore: bundler-mako@0.9.2 * docs: 📝 changelog 0.9.2 * feat: add buildEnd plugin hook (#1644) * feat: add enforce plugin hook (#1646) * feat: add enforce plugin hook * chore: code style * chore: code style * chore: fix lint * chore: 🎨 add missing binding type * release: @umijs/mako@0.9.3-canary.20241016.1 * chore: bundler-mako@0.9.3-canary.20241016.1 * feat: add writeBundle plugin hook (#1650) * feat: add watch_changes plugin hook (#1651) * feat: add watch_changes plugin hook * chore: fix lint * chore: fix ts define * fix: mako on windows don't work (#1652) * fix: devtool sourcemap explosion in windows (#1653) * chore: remove dead code * fix: should not re-group when span changed (#1654) * fix: umd should be import as cjs (#1642) * fix: umd should be import as cjs * refactor: 🎨 just short circuit typeof define to prevent define takes effect * revert: ⏪ binding.d.ts --------- Co-authored-by: pshu <pishu.spf@antfin.com> * fix: 🐛 add process.env.SOCKET_SERVER define to prevent process polyfilll (#1655) * release: @umijs/mako@0.9.3-canary.20241023.1 * chore: bundler-mako@0.9.3-canary.20241023.1 * release: @umijs/mako@0.9.3 * chore: bundler-mako@0.9.3 * docs: changelog for 0.9.3 * fix: hmr with magic comment chunk name (#1663) * feat: enable magicComment features by default (#1667) * feat(bundler-mako): add moduleIdStrategy to supportMakoConfigKeys (#1664) * fix: async module in circular dependence (#1659) * test: ✅ add test async module in circular dependencies * refactor: 🎨 handle async polution by traversal * refactor: 🎨 use default over expect * feat: compatible codeSplitting config with umi (#1669) * feat: compatible codeSplitting config with umi * test: fix e2e code-splitting.granular * fix: umi codeSplitting: depPerChunk * Feat/benchmark workflows (#1671) * feat: benchmark-workflows * fix: 修改Github Secrets * release: @umijs/mako@0.9.4 * chore: bundler-mako@0.9.4 * docs: 📝 changelog 0.9.4 * chore: Optional parameters (#1679) * chore: Optional parameters * Update index.ts * fix: skip module should skip async module (#1662) * release: @umijs/mako@0.9.5 * chore: bundler-mako@0.9.5 * docs: update changelog * docs: update changelog * feat(ssu): handle dependence changing while watching (#1690) * refactor: 🎨 add after update aspect for rebuild cached modules * refactor: 🎨 add next_build aspect in build_my_modify * feat: ✨ 区分 ssu firstbuild 和 updating 两者状态 * fix: pnpm workspace watch too many files (#1684) * fix: ✅ ts annotated declare variable treat as top level variable (#1682) * test: ✅ add ts declare annotated variable as top level * refactor: 🎨 mv clean syntax context to visitors folder * fix: 🐛 strip ts/tsx first, then do normal transform * feat: move ensure runtime to entry (#1660) * feat: ✨ add ensure2 replace in dynamic replace * feat: ✨ ensure 2 runtime * feat: ✨ add experimental centralEnsure config * refactor: 🎨 add struct ReslvedReplaceInfo * feat: ✨ add central ensure plugin * refactor: 🎨 extract module ensure map * refactor: 🎨 add back chunk id in replace info * refactor: 🎨 fix case one source with different import type * refactor: 🎨 extract hmr runtime update code aspect * release: @umijs/mako@0.9.6-canary.20241107.1 * chore: bundler-mako@0.9.6-canary.20241107.1 * feat: keep unresolved nodejs require (#1689) * fix: regexpr for nodejs intenal modules igonre * feat: not replace unresolved nodejs require to __mako_require__ * fix: define util require should be __mako_require__ * feat: add expreriental.keep_unresolved_node_require * feat: add expreriental.ignore_non_literal_require * chore: 🔥 remove unused fn * release: @umijs/mako@0.9.6 * chore: bundler-mako@0.9.6 * docs: changelog for 0.9.6 * fix(SSU): 🐛 in case external not avaible to all entries (#1698) * fix(SSU): 🐛 in case external not avaible to all entries * refactor: 🎨 explict ignore the error * fix: devserver response header add cacheControl no-cache (#1692) * fix: add no-cache * feat: add cross origin * fix: resonse header add cors and no_cache for all branch (#1699) * fix: judge devServer instead of writeToDisk * fix: add branch header * refactor: 🎨 static file with 0 ages --------- Co-authored-by: pshu <pishu.spf@antfin.com> * release: @umijs/mako@0.9.7 * chore: bundler-mako@0.9.7 * docs: 📝 update changelog for 0.9.7 * chore: ✏️ remove some if (#1706) * fix: optimization.concatenateModules dts lost (#1708) * refactor: 🔥 enter ensure 使用 chunk sync dep 减少首屏 chunk 数量 (#1707) * fix: 🐛 typing of stats (#1712) * fix: 🐛 detect circular deps output file content (#1715) * chore: update @umijs/mako typings * feat: ensure esm imports exists when mode is production (#1709) * feat: ensure esm imports exists when mode is production * release: @umijs/mako@0.9.8 * chore: bundler-mako@0.9.8 * docs: update docs * fix: node ignores (#1716) * feat: supports publicPath: auto (#1717) * feat: auto resolve entry file extension (#1718) * feat: auto resolve entry file extension * fix: remove useless clone * Fix/context module source with first empty quasis (#1719) * test: ✅ add first empty quasis template string module source case * fix: 🐛 first emtpy quasis case * fix: inline css config deserialize (#1720) * fix: node ignore should support node: prefixed only built-in modules (#1721) * release: @umijs/mako@0.9.9 * docs: suggest using volta to manage node and pnpm's version * chore: bundler-mako@0.9.9 * docs: update CHANGELOG.md * feat: supports umd export (#1723) * feat: supports umd export * fix: umd config binding typing * fix: typos * fix: umd export * chore: update typings * fix: replace the "typeof __webpack_require__" content (#1688) * fix: replace the "typeof __webpack_require__" content * fix: add some other webpack string name * fix: 增加对typeof 表达式的处理 * fix: delete log * fix: rename --------- Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> * fix: umd config deserialization (#1726) * feat: support case sensitive (#1714) * feat: add CaseSensitivePlugin * FIX: update path check * fix: clippy error * fix: 调整判断 * fix: 修复目录读取 * fix: 修改参数名称 * fix: 调整测试方式添加e2e断言，并增加配置项只有mac系统下才需要开启相关配置 * fix: 删除过滤条件 * fix: 删除多余测试文件，增加更新内容 * fix: 删除多余log * fix: 测试执行 * fix: 添加测试系统 * fix: 调整顺序 * fix: 添加测试系统 * fix: 非mac环境断言 * fix: 引用遗漏 * fix: 断言 * fix: 删除默认 * fix: 默认配置 * fix: 测试覆盖 * Revert "fix: 测试覆盖" This reverts commit b0a2e66. --------- Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> * refactor: 🔥 remove unecessary transform (#1727) * feat: output filename (#1725) * refactor: 🎨 add file name template and chunk name in ChunkFile struct * feat: ✨ add config to output#filename * feat: ✨ render filename when output#filename configed * feat: ✨ calc hash in ast impl for entry * test: ✅ add test case * test: ✅ add ut * chore: 🔧 disable codecov error * refactor: 🎨 remove clone * fix: 🐛 hash when necessary * chore: 🔧 add codecov.yml * release: @umijs/mako@0.9.10-canary.20241218.1 * chore: ⬆️ update pnpm-lock * feat: native plugin init (#1691) * feat: init rust plugin * chore: delete print * Rename cargo.toml to Cargo.toml * chore: update * fix: type * fix: plugin options string * fix: cfg test * release: @umijs/mako@0.10.0 * chore: bundler-mako@0.10.0 * docs: 📝 changelog 2024.12.20 * chore: 🔧 for quick setup dep to debug (#1733) * fix: support optional chaining in environment variable (#1730) * fix: support optional chaining in environment variable * test(): add edge cases for optional chaining in env_replacer * refactor: 🎨 no need to resolve empty url in css (#1732) * refactor: 🎨 no need to resolve empty url in css * refactor: 🎨 add test case * feat: support unplugin context (#1728) * feat: support plugin context * fix: napi context * chore: revert changes * chore: improve * feat: add error * feat: warn and error support object * feat: support emit_file * ci: fix test * chore: improve * chore: update test * chore: format * chore: don't support add watch file * feat: load and transform adapter, and add unplugin-replace example * chore: test unplugin-icons * chore: update pnpm-lock.yaml * docs: improve --------- Co-authored-by: xusd320 <xusd320@gmail.com> * fix: legacy octal escape is not permitted in strict mode (#1736) * fix: legacy octal escape is not permitted in strict mode * fix: e2e inline css * release: @umijs/mako@0.11.0 * chore: bundler-mako@0.11.0 * fix: pnpm lock * docs: 📝 changelog 2024.12.26 * Revert "feat: support unplugin context (#1728)" (#1737) This reverts commit 3dd6d9d. * release: @umijs/mako@0.11.1 * chore: bundler-mako@0.11.1 * feat: support unplugin context (#1741) * feat: support plugin context * fix: napi context * chore: revert changes * chore: improve * feat: add error * feat: warn and error support object * feat: support emit_file * ci: fix test * chore: improve * chore: update test * chore: format * chore: don't support add watch file * feat: load and transform adapter, and add unplugin-replace example * chore: test unplugin-icons * chore: update pnpm-lock.yaml * docs: improve --------- Co-authored-by: xusd320 <xusd320@gmail.com> * fix: #1007 (#1738) support BinaryExpression Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> * fix: win path problem with context module and require context (#1742) * chore(mako): add debug notice for local builds (#1743) * fix: normalize Windows paths in ModuleId constructors (#1744) * fix: normalize Windows paths in Compiler output path handling (#1745) * fix: typos * release: @umijs/mako@0.11.2 * chore: bundler-mako@0.11.2 * docs: update CHANGELOG.md * feat(create-mako): refactor create-mako (#1751) * chore: add issue and pull request templates for better contribution guidelines (#1753) * fix: ensure parent directories are created when writing to disk in MemoryChunkFileCache (#1755) * chore: release @umijs/tools * release: @umijs/mako@0.11.3 * chore: update the release introduction * ci: fix ci (#1758) * chore: upgrade @umijs/tools and do github release and changelog generate and translation by script * docs: changelog for 0.11.3 * chore: add check-ecosystem-usages script (#1759) * fix: analyze don't work in safari (#1761) * fix(mako): cli delay exit (#1762) * dep: @umijs/tools@0.1.23 * fix: load wasm (#1705) * fix: 修复load .wasm文件对importObject的处理 * fix: 删除没必要的输出 * fix: 修改生成的成员表达式js代码 * fix: 变量重命名 * fix: 修复代码lint报错 * test: 补充wasm_runtime测试用例 * chore: 补充import js方式的示例 * chore: 修改import js示例wasm产物格式 * chore: wasmparser依赖包在配置文件的位置 * chore: 删除多余的.wasm load逻辑 --------- Co-authored-by: xusd320 <xusd320@gmail.com> * fix: chunk groups' order when building mpa (#1763) * feat(copy): support advanced copy configuration with custom target paths (#1711) * feat(copy): support advanced copy configuration with custom target paths - Add CopyConfig enum to support both basic and advanced copy modes - Basic mode: maintains backward compatibility with string[] format - Advanced mode: supports {from: string, to: string} format for custom paths - Update copy plugin to handle both configuration formats - Ensure target directories are created automatically Example config: { 'copy': [ 'public', // basic mode { 'from': 'assets', 'to': 'static' } // advanced mode ] } * fix(copy): prevent path traversal in copy plugin Add path canonicalization and validation to ensure target paths remain within the destination directory * chore: Update `copy` config type in Mako bundler - Updated the type of the `copy` property in the `BuildParams` interface to support both `string` and `{ from: string; to: string }`. - Ensured the `copy` configuration is properly validated to handle both types. * docs: Update `copy` config type in documentation - Updated the `copy` property type in the configuration documentation to reflect the change from `string[]` to `(string | { from: string; to: string })[]`. - Clarified that the `copy` configuration can now accept both strings and objects with `from` and `to` properties. * test(copy): add e2e tests for copy plugin from/to pattern - Update config.copy test fixtures to cover from/to pattern - Add assertions for copied files in new location - Adjust copy plugin path validation * fix(copy): improve path validation and cleanup for copy plugin - Add directory cleanup when path validation fails - Use canonicalized paths for more reliable path validation - Add concatenateModules option type to BuildParams * fix: ci (#1768) * release: @umijs/mako@0.11.4 * chore: bump version * docs: 📝 changelog 2025.02.12 * chore: update changelog 2025.02.12 * fix: plugin context gc (#1769) * fix: mako已经支持了scss 但是没有支持module.scss文件 (#1770) Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> * feat: add module federation plugin (#1764) * feat: support module federation * feat: mf exposes to remote entries * chore: code styles * feat: mf container entry impl * fix: mf container entry * fix: mf runtime initOptions * feat: add containter references * feat: impl mf remote * feat: improve mf exposes * fix: mf exposes runtime factory * fix: mf plugin execution order * chore: update mf demo * feat: generate mf manifest in rust * fix: remote stats.json * refactor: code styles * chore: add some FIXME * refactor: mf plugin mods files * refactor: mf plugin mods files * chore: remove dead code * --wip-- [skip ci] * fix: remote stats.json * fix: typos * chore: simpify mf runtime codes fmt * refactor: mf containter plugin * feat: mf shared workaround * feat: mf shared workaround * fix: runtime template and remove some useless codes * fix: mf dev server * fix: mf shared config * feat: supports chunk group exclude * feat: mf patch code splitting * feat: mf shared manifest * feat: add config hash for mf shared module * chore: update mako typings * chore: code styles * chore: fix typo * chore: code styles * perf: improve performance * chore: code styles * chore: rename types * feat: add options to disable mf manifest * feat: entry config should be defined as BTreeMap * fix: mf shared consume and supports eager config * fix: mf shared eager * fix: not generate chunk for mf remote module * fix: typos * feat: add entry filename supports * chore: remove meaning less changes * fix: entry filename and mf config * release: @umijs/mako@0.11.4-canary.20250206.0 * fix: ignore shared dep when it is been external * Revert "release: @umijs/mako@0.11.4-canary.20250206.0" This reverts commit d3105d9. * release: @umijs/mako@0.11.4-canary.20250207.0 * fix: skip serialize mf manifest remoteEntry if none * fix: mf manifest remoteEntry address * Revert "release: @umijs/mako@0.11.4-canary.20250207.0" This reverts commit 6179982. * fix: typo * fix: mako mf manifest publicPath * fix: mf manifest panic * fix: mf typings * test: add e2e test for mf * fix: typo * chore: update README * fix: update mf bingding typings * fix: typings * fix: should not generate mf remotes runtime when remotes is empty * chore: remote wrong comment * feat: add chunk matcher for mf * fix: mf binding typings * chore: remove debug print statements * docs: update moduleFederation configuration docs * fix: mf config docs * chore: update CONTRIBUTING.md * release: @umijs/mako@0.11.5 * chore: update CHANGELOG.md and versions * feat: support to disable camel2DashComponentName of transformImport (#1773) * feat: support to disable camel2DashComponentName of transformImport * fix: typings * fix: 修复sass/less-loader的路径解析 (#1771) * fix: 支持webpack中sass-loader的路径解析 * chore: 调整目录 * chore: 移除注释等 * chore: 引入loader-runner * chore: sass-loader * chore: 修改loader返回空值处理 * test: 设置loader resolver的别名 * chore: update lock * fix: loader options * refactor: 提取插件代码 * fix: getResolve * fix: 修复runLoaders中的错误处理逻辑 * release: @umijs/mako@0.11.6 * fix: pnpm-lock * chore: update changelog for v0.11.6 * chore: update changelog for v0.11.6 * chore: update changelog for v0.11.6 * fix: watch less and sass dependencies (#1779) * chore: stash * chore: stash * feat: LessModuleGraph * feat: less-import-plugin * chore: 删除多余代码 * fix: 兼容url() * chore: plugin * feat: add beforeRebuild hook * ci: clippy format * fix: paths去重 * fix: rename _path * chore: rust层增加临时过滤文件方式 * chore: 提取createParallelLoader * refactor: before_rebuild hook (#1785) * refactor: before_rebuild hook -n * fix: typos * feat: postcss-loader (#1787) * feat: 支持postcss-loader * chore: 合并postcss到options传给render * chore: 更新.gitignore以排除less.postcss的node_modules目录 * feat: 添加PostCSS插件支持并更新相关类型定义 * refactor: 简化Less和Sass插件中的选项传递 * docs: 添加postcss支持的配置说明 * feat: 添加对PostCSS的支持，更新相关插件以集成postLoaders * feat: 更新Less和Sass插件以移除postLoaders，增强PostCSS支持 * test: 补充postcss测试用例 * fix: use transpiled hmr runtime (#1813) * fix: use transpiled hmr runtime (#1814) * release: @umijs/mako@0.11.7 * fix: package-lock.json * fix: use transpiled hmr runtime entry (#1815) * fix: disable parallel sassLoader because sassOptions.function cann't be shared cross workers (#1816) * release: @umijs/mako@0.11.8 * fix: package-lock.json * fix: package-lock.json * fix: typos * chore: update changelog for v0.11.8 * fix: less,sass,postcss loader panic (#1818) * release: @umijs/mako@0.11.9 * fix: package-lock.json * chore: update changelog for v0.11.9 * fix: worker threads panic on linux (#1823) * release: @umijs/mako@0.11.10 * fix: package-lock.json * chore: update changelog for v0.11.10 * fix: dev支持inline-source-map (#1859) Co-authored-by: dongqing.mdq <dongqing.mdq@antgroup.com> * release: @umijs/mako@0.11.11 * fix: package-lock.json * chore: update changelog for v0.11.11 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * fix: less resolve alias (#1906) * docs: update README.md (#1907) * Update README.md * Apply suggestions from code review Co-authored-by: Peach <scdzwyxst@gmail.com> * Update README.md * Update README.md --------- Co-authored-by: Peach <scdzwyxst@gmail.com> * Update README.md * Update README.md * release: @umijs/mako@0.11.12 * feat: update pnpm log * chore: update changelog for v0.11.12 * fix: panic on docker linux (#1909) * doc: add openomy (#1910) * release: @umijs/mako@0.11.13 * chore: update changelog for v0.11.13 * chore: remove codecov * chore: update examples/multiple-entries-heavy * feat: support inline-source-map devtool option (#1965) Co-authored-by: hanzebang.hzb <hanzebang.hzb@antgroup.com> * chore: truncate old codes --------- Co-authored-by: pshu <pishu.spf@antfin.com> Co-authored-by: chencheng (云谦) <sorrycc@gmail.com> Co-authored-by: Jinbao1001 <nodewebli@gmail.com> Co-authored-by: money <hualigushi@163.com> Co-authored-by: eisonhower <why490078184@gmail.com> Co-authored-by: huanyu.why <huanyu.why@antgroup.com> Co-authored-by: PeachScript <scdzwyxst@gmail.com> Co-authored-by: Wu-kung <1434246346@qq.com> Co-authored-by: 聪小陈 <xiaohuoni@users.noreply.github.com> Co-authored-by: akitaSummer <akitasummer@outlook.com> Co-authored-by: Shi Kuan <shikuan1992@gmail.com> Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com> Co-authored-by: yezao <75713784+yezaoshu@users.noreply.github.com> Co-authored-by: 御风 <18012261618@126.com> Co-authored-by: bqxbqx <132878537+BQXBQX@users.noreply.github.com> Co-authored-by: miaodongqing <dongqing_miao@163.com> Co-authored-by: dongqing.mdq <dongqing.mdq@antgroup.com> Co-authored-by: kiner-tang（星河） <1127031143@qq.com> Co-authored-by: hanzebang <46307343+hanzebang@users.noreply.github.com> Co-authored-by: hanzebang.hzb <hanzebang.hzb@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
新功能
collect_explicit_prop，扩展了树摇插件的功能。IdExplicitPropAccessCollector结构体，用于分析 JavaScript 代码中的显式属性访问。shouldKeep1、shouldKeep2和shouldNotKeep。transform_js方法，以支持新的树摇配置。测试
expect.js，验证树摇功能的正确性。mako.config.json，设置模块连接选项。