Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Reduce number of config file requests to HuggingFace #12797

Merged
merged 4 commits into from
Feb 6, 2025
Merged

[misc] Reduce number of config file requests to HuggingFace #12797

merged 4 commits into from
Feb 6, 2025

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Feb 6, 2025 •
edited
Loading

Every time _get_encoder_config is called, get_sentence_transformer_tokenizer_config also gets called and that triggers 7 different calls to HF to check whether any sentence transformer config file exists in the repo. This is more calls than needed and sometimes lead to timeout/connection issue in CI. This PR is a temporary fix to list files in the repo and use it once instead of checking each file. There should be another fix to only call this if the model is a sentence-transformers one.

p
506c3b1 
Signed-off-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

EC2 Default User added 2 commits February 6, 2025 00:49
p
d414008 
Signed-off-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
p
692d1b6 
Signed-off-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>

Signed-off-by:  <>
@khluu khluu changed the title [draft][misc] Fix HF calls [misc] Reduce number of config file requests to HuggingFace Feb 6, 2025
ywang96
ywang96 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much appreciate this temporary fix - this should help our CI a lot!

@DarkLight1337
Copy link
Member

Hmm the Helm test is failing, can you fix it?

@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 6, 2025
p
5d851aa 
Signed-off-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>

Signed-off-by:  <>
@khluu khluu enabled auto-merge (squash) February 6, 2025 08:25
maxdebayser
maxdebayser reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement. LGTM

@khluu khluu merged commit e152f29 into main Feb 6, 2025
72 checks passed
@khluu khluu deleted the khluu/fix_hf_calls branch February 6, 2025 14:59
fxmarty-amd pushed a commit to fxmarty-amd/vllm that referenced this pull request Feb 7, 2025
@khluu @fxmarty-amd
[misc] Reduce number of config file requests to HuggingFace (vllm-pro…
0d2973b 
…ject#12797)

Signed-off-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Signed-off-by: Felix Marty <felmarty@amd.com>
AoyuQC pushed a commit to AoyuQC/vllm that referenced this pull request Feb 8, 2025
@khluu @AoyuQC
[misc] Reduce number of config file requests to HuggingFace (vllm-pro…
390cb7e 
…ject#12797)

Signed-off-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
@khluu @ShangmingCai
[misc] Reduce number of config file requests to HuggingFace (vllm-pro…
dd9cae1 
…ject#12797)

Signed-off-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
@khluu @panf2333
[misc] Reduce number of config file requests to HuggingFace (vllm-pro…
fd0403f 
…ject#12797)

Signed-off-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
@khluu @kerthcet
[misc] Reduce number of config file requests to HuggingFace (vllm-pro…
e691a9d 
…ject#12797)

Signed-off-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxdebayser maxdebayser maxdebayser approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 ywang96 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khluu @DarkLight1337 @maxdebayser @ywang96