[ShazamKit] Updates Xcode13 beta1 #12189

tj-devel709 · 2021-07-23T00:15:46Z

I am hitting this test failure running Intro locally on iOS and I am not sure how to handle this

src/shazamkit.cs

vs-mobiletools-engineering-service2 · 2021-07-23T05:58:28Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

5 tests failed, 87 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2489 Inconclusive: 35 Failed: 4 Ignored: 136)
link sdk/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 129 Passed: 105 Inconclusive: 6 Failed: 1 Ignored: 23)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 92812fa into 7dd7960

rolfbjarne · 2021-07-23T07:51:28Z

tests/xtro-sharpie/common-ShazamKit.ignore

+!missing-selector! +SHMediaItem::fetchMediaItemWithShazamID:completionHandler: not bound
+!missing-selector! +SHMediaItem::mediaItemWithProperties: not bound
+!missing-selector! +SHMediaLibrary::defaultLibrary not bound
+!missing-selector! +SHSignature::signatureWithDataRepresentation:error: not bound


Nit: missing end-of-line

please file an issue/feedback with Apple
+SHMediaLibrary::defaultLibrary is a common pattern and only make sense if it's static

src/shazamkit.cs

rolfbjarne · 2021-07-23T08:02:48Z

I think @mandel-macaque had a similar intro test failure, but I don't remember what the solution was.

spouliot

Intro failure wrt SHCatalog is likely because it's an abstract base class
https://developer.apple.com/documentation/shazamkit/shcatalog?changes=_4&language=objc

src/shazamkit.cs

spouliot · 2021-07-23T14:37:10Z

tests/xtro-sharpie/common-ShazamKit.ignore

+!missing-selector! +SHMediaItem::fetchMediaItemWithShazamID:completionHandler: not bound
+!missing-selector! +SHMediaItem::mediaItemWithProperties: not bound
+!missing-selector! +SHMediaLibrary::defaultLibrary not bound
+!missing-selector! +SHSignature::signatureWithDataRepresentation:error: not bound


please file an issue/feedback with Apple
+SHMediaLibrary::defaultLibrary is a common pattern and only make sense if it's static

mandel-macaque

Small fixes.

src/shazamkit.cs

vs-mobiletools-engineering-service2 · 2021-07-24T03:11:25Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

5 tests failed, 87 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2486 Inconclusive: 35 Failed: 2 Ignored: 141)
Xtro/Mac: Failed (Test run failed.)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 0003b4a into 62a9fd9

vs-mobiletools-engineering-service2 · 2021-07-30T05:15:54Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

5 tests failed, 87 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 138)
Xtro/Mac: Failed (Test run failed.)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1103.BigSur'
Merge 59232d9 into 448cc6e

…3-ShazamKit-beta1

src/shazamkit.cs

tests/introspection/ApiSelectorTest.cs

vs-mobiletools-engineering-service2 · 2021-08-05T05:39:49Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 91 tests passed.

Failed tests

Xtro/Mac: Failed (Test run failed.)
introspection/iOS Unified 64-bits - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge dc06158 into fa5f323

vs-mobiletools-engineering-service2 · 2021-08-05T11:33:28Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

11 tests failed, 82 tests passed.

Failed tests

introspection/Mac Modern/Debug: BuildFailure
introspection/Mac Catalyst/Debug [dotnet]: BuildFailure
introspection/Mac Catalyst/Debug: BuildFailure
introspection/iOS Unified 64-bits - simulator/Debug: BuildFailure
introspection/tvOS - simulator/Debug: BuildFailure
introspection/watchOS 32-bits - simulator/Debug: BuildFailure
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): BuildFailure
introspection/tvOS - simulator/Debug (tvOS 11.4): BuildFailure
introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): BuildFailure
monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2638 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 147)
Xtro/Mac: Failed (Test run failed.)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge e7b0874 into 818198b

mandel-macaque

Conflicts need to be fixed.

…3-ShazamKit-beta1

vs-mobiletools-engineering-service2 · 2021-08-10T00:18:41Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

11 tests failed, 84 tests passed.

Failed tests

introspection/Mac Modern/Debug: BuildFailure
introspection/Mac Catalyst/Debug [dotnet]: BuildFailure
introspection/Mac Catalyst/Debug: BuildFailure
introspection/iOS Unified 64-bits - simulator/Debug: BuildFailure
introspection/tvOS - simulator/Debug: BuildFailure
introspection/watchOS 32-bits - simulator/Debug: BuildFailure
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): BuildFailure
introspection/tvOS - simulator/Debug (tvOS 11.4): BuildFailure
introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): BuildFailure
monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2638 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 148)
Xtro/Mac: Failed (Test run failed.)

Pipeline on Agent XAMBOT-1099.BigSur'
Merge 3b1d577 into 9307052

mandel-macaque · 2021-08-10T19:38:59Z

tests/introspection/ApiSelectorTest.cs

@@ -840,12 +840,14 @@ protected virtual bool Skip (Type type, string selectorName)
 				if (selectorName == "waitUntilExit")
 					return true;
 				break;
+#if !__MACOS__


If this is just on iOS, this is not the correct file, it should be in tests/introspection/iOS/iOSApiSelectorTest.cs

I believe that it was having issues with TV and Watch simulators as well

watchOS and tv will go in the iOS entry since they are generated from it.

vs-mobiletools-engineering-service2 · 2021-08-10T23:56:11Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 92 tests passed.

Failed tests

introspection/Mac Modern/Debug: BuildFailure
introspection/iOS Unified 64-bits - simulator/Debug: Failed
Xtro/Mac: Failed (Test run failed.)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 2960e20 into 300fc28

tj-devel709 · 2021-08-11T18:04:00Z

I think @mandel-macaque had a similar intro test failure, but I don't remember what the solution was.

@mandel-macaque Does the intro failure at the very top of this PR look familiar to you?

mandel-macaque · 2021-08-11T19:16:19Z

@tj-devel709 if we are talking about:

VerifyClassPtr: class_ptr and RegisterAttribute are different: SHCatalog

The fix is to just run it the device and not the simulator, on the device you will have no issues. Have you ran the tests on a device before pushing to the branch?

vs-mobiletools-engineering-service2 · 2021-08-12T00:27:19Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 95 tests passed.

Failed tests

xcframework-test/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)
introspection/iOS Unified 64-bits - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1094.BigSur
Merge 9d43b29 into 2972e1b

tools/common/Frameworks.cs

vs-mobiletools-engineering-service2 · 2021-08-13T02:27:27Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 97 tests passed 🎉

Pipeline on Agent XAMBOT-1100.BigSur'
Merge f51f4d6 into 2b1a5c1

vs-mobiletools-engineering-service2 · 2021-08-13T22:37:09Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 100 tests passed 🎉

Pipeline on Agent XAMBOT-1102.BigSur'
Merge 0b79901 into d173db1

vs-mobiletools-engineering-service2 · 2021-08-16T11:21:41Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 105 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur'
Merge acb7bf4 into 77a838a

spouliot · 2021-08-16T15:56:24Z

src/shazamkit.cs

+		bool Write (NSUrl url, [NullAllowed] out NSError error);
+
+		[Static]
+		[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0)]


^ that's a (incomplete) duplicate of the attributes on the type

Good catch! Removing now!

vs-mobiletools-engineering-service2 · 2021-08-16T22:53:08Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 104 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2638 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 148)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge a8c1bc2 into 454831f

tj-devel709 · 2021-08-17T16:02:31Z

Unrelated test failue: https://github.com/xamarin/maccore/issues/2443

tj_devel709 added 3 commits July 22, 2021 15:48

initial changes

88b1f61

forgot a comma

f4aefd2

adding common ignore and new framework locations

92812fa

tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jul 23, 2021

tj-devel709 added this to the xcode13.0 milestone Jul 23, 2021

tj-devel709 requested review from rolfbjarne and spouliot as code owners July 23, 2021 00:15

tj-devel709 commented Jul 23, 2021

View reviewed changes

src/shazamkit.cs Show resolved Hide resolved

rolfbjarne requested changes Jul 23, 2021

View reviewed changes

spouliot suggested changes Jul 23, 2021

View reviewed changes

fixing capitalization and adding DisableDefaultConstructor

7ec97c4

mandel-macaque requested changes Jul 23, 2021

View reviewed changes

src/shazamkit.cs Outdated Show resolved Hide resolved

src/shazamkit.cs Show resolved Hide resolved

newlines in attributes

0003b4a

Merge branch 'main' into Xcode13-ShazamKit-beta1

59232d9

tj_devel709 added 3 commits August 4, 2021 12:58

Merge remote-tracking branch 'xamarin/main' into Xcode13-ShazamKit-beta1

db776fb

run tests on device only

c25ee39

Merge remote-tracking branch 'TJ/Xcode13-ShazamKit-beta1' into Xcode1…

dc06158

…3-ShazamKit-beta1

mandel-macaque requested changes Aug 5, 2021

View reviewed changes

tj_devel709 and others added 2 commits August 5, 2021 00:59

name changes and checking for simulator

d1eb2f6

Merge branch 'main' into Xcode13-ShazamKit-beta1

e7b0874

mandel-macaque approved these changes Aug 6, 2021

View reviewed changes

tj_devel709 added 2 commits August 9, 2021 12:31

Merge remote-tracking branch 'xamarin/main' into Xcode13-ShazamKit-beta1

5cff855

forgot unavailable for swift

5aff644

tj_devel709 added 2 commits August 9, 2021 12:34

Merge remote-tracking branch 'TJ/Xcode13-ShazamKit-beta1' into Xcode1…

d369c6f

…3-ShazamKit-beta1

removing decoration

3b1d577

syntax

2960e20

mandel-macaque requested changes Aug 10, 2021

View reviewed changes

tj_devel709 added 3 commits August 11, 2021 13:10

wrong line and adding in default constructor

96eb3ff

Merge remote-tracking branch 'xamarin/main' into Xcode13-ShazamKit-beta1

956b8a9

alphabetical

9d43b29

fixing tests

f51f4d6

mandel-macaque requested changes Aug 13, 2021

View reviewed changes

tools/common/Frameworks.cs Outdated Show resolved Hide resolved

tools/common/Frameworks.cs Outdated Show resolved Hide resolved

tools/common/Frameworks.cs Outdated Show resolved Hide resolved

tj_devel709 added 2 commits August 13, 2021 11:14

Adding Simulator only in Frameworks.cs

0b79901

Merge remote-tracking branch 'xamarin/main' into Xcode13-ShazamKit-beta1

acb7bf4

rolfbjarne approved these changes Aug 16, 2021

View reviewed changes

dalexsoto approved these changes Aug 16, 2021

View reviewed changes

mandel-macaque approved these changes Aug 16, 2021

View reviewed changes

spouliot approved these changes Aug 16, 2021

View reviewed changes

removing unnecessary attributes

a8c1bc2

tj-devel709 merged commit 264eaba into xamarin:main Aug 17, 2021

[ShazamKit] Updates Xcode13 beta1 #12189

[ShazamKit] Updates Xcode13 beta1 #12189

Conversation

tj-devel709 commented Jul 23, 2021

vs-mobiletools-engineering-service2 commented Jul 23, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rolfbjarne commented Jul 23, 2021

spouliot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mandel-macaque left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jul 24, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Jul 30, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Aug 5, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Aug 5, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

mandel-macaque left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 10, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 10, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

tj-devel709 commented Aug 11, 2021

mandel-macaque commented Aug 11, 2021

vs-mobiletools-engineering-service2 commented Aug 12, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Aug 13, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages