#7095 - bumping minimum PHP version requirement to 5.4.0 #7119
Conversation
Ocramius
changed the title
|
Note that more PHP 5.3 references need to be found (here and in the documentation) before this PR can be merged. |
|
@Ocramius need rebase |
Ocramius
force-pushed
the
cleanup/#7095-php-5.3-support-end
branch
from
f43c232 to
3c0484b
Compare
|
@samsonasik rebased, thanks for the poke. |
|
travis build failures, not related with this pr ? |
|
@samsonasik that's probably due to #7108 - I will have to revert it |
| if (version_compare(PHP_VERSION, '5.4.0rc1', '<=')) { | ||
| $this->markTestSkipped('Requires PHP 5.4'); | ||
| } | ||
|
|
||
| $handler = new CallbackHandler('ZendTest\\Stdlib\\SignalHandlers\\InstanceMethod::staticHandler'); |
There was a problem hiding this comment.
@stefanotorresi I was thinking that we could drop support for this sort of callback in future: I don't see why consumers cannot use ['ZendTest\\Stdlib\\SignalHandlers\\InstanceMethod', 'staticHandler'] here.
There was a problem hiding this comment.
hmm, I guess the point was that anything that is good enough for is_callable should be accepted, and that makes sense.
but yeah, we could add a @todo for zf3.
…compatibility is dropped
…compatibility is dropped
…3 compatibility is dropped
…ktrace()` constants
…ble since PHP 5.4
|
@carnage I created Ocramius#6 for that ;) |
remove $self = $this; use ($self) in 5.4
| 'JsonSerializable' | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
@Ocramius this interface ( library/Zend/Stdlib/JsonSerializable.php ) can be completely removed ?
There was a problem hiding this comment.
No, because that would be a major BC break, and especially for an interface.
|
Bonus: PHP 5.3 seems to make the builds fail ATM https://travis-ci.org/zendframework/zf2/jobs/46916503 (PHP 5.4 is much more memory-efficient :P ) |
|
We'll be supporting PHP 5.3 for ZF 2.4 -- which we will mark as a Long Term Support release; this way, developers who must stay on 5.3 know they have a supported version until they can upgrade. After 2.4 is released, we will start supporting PHP 5.5 as the minimum required PHP version. |
| @@ -19,6 +19,8 @@ DD MMM YYY | |||
|
|
|||
| ### UPDATES IN 2.4.0 | |||
|
|
|||
| - [#7095](https://github.com/zendframework/zf2/issues/7095) drops support for | |||
| PHP 5.3 | |||
There was a problem hiding this comment.
need to be moved to 2.5.0 ? /cc @weierophinney
|
@weierophinney did you mean that start 2.5.0, it will require php 5.5 ? @Ocramius need update PR title ? Need to include php 5.5 feature too? |
|
@samsonasik I'm honestly just waiting for mwop on this |
|
@samsonasik I'm not saying 2.5 for PHP 5.5 at this time, as we're still debating whether there will be a ZF 2.5 release at this point. Immediately after 2.4 is released, we will begin moving all components into their own repositories. Unlike the semi-automated component repos we have now, these will have full history, and contain unit tests, CI configuration and integration, coding standards configuration, etc. As each repo is ported completely, we will update the minimum supported PHP version to 5.5, and then tag each at version 2.5.0. What is undecided yet is whether or not we will tag a ZF2 2.5.0 release once all repos are ported over. @Ocramius is the primary proponent of a 2.5.0 release of the framework itself (which, at that point, would be the first release with the ZF package being essentially just a metapackage), but he and I have not been able to connect in recent weeks to discuss pros and cons. |
|
2.5 will be >=PHP 5.5 |
|
Done with 1a10163, and all component repositories bump to PHP 5.5 starting with their 2.5.0 releases. |
|
I prefer to keep this open as a base reference of changes to do in components |
|
pr for changes in zend-stdlib zendframework/zend-stdlib#7 |
|
pr for changes in zend-code zendframework/zend-code#2 |
|
pr for changes in zend-xmlrpc zendframework/zend-xmlrpc#2 |
|
pr for changes in zend-escaper zendframework/zend-escaper#1 |
|
pr for changes in zend-log zendframework/zend-log#1 |
|
pr for changes in zend-servicemanager zendframework/zend-servicemanager#3 |
|
pr for changes in zend-eventmanager zendframework/zend-eventmanager#3 |
|
pr for changes in zend-cache zendframework/zend-cache#1 |
|
pr for changes in zend-authentication zendframework/zend-authentication#3 |
Linking #7095