-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Connect: Add REST fallback for connect endpoints #7740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and tests pretty well.
@gravityrail - we may need some small adjustments server-side. But i think this approach makes sense, and I'd be fine merging it into Jetpack.
@@ -344,6 +356,48 @@ public static function delete_jitm_message( $request ) { | |||
} | |||
|
|||
/** | |||
* Handles verification that a site is registered | |||
* | |||
* @since 4.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be at least 5.3, no? :)
642f95a
to
41ee047
Compare
41ee047
to
e902357
Compare
* initial commit for running changelog * Update stable tag in readme * Changelog: move old releases to changelog.txt. Also add release post URL for 5.4 * Changelog: add #7729 * Changelog: add #7736 * Changelog: add #7737 * Changelog: add #7740 * Changelog: add #7742 * Changelog: add #7366 * Changelog: add #7664 * Changelog: add #7751 * Changelog: add #7764 * Changelog: add #7768 * Changelog: add #7796 * Changelog: add #7798 * Changelog: add #7822 * Changelog: add #7824 * Changelog: add #7825 * Changelog: add #7826 * Changelog: add #7829 * Changelog: add #7831 * Changelog: add #7837 * Changelog: add #7850 * Changelog: add #7852 * Changelog: add #6538 * Changelog: add #7767 * Changelog: add #7782 * Changelog: add #7797 * Changelog: add #7819 * update to-test to add misc stuff * add comment edit fix to changelog
* initial commit for running changelog * Update stable tag in readme * Changelog: move old releases to changelog.txt. Also add release post URL for 5.4 * Changelog: add #7729 * Changelog: add #7736 * Changelog: add #7737 * Changelog: add #7740 * Changelog: add #7742 * Changelog: add #7366 * Changelog: add #7664 * Changelog: add #7751 * Changelog: add #7764 * Changelog: add #7768 * Changelog: add #7796 * Changelog: add #7798 * Changelog: add #7822 * Changelog: add #7824 * Changelog: add #7825 * Changelog: add #7826 * Changelog: add #7829 * Changelog: add #7831 * Changelog: add #7837 * Changelog: add #7850 * Changelog: add #7852 * Changelog: add #6538 * Changelog: add #7767 * Changelog: add #7782 * Changelog: add #7797 * Changelog: add #7819 * update to-test to add misc stuff * add comment edit fix to changelog
If sites have XMLRPC blocked for security reasons, Jetpack will fail to connect.
This PR adds REST versions of the two most critical XMLRPC methods so that we can still connect, even though other things will also fail. This at least allows us to get users started with Jetpack so that we can help them make their site compatible.
To test:
Here's a screenshot of ngrok logged requets during Jetpack Connect.