Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Connect: Add REST fallback for connect endpoints #7740

Merged
merged 2 commits into from
Sep 6, 2017

Conversation

gravityrail
Copy link
Contributor

@gravityrail gravityrail commented Sep 4, 2017

If sites have XMLRPC blocked for security reasons, Jetpack will fail to connect.

This PR adds REST versions of the two most critical XMLRPC methods so that we can still connect, even though other things will also fail. This at least allows us to get users started with Jetpack so that we can help them make their site compatible.

To test:

  • Block XMLRPC on your server like this (nginx example):
    location = /xmlrpc.php {
        deny all;
        access_log off;
        log_not_found off;
    }
  • Attempt to connect
  • You should be able to connect! But things like auto-installing VaultPress/Akismet will fail later.

Here's a screenshot of ngrok logged requets during Jetpack Connect.

ngrok-requests

@gravityrail gravityrail requested a review from a team as a code owner September 4, 2017 17:12
@gravityrail gravityrail added this to the 5.4 milestone Sep 4, 2017
@gravityrail gravityrail self-assigned this Sep 4, 2017
Copy link
Member

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and tests pretty well.

@gravityrail - we may need some small adjustments server-side. But i think this approach makes sense, and I'd be fine merging it into Jetpack.

@@ -344,6 +356,48 @@ public static function delete_jitm_message( $request ) {
}

/**
* Handles verification that a site is registered
*
* @since 4.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be at least 5.3, no? :)

@gravityrail gravityrail force-pushed the try/add-rest-connect-endpoints branch from 41ee047 to e902357 Compare September 6, 2017 17:46
@gravityrail gravityrail merged commit 4777df6 into master Sep 6, 2017
@gravityrail gravityrail deleted the try/add-rest-connect-endpoints branch September 6, 2017 19:11
@jeherve jeherve added [Status] Has Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release and removed [Status] Needs Changelog labels Sep 26, 2017
jeherve added a commit that referenced this pull request Sep 26, 2017
dereksmart added a commit that referenced this pull request Sep 26, 2017
* initial commit for running changelog

* Update stable tag in readme

* Changelog: move old releases to changelog.txt.

Also add release post URL for 5.4

* Changelog: add #7729

* Changelog: add #7736

* Changelog: add #7737

* Changelog: add #7740

* Changelog: add #7742

* Changelog: add #7366

* Changelog: add #7664

* Changelog: add #7751

* Changelog: add #7764

* Changelog: add #7768

* Changelog: add #7796

* Changelog: add #7798

* Changelog: add #7822

* Changelog: add #7824

* Changelog: add #7825

* Changelog: add #7826

* Changelog: add #7829

* Changelog: add #7831

* Changelog: add #7837

* Changelog: add #7850

* Changelog: add #7852

* Changelog: add #6538

* Changelog: add #7767

* Changelog: add #7782

* Changelog: add #7797

* Changelog: add #7819

* update to-test to add misc stuff

* add comment edit fix to changelog
dereksmart added a commit that referenced this pull request Sep 26, 2017
* initial commit for running changelog

* Update stable tag in readme

* Changelog: move old releases to changelog.txt.

Also add release post URL for 5.4

* Changelog: add #7729

* Changelog: add #7736

* Changelog: add #7737

* Changelog: add #7740

* Changelog: add #7742

* Changelog: add #7366

* Changelog: add #7664

* Changelog: add #7751

* Changelog: add #7764

* Changelog: add #7768

* Changelog: add #7796

* Changelog: add #7798

* Changelog: add #7822

* Changelog: add #7824

* Changelog: add #7825

* Changelog: add #7826

* Changelog: add #7829

* Changelog: add #7831

* Changelog: add #7837

* Changelog: add #7850

* Changelog: add #7852

* Changelog: add #6538

* Changelog: add #7767

* Changelog: add #7782

* Changelog: add #7797

* Changelog: add #7819

* update to-test to add misc stuff

* add comment edit fix to changelog
@jeherve jeherve removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants