-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix escaped html in option description on "Configure Site Stats" page #7798
Merged
jeherve
merged 1 commit into
Automattic:master
from
rclations:update/stats-page-option-description
Sep 20, 2017
Merged
Fix escaped html in option description on "Configure Site Stats" page #7798
jeherve
merged 1 commit into
Automattic:master
from
rclations:update/stats-page-option-description
Sep 20, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereksmart
approved these changes
Sep 20, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jeherve
approved these changes
Sep 20, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. Merging.
dereksmart
added a commit
that referenced
this pull request
Sep 26, 2017
* initial commit for running changelog * Update stable tag in readme * Changelog: move old releases to changelog.txt. Also add release post URL for 5.4 * Changelog: add #7729 * Changelog: add #7736 * Changelog: add #7737 * Changelog: add #7740 * Changelog: add #7742 * Changelog: add #7366 * Changelog: add #7664 * Changelog: add #7751 * Changelog: add #7764 * Changelog: add #7768 * Changelog: add #7796 * Changelog: add #7798 * Changelog: add #7822 * Changelog: add #7824 * Changelog: add #7825 * Changelog: add #7826 * Changelog: add #7829 * Changelog: add #7831 * Changelog: add #7837 * Changelog: add #7850 * Changelog: add #7852 * Changelog: add #6538 * Changelog: add #7767 * Changelog: add #7782 * Changelog: add #7797 * Changelog: add #7819 * update to-test to add misc stuff * add comment edit fix to changelog
dereksmart
added a commit
that referenced
this pull request
Sep 26, 2017
* initial commit for running changelog * Update stable tag in readme * Changelog: move old releases to changelog.txt. Also add release post URL for 5.4 * Changelog: add #7729 * Changelog: add #7736 * Changelog: add #7737 * Changelog: add #7740 * Changelog: add #7742 * Changelog: add #7366 * Changelog: add #7664 * Changelog: add #7751 * Changelog: add #7764 * Changelog: add #7768 * Changelog: add #7796 * Changelog: add #7798 * Changelog: add #7822 * Changelog: add #7824 * Changelog: add #7825 * Changelog: add #7826 * Changelog: add #7829 * Changelog: add #7831 * Changelog: add #7837 * Changelog: add #7850 * Changelog: add #7852 * Changelog: add #6538 * Changelog: add #7767 * Changelog: add #7782 * Changelog: add #7797 * Changelog: add #7819 * update to-test to add misc stuff * add comment edit fix to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Stats Data
Feature that enables users to track their site's traffic and gain insights on popular content.
[Type] Bug
When a feature is broken and / or not performing as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7141
Changes proposed in this Pull Request:
esc_html_e()
towp_kses( __() )
to allow<strong>
tag output without escaping.Testing instructions:
/wp-admin/admin.php?page=jetpack&configure=stats#/
). The description for the Smiley field checkbox contains an escaped<strong>
tag in the description.<strong>
tag.