Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating card spacing method for ie11 compatibility #7797

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

rclations
Copy link
Contributor

Fixes #7134

Changes proposed in this Pull Request:

  • Update the display property to resolve IE11 display issues, and switch from margin to padding to retain the spacing intended in the original commit.

Testing instructions:

  • Using browserstack to emulate IE11, visit the module settings page of a jetpack site (/wp-admin/admin.php?page=jetpack#/settings). Without this patch, all card content should be pushed to the left (as seen in Admin page: Problems with IE11 #7134).

@rclations rclations requested a review from a team as a code owner September 17, 2017 14:22
@dereksmart dereksmart added [Status] Needs Design Review Design has been added. Needs a review! [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended Admin Page React-powered dashboard under the Jetpack menu labels Sep 20, 2017
@dereksmart
Copy link
Member

Confirms this fixes it

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 26, 2017
@dereksmart dereksmart merged commit 258c856 into Automattic:master Sep 26, 2017
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 26, 2017
jeherve added a commit that referenced this pull request Sep 26, 2017
dereksmart added a commit that referenced this pull request Sep 26, 2017
* initial commit for running changelog

* Update stable tag in readme

* Changelog: move old releases to changelog.txt.

Also add release post URL for 5.4

* Changelog: add #7729

* Changelog: add #7736

* Changelog: add #7737

* Changelog: add #7740

* Changelog: add #7742

* Changelog: add #7366

* Changelog: add #7664

* Changelog: add #7751

* Changelog: add #7764

* Changelog: add #7768

* Changelog: add #7796

* Changelog: add #7798

* Changelog: add #7822

* Changelog: add #7824

* Changelog: add #7825

* Changelog: add #7826

* Changelog: add #7829

* Changelog: add #7831

* Changelog: add #7837

* Changelog: add #7850

* Changelog: add #7852

* Changelog: add #6538

* Changelog: add #7767

* Changelog: add #7782

* Changelog: add #7797

* Changelog: add #7819

* update to-test to add misc stuff

* add comment edit fix to changelog
dereksmart added a commit that referenced this pull request Sep 26, 2017
* initial commit for running changelog

* Update stable tag in readme

* Changelog: move old releases to changelog.txt.

Also add release post URL for 5.4

* Changelog: add #7729

* Changelog: add #7736

* Changelog: add #7737

* Changelog: add #7740

* Changelog: add #7742

* Changelog: add #7366

* Changelog: add #7664

* Changelog: add #7751

* Changelog: add #7764

* Changelog: add #7768

* Changelog: add #7796

* Changelog: add #7798

* Changelog: add #7822

* Changelog: add #7824

* Changelog: add #7825

* Changelog: add #7826

* Changelog: add #7829

* Changelog: add #7831

* Changelog: add #7837

* Changelog: add #7850

* Changelog: add #7852

* Changelog: add #6538

* Changelog: add #7767

* Changelog: add #7782

* Changelog: add #7797

* Changelog: add #7819

* update to-test to add misc stuff

* add comment edit fix to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Design Review Design has been added. Needs a review! [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin page: Problems with IE11
3 participants