Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync: Add author to the published post sync action #7822

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Sync: Add author to the published post sync action #7822

merged 2 commits into from
Sep 26, 2017

Conversation

enejb
Copy link
Member

@enejb enejb commented Sep 20, 2017

Currently we might not have the complete author info when we publish a post don't have a good way to display the author info.

This PR adds the author infor we care about to the publish sync action so that we can use it in the activty log.

Part 1 in fixing the activity log.

Changes proposed in this Pull Request:

  • Adds author information to the activity log publish post action.

Testing instructions:

  • Do the tests pass?

Proposed changelog entry for your changes:

@enejb
Sync: Add author to the published post sync action
6e1fb86 
Currently we might not have the complete author info when we publish a post don't have a good way to display the author info.

This PR adds the author infor we care about to the publish sync action so that we can use it in the activty log.
@enejb enejb added [Feature] Activity Log [Package] Sync [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Team] Poseidon labels Sep 20, 2017
@enejb enejb self-assigned this Sep 20, 2017
@enejb enejb requested review from lezama and gititon September 20, 2017 16:34
@enejb enejb requested a review from a team as a code owner September 20, 2017 16:34
@jeherve
Copy link
Member

jeherve commented Sep 20, 2017

I believe this should fix #7749

@lezama
Copy link
Contributor

lezama commented Sep 25, 2017

Looks good to me 👍

@lezama lezama added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 25, 2017
@enejb enejb requested a review from roccotripaldi September 25, 2017 23:45
roccotripaldi
roccotripaldi approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works well. Thanks Enej.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 26, 2017
jeherve
jeherve approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@jeherve jeherve merged commit 5c1a607 into master Sep 26, 2017
@jeherve jeherve deleted the add/author-info-to-publish-event branch September 26, 2017 09:07
@jeherve jeherve added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Changelog labels Sep 26, 2017
jeherve added a commit that referenced this pull request Sep 26, 2017
@jeherve
Changelog: add #7822
f9124c4
dereksmart added a commit that referenced this pull request Sep 26, 2017
@dereksmart
5.4 Running changelog (#7748)
7dbfd70 
* initial commit for running changelog

* Update stable tag in readme

* Changelog: move old releases to changelog.txt.

Also add release post URL for 5.4

* Changelog: add #7729

* Changelog: add #7736

* Changelog: add #7737

* Changelog: add #7740

* Changelog: add #7742

* Changelog: add #7366

* Changelog: add #7664

* Changelog: add #7751

* Changelog: add #7764

* Changelog: add #7768

* Changelog: add #7796

* Changelog: add #7798

* Changelog: add #7822

* Changelog: add #7824

* Changelog: add #7825

* Changelog: add #7826

* Changelog: add #7829

* Changelog: add #7831

* Changelog: add #7837

* Changelog: add #7850

* Changelog: add #7852

* Changelog: add #6538

* Changelog: add #7767

* Changelog: add #7782

* Changelog: add #7797

* Changelog: add #7819

* update to-test to add misc stuff

* add comment edit fix to changelog
dereksmart added a commit that referenced this pull request Sep 26, 2017
@dereksmart
5.4 Running changelog (#7748)
c0b3ee2 
* initial commit for running changelog

* Update stable tag in readme

* Changelog: move old releases to changelog.txt.

Also add release post URL for 5.4

* Changelog: add #7729

* Changelog: add #7736

* Changelog: add #7737

* Changelog: add #7740

* Changelog: add #7742

* Changelog: add #7366

* Changelog: add #7664

* Changelog: add #7751

* Changelog: add #7764

* Changelog: add #7768

* Changelog: add #7796

* Changelog: add #7798

* Changelog: add #7822

* Changelog: add #7824

* Changelog: add #7825

* Changelog: add #7826

* Changelog: add #7829

* Changelog: add #7831

* Changelog: add #7837

* Changelog: add #7850

* Changelog: add #7852

* Changelog: add #6538

* Changelog: add #7767

* Changelog: add #7782

* Changelog: add #7797

* Changelog: add #7819

* update to-test to add misc stuff

* add comment edit fix to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezama lezama lezama approved these changes

@jeherve jeherve jeherve approved these changes

@roccotripaldi roccotripaldi roccotripaldi approved these changes

@gititon gititon Awaiting requested review from gititon

Assignees

@enejb enejb

Labels
[Feature] Activity Log [Package] Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enejb @jeherve @lezama @roccotripaldi