Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4614] Async GRB Discussions #2874

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

ClayBenson94
Copy link
Collaborator

@ClayBenson94 ClayBenson94 commented Nov 4, 2024

EASI-4614

Description

How to test this change

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@ClayBenson94 ClayBenson94 added the Feature Branch Used to track PRs that track feature branches going into main label Nov 4, 2024
* Add discussions to translation files index

* Plural i18n translations

* Typos
* initial discussions api schema and migration

* rename migration

* add new table to truncate lists

* formatting

* update postman, remove payload types, add constraint
* MentionTextArea
Tiptap lib

* DiscussionBoard folder
DiscussionModalWrapper
Sidepanel
* DiscussionReply component

* DiscussionsCard component

* Mock types and data

* DiscussionReply component layout

* Merge remote-tracking branch 'origin/EASI-4635/initial-discussions-api' into EASI-4636/discussions-response-component

* Add discussions to GRB review query

* Update component types

* Translations

* Relative date util function

* Discussions admin card

* Discussion board tips

* Rename component

* DiscussionPost unit test

* Empty discussions state

* Discussions unit tests

* Replace mock data with query data

* Responsive styling

* Role fallback text with unit test

* Update reply text and unit tests

* Add Discussions nav link

* Snapshot update

* Add `DiscussionBoard` to Discussions component

* Update DiscussionPost to handle replies

* Unit tests

* Removed snapshot

Snapshot would always be outdated because of "X days ago" text within component
* implement grb discussion store methods and attach to resolvers

* update method comments

* update postman for discussions

* Add functionality in db seed to allow easier user context creation, add discussions seed data, and update postman collection to return more information on GRB Discussion Posts/Replies

---------

Co-authored-by: ClayBenson94 <clay.benson@oddball.io>
* Merge discussions card work into branch

* Discussions panel view components

* Discussion post and reply mutations

* Basic discussion form

* Fix line height within side panel

* Display discussion and replies

* Discussions list view

* Threaded replies styling

* Show/hide replies

* DiscussionsList component

* Add DiscussionsList to Discussion view

* Add DiscussionsList to discussion board view

* Create discussion and reply mutations

* Discussion board list filtering

* ViewDiscussions unit tests

* Discussion component unit tests

* Success and error messages

* Feature branch merge conflict fix

* MentionTextArea in DiscussionForm (#2898)

* MentionTextArea in DiscussionForm

* Mention area height-auto

* Text

* Rhf-like signature

* .usa-textarea + overrides

* Cleanup

* MentionTextArea React.forwardRef

* Cleanup

* Fix render error when review has no discussions

* Hide replies if array is empty

---------

Co-authored-by: adamodd <97050498+adamodd@users.noreply.github.com>
* starting with schema types

* create type

* some extra types and methods

* add magic

* pull from mint, gql

* some cleanup, remove gql stuff that will be part of a different ticket

* testing dummy route to test out tag parsing

* remove what seemed to be extra sanitizations

* clean up test code, still working on things

* still testing, things looking good for ingestion

* integrating dummy with real

* cleanup similar struct

* update postman call

* add fields to postman call

* postman

* whoops - remove hardcoded sys intake id from postman

* update tag types

* remove unneeded

* fix lint

* update sanitization policy and use it

* leave classs as "mention" to match UI

* postman

* remove commented out item

* unused

* return only HTML, skip tags and extra types

* postman

* remove unused fields

* separate out tagged html policy

* s/eua/uuid

* remove extra fields

* only allow <span> and <p> tags for tagged html

* Update postman, remove TaggedContent, remove console.info

* return first err, update test file, fix some comments

* add additional request for group tag test

* naming

---------

Co-authored-by: ClayBenson94 <clay.benson@oddball.io>
…ng-discussion-notifications

[EASI-4675] Remove self-tagging emails and add tests for discussion emails
@CMS-Enterprise CMS-Enterprise deleted a comment from github-actions bot Dec 13, 2024
Copy link

EKS Ingress URLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eks_ignore Feature Branch Used to track PRs that track feature branches going into main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants