Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy progress / abstain UI fixes #501

Merged
merged 39 commits into from
Apr 18, 2022
Merged

Deploy progress / abstain UI fixes #501

merged 39 commits into from
Apr 18, 2022

Conversation

NoahSaso
Copy link
Member

@NoahSaso NoahSaso commented Apr 16, 2022 •
edited
Loading

sagarsaija and others added 30 commits March 21, 2022 15:28
@sagarsaija
Add utils package
b1ed24a
@sagarsaija
newline at the end of tsconfig.json
3ddc483
@sagarsaija
remove debugging console.log
8103b8a
@NoahSaso
Crispier toasts (#442)
79865c7 
* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.
@NoahSaso
Display executed proposal TX hashes with link to Mintscan (#441)
60182c9 
* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.
@NoahSaso
Improve proposal template UX (#440)
edd0ff1 
* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.
@JakeHartnell @NoahSaso
Update packages/utils/package.json
351a4ba 
Co-authored-by: Noah Saso <noahsaso@gmail.com>
@JakeHartnell
Merge pull request #438 from DA0-DA0/util-package
8046549 
Utils package
@jvanderen1
Add check for connected wallet (#452)
caf1809
@0xekez
Show second by second countdown when unstaking. (#456)
6c77efd
@ebaker
Icons package (#428)
81b0c71 
* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.
@jvanderen1
Added "Add Token" Button (#458)
b4b4076 
* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"
@0xekez
Fix formatting issue in Button.tsx. (#461)
e8d730e
@0xekez
Disable check for staked balance at proposal creation time. (#464)
5cfc7b8 
Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.
@0xekez
Allow voting abstain on proposals. (#454)
d8b6879
@0xekez
Use version number from package.json. (#455)
d474752
@0xekez @NoahSaso @JakeHartnell
Migrate away from Daisy UI and bring design closer to spec. (#457)
c65a28a 
* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
@0xekez
Merge branch 'main' into development
c7958f9
@sagarsaija
Persist description newlines on ContractView (#476)
5e79f09
@sashimi36
Reuse @cosmjs clients (#480)
89e1854 
* ChainClientRouter and its integration

* upd comment

* pr feedback
@0xekez
Make connect wallet and wallet display button same sizes. (#482)
129f8e4
feat(ui): update reach tooltip styles (#485)
8e950ff
@sagarsaija
Fix treasury typo (#488)
23fa762 
* Fix treasury typo

* lint
@0xekez
Update cosmJS dependency to reduce initial JS load size. (#479)
9f571e0 
Resolves #19.
@0xekez
Better display when user did not vote on proposal. (#478)
a5a816f
@0xekez @sagarsaija
@NoahSaso @JakeHartnell @jvanderen1 @ebaker
Swap positions of submit and preview in proposal form. (#477)
0095a35 
* Merge development into main! (#473)

* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Add missing daotoken image. (#474)

* Swap positions of submit and preview in proposal form.

Resolves #475

* fixup! correctly line wrap.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>
@baoskee
Better empty state for new users (#449)
78e5c9f 
* Empty state contract cards

* Hover animation

* Moved to components/

* Renamed Mystery to Empty cards
feat: improve eslint and prettier integration (#487)
612bf59
@NoahSaso
New proposal status UI (#489)
8590336
chore: format and lint all sources (#493)
0ad5dd2
@vercel
Copy link

vercel bot commented Apr 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao-dao ✅ Ready (Inspect) Visit Preview Apr 18, 2022 at 1:19AM (UTC)

@NoahSaso NoahSaso requested review from 0xekez and JakeHartnell April 16, 2022 03:05
@JakeHartnell
Copy link
Member

Not sure why so many commits... and only one file... 🤷‍♂️

NoahSaso added 2 commits April 17, 2022 11:12
@NoahSaso
Minor hindsight proposal status UI tweaks (#498)
e6a0c8d 
* Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars.

* Improved passing threshold indicator language to be less prescriptive.

* Added helpful status text for threshold and quorum cases for clarification purpses.
@NoahSaso
Only show time left when proposal is open.
72c9235
@NoahSaso NoahSaso marked this pull request as draft April 17, 2022 18:25
@NoahSaso
Copy link
Member Author

Not sure why so many commits... and only one file... 🤷‍♂️

It's because we squash and merge development into main but haven't been rebasing development from main after... which we probably don't want to do because we lose all history. We should probably start rebase + merging.

@NoahSaso
Fixes for abstain indicator clarity (#503)
b1cc11d 
* Fixes for abstain indicator clarity.

* Right align abstain in no quorum progress bar if only abstain votes have been cast so the text lines up.

* Fixed comment.
@NoahSaso NoahSaso marked this pull request as ready for review April 18, 2022 01:18
@NoahSaso
Copy link
Member Author

I'll squash and merge this for now so we don't spam main with commits, but we should fix the relationship between main and development so this doesn't keep happening.

@NoahSaso NoahSaso merged commit 32fc3f5 into main Apr 18, 2022
@NoahSaso NoahSaso changed the title Deploy UI Deploy progress / abstain UI fixes Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xekez 0xekez 0xekez approved these changes

@JakeHartnell JakeHartnell JakeHartnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@NoahSaso @JakeHartnell @0xekez @sagarsaija @jvanderen1 @ebaker @sashimi36 @baoskee