Merge from upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target net46 instead of net45
fix doc comment issues that prevented proper XML parsing
Remove value tuple 431 from VisualFSharpFull.vsix
…t sdk apps (#5152) * Update default fsharp.core to 4.5.0 and valuetuple to 4.4.0 for dotnet sdk apps * FCS
Update templates to FSharp.Core 4.5.0
* Pretify ConstrainsSolver method The method wasn't readable at all before now it's better. * applied review Signed-off-by: realvictorprm <mueller.vpr@gmail.com>
… illib (#5090) * replace List.chop with List.splitAt remove List.take from illib.fs * replace List.splitAt >> fst with List.take * use List.truncate instead of List.take * Revert "replace List.splitAt >> fst with List.take" This reverts commit c4f0605. * Revert "Revert "replace List.splitAt >> fst with List.take"" This reverts commit 2cb9693. * Revert "replace List.chop with List.splitAt" This reverts commit cde206b. # Conflicts: # src/fsharp/SignatureConformance.fs * remove List.take from illib.fs and replace its usages with List.truncate * Revert "remove List.take from illib.fs and replace its usages with List.truncate" This reverts commit 8a198b0. # Conflicts: # src/fsharp/DetupleArgs.fs * Revert "Revert "remove List.take from illib.fs and replace its usages with List.truncate"" This reverts commit 6722f08. * rollback accidental change
don't unconditionally deploy templates package; it can lock the build machines
* Use ordinal string comparison in string manipulation methods StartsWith, EndsWith, Compare, etc * Add StartsWithOrdinal, EndsWithOrdinal extension methods
…4662) * Do not check assembly symbols equality by DefinitionRange and name Assembly symbols have startup definition range and considered equal. Fixes #4658. * Add test for equality of entities from assemblies with the same name * Add checks for range0 and rangeCmdArgs ranges * Do not run new tests on netcoreapp2.0
…had Environment.NewLine line breaks. This would cause a unix-line ending source file to incorrectly be populated with CRLF when working under Windows. (#4487)
…ty to reduce resizing (#5089)
* Clean up references * System.Caching from nuget
WIP - Update SCI, SRM to the latest RTM
fix mono build/install
* Only compute suppressedMethNames if really needed * Use HashSet for addersAndRemovers * Only compute suppressedMethNames if really needed * move it to the right, sigh
* Started language service refactoring * Updated editor fsproj * Fixed service, should work
* Ensure that compiler path is set during Design Time build * both build types
* We only need to check for mangledGenericTypeNameSym once * ShortCut name checking * Reduce number of LastIndexOf calls * Reduce number of LastIndexOf calls * Reduce number of LastIndexOf calls * Incorporate feedback * Use PrettyNaming.DemangleGenericTypeName instead of ungenericizeTypeName * Remove couple of double checks * Update illib.fs
… a fresh clone (#5710)
* Remove old TryGetValue * Reduce use of TryFind * Reduce allocations in TcPatBindingName * Reduce some allocations in NameResolution * Reduce some allocations in TypeChecker * Use latest FSharp.Core in FCS * Update FSharp.Core in FCS
* Remove second internal ValueOption * Update FSharp.Core in FCS * Cleanup
* Do not use length if we can pattern match * Check field count only once
#5720) * Thanks to Don Syme, we have a fix * Added test
* Replacing short-lived options with ValueOption * Remove couple of allocations * Remove couple of allocations
* Fixed error message to be more direct. * update xlf
Explicitly mention that the optional components are found in the VS Installer, not somewhere on the downloads page (since that's what was linked just before)
* Attempt to fix linux build * Clean up
update yaml syntax to conform to new standards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.