This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Merge 8.x-1.× #626
Merged
Merge 8.x-1.× #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed codesniffer errors
Do not require to pass full OgRole objects when we only need the ID.
Avoid using "refresh" terminology since it implies that new data is being calculated. We are just populating the property.
Code example to add a group content type is not valid PHP
Uncaught Error: Cannot use object of type stdClass as array
We were using two separate permissions to handle these closely related subjects. We are going to follow the approach of Drupal core and use a single 'administer permissions' permission for both.
Replace deprecated EntityManager service with EntityTypeManager.
Test that an exception is thrown when a membership is saved using invalid roles
Co-Authored-By: Amitai Burstein <amitai@gizra.com>
…account-objects MembershipManager::createMembership() is accepting invalid account objects #540
…ndler Fix for #580.
…tion as the argument.
Added dependency injection for EntityTypeManager instead \Drupal calls
Remove unnecessary dependency injection
we may need to move this to an interface
550 Remove global constants
`User::load()` calls should be avoided in classes #546 fix
Remove deprecated sudo property
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.