Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReleasePrep][2024.07.02]RI of dev into main #10054

Merged
merged 40 commits into from
Jul 10, 2024
Merged

[ReleasePrep][2024.07.02]RI of dev into main #10054

merged 40 commits into from
Jul 10, 2024

Conversation

v-manil2
Copy link
Contributor

@v-manil2 v-manil2 commented Jul 2, 2024

No description provided.

drewgillies and others added 30 commits June 19, 2024 16:27
@drewgillies
Remove DMCA message from SR edit dialog (#10028)
bb44fb6
@SimonCropp
use Count instead of Where+Count (#10016)
9456c1c
@SimonCropp
remove redundant Wheres (#10017)
85bc8d2
@SimonCropp
fix Trucated typo (#9996)
786c36b
@SimonCropp
fix Varibles typo (#10005)
1721095
@SimonCropp
use Array.Empty where possible (#9999)
050496e
@SimonCropp
remove some redundant type checks (#10015)
79a4b0a
@SimonCropp
remove TestDataResourceUtility.GetResourceString (#9993)
006f6f0
@SimonCropp
use char based StringBuilder.Append where possible (#10012)
bb074ac
@martinrrm
[UI] Add new themes into website (#9926)
ccd0171 
Added new Dark theme and refreshed Light theme with new components.
@SimonCropp
convert AccountDeleter.Facts.csproj to sdk project (#9988)
a9a79ac
@SimonCropp
elide Task.FromResult asyncs (#9997)
53004f0
@SimonCropp
remove duplicate dictionary lookups (#10003)
e4481d3
@SimonCropp
remove un used obfuscatedIpAddress StringBuilder (#10006)
e0b4bc9
@SimonCropp
remove un used updateUriBuilder variable (#10007)
85e5034
@SimonCropp
remove un use GetBlobReference and container in CloudBlobCoreFileStor…
b309544 
…ageService (#10010)
@SimonCropp
remove redundant string interpolation (#10011)
22b3be2
@SimonCropp
discard some variables (#10014)
10cd7bd
@SimonCropp
remove un used thirdPartyPackageManager variable (#10008)
5355aa3
@martinrrm
[Dark Theme] Fix reserved icon error and updated default icon image (#…
7127734 
…10041)
@drewgillies
Remove elmah table usage from gallery (#10021)
b1f57a8 
Remove elmah table usage from gallery
@SimonCropp
Addtional typo (#10037)
71bc8e3
@SimonCropp
remove redundant ToArray (#9998)
b0f7dc7
@SimonCropp
migrate GitHubVulnerabilities2Db.Facts to sdk csproj (#10000)
6124319
@martinrrm
[Dark Theme] Revert NuGet trends image (#10045)
d503ffa
@SimonCropp
fix some incorrect as usage and better leverage Assert.IsType (#10038)
e155cc9
@drewgillies
remove unused class AzureEntityList (#10044)
3ac898a
@agr @SimonCropp
Using Azure.Storage.Blobs for storage access (#10018)
17b24e4 
Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
@donnie-msft
Remove activePackageSource from NuGet.config (#10048)
23ea3b1
@SimonCropp
Update global.json (#9986)
5a9e29e
@erdembayar
Copy link
Contributor

@donnie-msft
Please approve or comment here if your commits in this PR looks good.

@donnie-msft
Copy link
Contributor

@donnie-msft Please approve or comment here if your commits in this PR looks good.

My commit looks good.

@lyndaidaii
Support service principal (#10043)
317378a 
Support service principal
@lyndaidaii lyndaidaii dismissed stale reviews from erdembayar and drewgillies via 317378a July 2, 2024 21:50
erdembayar
erdembayar previously approved these changes Jul 2, 2024
View reviewed changes
@erdembayar erdembayar requested review from agr and lyndaidaii July 2, 2024 22:33
lyndaidaii
lyndaidaii previously approved these changes Jul 2, 2024
View reviewed changes
drewgillies
drewgillies previously approved these changes Jul 4, 2024
View reviewed changes
agr
agr previously approved these changes Jul 4, 2024
View reviewed changes
@erdembayar erdembayar dismissed stale reviews from agr, drewgillies, lyndaidaii, and themself via 9382cf8 July 9, 2024 18:34
SimonCropp and others added 5 commits July 9, 2024 11:36
@SimonCropp
migrate NuGet.Services.DatabaseMigration.Facts to sdk csproj (#10001)
e01aad9
@SimonCropp
fix constraint typo (#10050)
85e0c0a
@SimonCropp
remove some redundant ToString (#10051)
2c16fae
@SimonCropp
remove some redundant scoped variables (#10009)
5c5ba51
@agr
MSI auth support for NuGetGallery (#10059)
5033758 
* MSI auth.
* DefaultAzureCredential support for debug builds for local debugging.
* Removed last reference to WindowsAzure.Storage
* Extracting blob properties from `BlobDownloadDetails`.
erdembayar
erdembayar previously approved these changes Jul 10, 2024
View reviewed changes
@drewgillies drewgillies merged commit 27cbca3 into main Jul 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinrrm martinrrm martinrrm approved these changes

@erdembayar erdembayar erdembayar approved these changes

@agr agr agr approved these changes

@lyndaidaii lyndaidaii lyndaidaii left review comments

@drewgillies drewgillies drewgillies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@v-manil2 @erdembayar @donnie-msft @agr @drewgillies @martinrrm @lyndaidaii @SimonCropp