[ReleasePrep][2017.05.19]RI of dev into master #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support MinClientVersion <= 4.0.0.0 Fixes NuGet/Home#5156 * Update Constants.cs
This pull request does the following accessibility improvements: * Improved the titles of the buttons and select drop-down box on the Upload Verification page * Improved the registration form * Fixed issue where the email input wasn't properly labelled * Made all help texts part of the fields' labels. All of these changes are on the UI, thus, I didn't do any changes to unit tests. Fixes VSTS bugs [#395317](https://devdiv.visualstudio.com/DevDiv/_workitems?id=395317&_a=edit&triage=true), [#395879](https://devdiv.visualstudio.com/DevDiv/_workitems?id=395879&_a=edit&triage=true), and [#395340](https://devdiv.visualstudio.com/DevDiv/_workitems?id=395340&_a=edit&triage=true).
* Index recommendation for SemVerLevelKey (#3867) * Fixed the csproj
Improved accessibility for the following pages: * Account Page * Improved the upload and manage package links by separating the label and describe sections. Resolves [VSTS #395337](https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=395337&_a=edit) * Improved accessibility of "Change" button toggles. The screen reader will now describe their state as "expanded" or "collapsed". Fixes [VSTS #395336](https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=395336&_a=edit) * Improved accessibility of "Add Key" button for API Key management. The screen reader will now describe the button as disabled or not. Fixes [VSTS #395343](https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=395343&_a=edit). * Improved accessibility of "Example glob patterns" link on the API Key management by making it selectable with the "Tab" key. * Manage my Packages Page * Improved the `Edit` and `Delete` accessibility labels. Fixes [VSTS #395342](https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=395342&_a=edit). * Upload Package Page * Added label to the file upload input. Fixes [VSTS #395339](https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=395339&_a=edit)
This is easier since it does not require an SSH key
… a single certificate at a time (#3959) Throw if netsh complains about incorrect parameters
Move some css around to try to limit visual impact of change. (#3939)
…te without refreshing the page (#3951)
* fix: tab access is enabled on disabled elements * make pretty
…ible using keyboard (#3968)
* Add block to hide/show copyright claim requirements based on selection. * Moves validation of signature to controller. Dynamically validate on client side when required. * Add email admin message. Fix required input UI marking. * Fix a typo in the mailto address.
[ReleasePrep][2017.05.19]FI of master into dev
ryuyu
requested review from
loic-sharma,
chenriksson,
cristinamanum,
skofman1 and
scottbommarito
scottbommarito
approved these changes
May 20, 2017
joelverhagen
approved these changes
May 22, 2017
chenriksson
approved these changes
May 22, 2017
loic-sharma
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chenriksson @skofman1 @loic-sharma @agr @scottbommarito @joelverhagen @cristinamanum