Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v5.1 updates #5139

Closed
wants to merge 35 commits into from
Closed

Release v5.1 updates #5139

wants to merge 35 commits into from

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Aug 2, 2024 •
edited
Loading

This PR contains commits cherry picked from master that should be applied to release-v5.1.

Any PR done for https://github.com/OpenZeppelin/openzeppelin-contracts/milestone/21 should first be merge into master then cherry picked here. Once we are happy with them, we should fast forward the release branch to this

@Amxx @ernestognw @cairoeth
Create a ERC1363Utils helper similar to existing ERC721Utils and ERC1…
a726d5d 
…155Utils (OpenZeppelin#5133)

Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: cairo <cairoeth@protonmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e24c155

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx added this to the 5.1-after-freeze milestone Aug 2, 2024
@Amxx
Get leaves from memory in processMultiProofCalldata (OpenZeppelin#5140)
0af6561 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw ernestognw mentioned this pull request Aug 7, 2024
Merged
3 tasks
@ernestognw ernestognw mentioned this pull request Sep 30, 2024
Merged
ernestognw and others added 16 commits October 1, 2024 14:47
@ernestognw @cairoeth
@pcaversaccio @Amxx
Update MerkleProof note clarifying empty set definition (OpenZeppelin…
7048533 
…#5144)

Co-authored-by: cairo <cairoeth@protonmail.com>
Co-authored-by: sudo rm -rf --no-preserve-root / <pcaversaccio@users.noreply.github.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw @Amxx
Add memory side effects notes when using function pointers (OpenZeppe…
90afffc 
…lin#5174)

Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@Amxx
Revert "Remove double declaration of P in P256 (OpenZeppelin#5159)" (…
67ea678 
…OpenZeppelin#5180)

Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@cairoeth @Amxx @ernestognw
Optimizations to P256 operations (OpenZeppelin#5181)
6af500b 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw @Amxx
Add note about 100% royalty in IERC2981 (OpenZeppelin#5173)
6aac3f9 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw @Amxx
Make padding skip clear in Base64URL encoding (OpenZeppelin#5176)
444c65e 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw @Amxx
Clarify Governor events' lack of indexed parameters (OpenZeppelin#5175)
56c61cc 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@cairoeth @Amxx
Fix typographical errors (OpenZeppelin#5194)
fe3c344 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@cairoeth @Amxx
Update to match Solidity pragma (OpenZeppelin#5198)
0698da4 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@cairoeth @Amxx
Remove redundant modulo operation in P256 (OpenZeppelin#5200)
d521fe7 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@cairoeth @Amxx
Clean dirty addresses and booleans (OpenZeppelin#5195)
21046a7 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@cairoeth @Amxx
Clarify reference commits and licenses (OpenZeppelin#5205)
ecb562a 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@cairoeth @Amxx
Clarify mapping named parameters (OpenZeppelin#5204)
fa0d643 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@Amxx @ernestognw
Update documentation of helper interface (OpenZeppelin#5179)
13672e0 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw @Amxx
Add note about memory manipulation in MerkleTree (OpenZeppelin#5213)
2c2e522 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw @Amxx
Disallow empty CircularBuffer setup (OpenZeppelin#5214)
aa536ca 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
cairoeth and others added 10 commits October 1, 2024 14:55
@cairoeth @Amxx @ernestognw
Update and clarify documentation comments (OpenZeppelin#5206)
1d425c3 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ericglau @Amxx
Add P256 and RSA documentation sections (OpenZeppelin#5227)
28cb012 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@Amxx
Refactor Heap.sol to remove index and lookup (OpenZeppelin#5190)
d9bad96
@ernestognw @Amxx @cairoeth
Implement 5.1 Full Audit Naming Suggestions (OpenZeppelin#5215)
d240bde 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: cairo <cairoeth@protonmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw @Amxx
Consistently name multiple returned values (OpenZeppelin#5177)
4a9e581 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@Amxx
Improve VestingWallet's constructor and RSA.pkcs1Sha256 documentation (…
d681671 
…OpenZeppelin#5229)

Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@cairoeth @ernestognw @Amxx
Add introduction tag for v5.1 contracts (OpenZeppelin#5228)
ad8e94e 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@Amxx
Fix invalid link and typos (OpenZeppelin#5232)
00c85e6
@cairoeth @Amxx @ernestognw
Fix P256 corner cases (OpenZeppelin#5218)
6709a08 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@Amxx @ernestognw
Add warning about low public key exponent (OpenZeppelin#5234)
e24c155 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@Amxx Amxx requested review from ernestognw and cairoeth October 2, 2024 10:04
@Amxx
Copy link
Collaborator Author

Amxx commented Oct 2, 2024 •
edited
Loading

DO NOT MERGE: we should rebase the release branch on top of this.

@Amxx Amxx closed this Oct 2, 2024
@Amxx Amxx deleted the release-v5.1-updates branch October 2, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw Awaiting requested review from ernestognw

@cairoeth cairoeth Awaiting requested review from cairoeth

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.1-after-freeze
Development

Successfully merging this pull request may close these issues.
4 participants
@Amxx @ernestognw @cairoeth @ericglau