Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autodiff: Test linear algebra #10448

Merged

Conversation

EricCousineau-TRI
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI commented Jan 18, 2019

@manuelli ran into these issue, and I hadn't actually tested these yet.

(There's a form of these in #8452, but I, uh, forgot to port them...)

xref:
#8116
numpy/numpy#11332


This change is Reviewable

Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@soonho-tri for feature review, please.
+@sherm1 for platform review, please.

Reviewable status: all discussions resolved, platform LGTM missing

Copy link
Member

@soonho-tri soonho-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

BTW, do you plan to provide a link to this example in documentation (e.g. in another file)?

Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee sherm1, platform LGTM from [soonho-tri] (waiting on @EricCousineau-TRI and @sherm1)


bindings/pydrake/test/autodiffutils_test.py, line 199 at r1 (raw file):

        Bf = np.array([[2., 2]]).T
        C2 = np.dot(A, Bf)  # Leverages implicit casting.
        self._check_array(C, [[AD(4, [4., 2])]])

I guess you wanted to write:

self._check_array(C2, [[AD(4, [4., 0])]])

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform :lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion, platform LGTM from [soonho-tri, sherm1] (waiting on @EricCousineau-TRI)

Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, do you plan to provide a link to this example in documentation (e.g. in another file)?

Will think about how to do that in doc/python.rst...

Reviewable status: 1 unresolved discussion, platform LGTM from [soonho-tri, sherm1] (waiting on @sherm1 and @soonho-tri)


bindings/pydrake/test/autodiffutils_test.py, line 199 at r1 (raw file):

Previously, soonho-tri (Soonho Kong) wrote…

I guess you wanted to write:

self._check_array(C2, [[AD(4, [4., 0])]])

Done. Thanks!

Copy link
Member

@soonho-tri soonho-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [soonho-tri, sherm1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants