Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pybind11: Use workaround for false cache hits for overloads #12095

Merged
merged 1 commit into from
Sep 25, 2019
Merged

pybind11: Use workaround for false cache hits for overloads #12095

merged 1 commit into from
Sep 25, 2019

Conversation

EricCousineau-TRI
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI commented Sep 24, 2019 •
edited
Loading

Resolves #11424

Requires:

This change is Reviewable

@EricCousineau-TRI
Copy link
Contributor Author

@drake-jenkins-bot mac-mojave-clang-bazel-experimental-release please

EricCousineau-TRI
EricCousineau-TRI commented Sep 24, 2019
View reviewed changes
Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sammy-tri for both reviews, please.

Reviewable status: LGTM missing from assignee sammy-tri(platform), needs at least two assigned reviewers (waiting on @sammy-tri)

sammy-tri
sammy-tri reviewed Sep 25, 2019
View reviewed changes
Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually mean that it resolves #7856? The text in RobotLocomotion/pybind11#32 only mentions #11424.

Reviewable status: LGTM missing from assignee sammy-tri(platform), needs at least two assigned reviewers (waiting on @sammy-tri)

EricCousineau-TRI
EricCousineau-TRI commented Sep 25, 2019
View reviewed changes
Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Messed that up! Just changed it!

Reviewable status: LGTM missing from assignee sammy-tri(platform), needs at least two assigned reviewers (waiting on @sammy-tri)

sammy-tri
sammy-tri reviewed Sep 25, 2019
View reviewed changes
Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: needs at least two assigned reviewers

@sammy-tri sammy-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Sep 25, 2019
sammy-tri
sammy-tri reviewed Sep 25, 2019
View reviewed changes
Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: single reviewer ok)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee sammy-tri(platform)

@EricCousineau-TRI EricCousineau-TRI merged commit f1e527b into RobotLocomotion:master Sep 25, 2019
avalenzu pushed a commit that referenced this pull request Sep 26, 2019
Revert "pybind11: Use workaround for false cache hits for overloads (#…
6d6b8c2 
…12095)"

This reverts commit f1e527b.
@avalenzu avalenzu mentioned this pull request Sep 26, 2019
Merged
avalenzu pushed a commit that referenced this pull request Sep 26, 2019
Revert "pybind11: Use workaround for false cache hits for overloads" (#…
031a3ba 
…12105)

* Revert "pybind11: Use workaround for false cache hits for overloads (#12095)"

This reverts commit f1e527b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammy-tri sammy-tri sammy-tri left review comments

Assignees

@sammy-tri sammy-tri

Labels
status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

revert followup: Figure out why custom_test fails intermittently due to #11416
2 participants
@EricCousineau-TRI @sammy-tri