Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[workspace] Upgrade usockets and uwebsockets" #18289

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Nov 9, 2022

Reverts #18259. Re-opens #17910.

We have some evidence that a Docker image using this commit will not work with the Nginx proxy server we use for our Deepnote tutorials, yielding a "Bad Gateway" error message instead.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added release notes: fix This pull request contains fixes (no new features) priority: high status: single reviewer ok https://drake.mit.edu/reviewable.html labels Nov 9, 2022
@jwnimmer-tri jwnimmer-tri self-assigned this Nov 9, 2022
@jwnimmer-tri
Copy link
Collaborator Author

jwnimmer-tri commented Nov 9, 2022

:lgtm: rubber stamp on pure revert.

Given the intricacies of testing this problem, it's a bit difficult to know for sure that this is the offending commit but anyway reverting it is no great loss. The purpose of the upgrade was to suss out problems with upstream versions earlier rather than later, which it seems like this has accomplished.

We'll re-use #17910 to track the upgrade (and possible incompatibility).

@RussTedrake
Copy link
Contributor

:lgtm: also. thanks!!

@jwnimmer-tri jwnimmer-tri merged commit 42ba1fe into master Nov 9, 2022
@jwnimmer-tri jwnimmer-tri deleted the revert-18259-workspace-usockets-upgrade branch November 9, 2022 23:55
xuchenhan-tri pushed a commit to xuchenhan-tri/drake that referenced this pull request Feb 6, 2023
@RussTedrake
Copy link
Contributor

Since this problem just surfaced again, due to #18516, let me describe here an acceptance test:

Using the drake tutorials on Deepnote, running the first two cells of the authoring_multibody_plant tutorial should allow you to then click on the url and open a meshcat instance. When usockets/uwebsockets was upgraded, we could not connect to meschat, and instead see a 502 Bad Gateway error message from ngix.

RussTedrake added a commit to RussTedrake/drake that referenced this pull request Feb 8, 2023
The upgrade in RobotLocomotion#18516 broke meshcat on Deepnote again.  See RobotLocomotion#18289.
RussTedrake added a commit to RussTedrake/drake that referenced this pull request Feb 8, 2023
The upgrade in RobotLocomotion#18516 broke meshcat on Deepnote again.  See RobotLocomotion#18289.
RussTedrake added a commit to RussTedrake/drake that referenced this pull request Feb 8, 2023
The upgrade in RobotLocomotion#18516 broke meshcat on Deepnote again.  See RobotLocomotion#18289.
RussTedrake added a commit that referenced this pull request Feb 9, 2023
The upgrade in #18516 broke meshcat on Deepnote again.  See #18289.
marcoag pushed a commit to marcoag/drake that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants