-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usockets and uwebsockets needs update to latest #17910
Comments
From a Drake policy perspective, it's a slight preference to use tagged releases when possible, but failing that it's a-ok to use a random git sha. |
The update is also apparently causing *san failures. Will need someone to do more digging. |
FYI
As of today, the latest usockets & uwebsockets do have an author (vs being anonymous), so that bug is no longer in play. |
|
See #18289. The next step here is to write a Python integration test that spawns nginx as a subprocess, launches Meshcat using a proxy, and does and automated end-to-end test. |
I've just tested the new nightlies by running the first cells of "authoring multibody simulations" tutorial on a fork of the tutorials on deepnote, and confirm that when I try to open the url printed by StartMeshcat, I see:
So i do think that #18259 caused meshcat to stop working on deepnote. |
Re-opened via the revert #18755. Reminder of: #17910 (comment). Next step is a regression test, not an upgrade. See #18289 (comment) for an acceptance test. |
uwebsockets needs to be updated to the latest release. The build is failing:
It looks like the latest µWebSockets may depend on an unreleased µSockets? (The latest µSockets release is Sept 2021. There should perhaps also be a note that these packages should update in tandem in the relevant
repository.bzl
(s)?)Note also that
new_release.py
is not currently working on usockets due to sigmavirus24/github3.py#1105.The text was updated successfully, but these errors were encountered: