Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Disable auto-upgrade for usockets,uwebsockets #18761

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Feb 9, 2023

Towards #17910.

# NOTE: Do not upgrade without testing the tutorials on Deepnote. See
# Drake #18289. v0.8.5 was tested and showed the same symptoms.
commit = "v0.8.1",

# NOTE: Do not upgrade without testing the tutorials on Deepnote. See
# Drake #18289. v20.35.0 was tested and showed the same symptoms.
commit = "v20.14.0",


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Feb 9, 2023
@jwnimmer-tri
Copy link
Collaborator Author

+@EricCousineau-TRI for both reviews per schedule, please.

\CC @mwoehlke-kitware @williamjallen FYI for awareness.

@mwoehlke-kitware
Copy link
Contributor

mwoehlke-kitware commented Feb 9, 2023

:lgtm:

Maybe the comment should include something like 'see its repository.bzl'?

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: platform, deferring merge pending addressing of Matt's comment

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform) (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Collaborator Author

Maybe the comment should include something like 'see its repository.bzl'?

For my taste, it's pretty obvious to "see repository.bzl for details". For now, onward.

@jwnimmer-tri jwnimmer-tri merged commit 885f711 into RobotLocomotion:master Feb 9, 2023
@jwnimmer-tri jwnimmer-tri deleted the new-release-nosockets branch February 9, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants