Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade usockets/uwebsockets #18755

Merged

Conversation

RussTedrake
Copy link
Contributor

@RussTedrake RussTedrake commented Feb 8, 2023

The upgrade in #18516 broke meshcat on Deepnote again. See #18289.

+@jwnimmer-tri for both reviews, please.

Marking "emergency", because I'm trying to release pset 1 tonight, and it is MUCH more complicated if I can't use the recent Drake nightlies. (we've had a lot of deprecations / changes since the last functional nightly).


This change is Reviewable

@RussTedrake RussTedrake added priority: emergency status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Feb 8, 2023
The upgrade in RobotLocomotion#18516 broke meshcat on Deepnote again.  See RobotLocomotion#18289.
@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Feb 8, 2023

:lgtm:

@RussTedrake RussTedrake merged commit 839d42e into RobotLocomotion:master Feb 9, 2023
@RussTedrake RussTedrake deleted the downgrade_uwebsockets branch February 9, 2023 00:11
marcoag pushed a commit to marcoag/drake that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: emergency release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants