Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 verified to main #5385

Merged
merged 35 commits into from
May 24, 2021
Merged

2.0 verified to main #5385

merged 35 commits into from
May 24, 2021

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented May 24, 2021

Proposed change(s)

Make sure everything from 2.0-verified makes it back to main. The main changes are:

  • Barracuda dependency to 2.0.0-pre.3
  • CI changes to test against 2021.2
  • Doc changes

Chris Elion and others added 30 commits April 16, 2021 10:07
* collecting latest step as a stat

* adding a list of hidden_keys to TB summarywriter to hide unnecessary stats from user

* fixing precommit

* formating

* defined the property types

* moving custom defaults to get_default_stats_writers

* new test for TensorboardWriter.hidden_keys

* improved testing

* explicit None evaluation

Co-authored-by: Ervin T. <ervin@unity3d.com>

* make hidden_keys optional

Co-authored-by: Ervin T. <ervin@unity3d.com>

* adding optional argument

* lowering the training threshold to 0.8 on test_var_len_obs_and_goal_poca

* Update pytest.yml

* Do not merge! droping pytest 3.9 job

* -add back pytest
-format imports and comments

* back to default threshold for test_var_len_obs_and_goal_poca

Co-authored-by: mahon94 <maryam.honari@unity3d.com>
Co-authored-by: Ervin T. <ervin@unity3d.com>

Co-authored-by: mahon94 <maryam.honari@unity3d.com>
Co-authored-by: Ervin T. <ervin@unity3d.com>
…) (#5296)

* Add strict check to settings.py

* Remove warning from trainer factory, add test

* Add changelog

* Fix test

* Update changelog

* Remove strict CLI options

* Remove strict option, rename, make strict default

* Remove newline

* Update comments

* Set default dict to actually default to a default dict

* Fix tests

* Fix tests again

* Default trainer dict to requiring all fields

* Fix settings typing

* Use logger

* Add default_settings to error

(cherry picked from commit 86a4070)
* list removed APIs with replacements

* fixes
Co-authored-by: Chris Elion <chris.elion@unity3d.com>
Co-authored-by: Ervin T <ervin@unity3d.com>
surfnerd and others added 2 commits May 13, 2021 13:49
* Update to Unity Package licenses

Per Dan

* Updating the main repo license dates.

Co-authored-by: Marwan Mattar <marwan@unity3d.com>
@chriselion chriselion marked this pull request as draft May 24, 2021 18:41
@chriselion chriselion requested a review from surfnerd May 24, 2021 20:47
@chriselion chriselion marked this pull request as ready for review May 24, 2021 20:47
@chriselion chriselion merged commit 44fe48e into main May 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the 2.0-verified-to-main branch May 24, 2021 21:28
@chriselion chriselion changed the title [WIP] 2.0 verified to main 2.0 verified to main May 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants