Feature/docusaurus #2625
Closed
Feature/docusaurus #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will reduce the bundle size by ~23%(117kb). Only 4 methods were used `flatten`, `flatMap`, `omitBy`, and `groupBy`. `omitBy and `groupBy` were recreated while the es2019 implementations of `flatten` and `flatMap` are used. `lodash` is still used in the tests which is fine because it makes the tests cleaner. Closes #2118
Reduces the bundle size by 8% (41kb) BigInteger is now well supported so the library is no longer needed. BigNumber was already being used by xrpl and they had almost identical interfaces as they are both based on Java.
Bump https-proxy-agent to v7 and a dev dependency. This makes configuring bundlers easier to configure and removes a direct dependency of `https-proxy-agent`. BREAKING CHANGE: Configuring a proxy is done by specifying the `agent` parameter on the ConnectionOptions config. This can use be created by libraries such as `https-proxy-agent` or any that implements `http.Agent`.
Switch to using fetch for browser and `node-fetch` for node for the faucet calls. This reduces the webpack bundle by 3.2% or 16.5kb gzipped. The fundWallet code has been refactored to be much more straight forward due to not having to do such low level operations. This improves the frontend setup process by no longer requiring several polyfills such as `url`, `stream-http`, and `https-browserify`.
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
BREAKING CHANGE: `BroadcastClient` was removed. It was deprecated in 2.2
…eing specified (#2376)
* Fix assertion * Add a test
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
* fix: make docs not output confusing information in xrpl client --------- Co-authored-by: Jackson Mills <jmills@ripple.com> Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
- Remove `util` from bundle by switching `inspect` to `JSON.stringify` - Update `HISTORY.md` with latest 3.0 changes
…ature/docusaurus commit merge
|
Should this PR be closed in favor of #2629? |
|
|
closing the PR in favor of #2629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Documentation site migration to Docusaurus
Context of Change
Type of Change
Did you update HISTORY.md?
Test Plan