Close Professor-page-search-bar issues #844
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* revert changes to migration files * generate migration for professors table with updated columns
* Created Professor, club/organziation, and pathway entities(draft) draft of the professors , club/organization, and pathways entitiy * Changed SQLalchemy version to 1.4.1 the title * Adding professors created functions which should add professors into database - added foreign key to certain tables * started professor page * Remove webex form professor - Removed webex from table - planned what other functions to add for the future * Professor Name created function for getting professor first and last name and stores it in json file * Get professor name by email - Implemented function for getting professor name by email - fixed bug where professor table caused YACS to show a blank screen - updated the requirements * Removing professor from database - further testing on /api/professor - implementation of remove professor function * Fix finding professor name by eamil - fixed function on app.py - added getter function to get profesor by name - added get prfoesor info by rcsid - modified Professor table * FIxed functions for professor - gave %s values * Implement more professor functions Functions: - get professor by department - get all professors - get professor phone number by email * starting professor explore page * Added Professor functions - added get_office_hours_by_email - added get_professor_rcs_by_email * Professor functions implemented all functions except add professor * worked on professor functions * Add Professor - added professor function - fix remove professor * got alphabet-sorted professor page working * created department view * fixed spacing, buttons, and alphabetization * created professor pop-up * added professors header button * Debugging API calls - add professors is not working, Internal server error * Debbuging continued - compared professor to courses and investigated docker issue * Debugging continued - continued debugging for APIs * possible patch to fix * change to get method * Update YacsService.js * API fix fixing and testing API calls * Error with professor test case - receiving foreign key restraint although there is no foreign key specified * IT WORKS debugged API call for testing and retrieving professor * Finished debugging on localhost add and remove now work * move professor api calls to frontend service and created a editProfessors page * Admin API calls - all are working except remove and add prof test * made professor profile page * debuggign remove professor remove works on localhost but not on admin * remove professor remove professor for admin works * Bulk upload - starting bulk upload function * Improved Admin Page and Maintanence - made code consistent - better buttons for admin page - foreign key for crn * Bulk upload and clear cache - created function for bulk upload, remove all and clear cache - needs testing * Modified Professor Page and add professor - fixing add professor - changed what Professor stores * Add professor is delayed It takes a while for add_professor to be seen in getProf * professor header button icon * fix add professor should have fixed add professor * removed professor phone number * add bulk professor - made function to turn a json file into sql tables * fixed heading alignment * clean up cleaning up correct and minor edit * Fix duplicate Professor removed duplicate professor table * added button on admin page import professor via json * starting json from frontend to backend creating front end portion of button * working on json upload - fixing json upload to be received into database * fix issues on the UI of professor bulk insert * needs testing json file ready to be tested, need to check with get professors function * slight modifications to taking in professor json file turns to string before using function and fix errors * cleaned up code got rid of useless import and improved commenting * Debug import json file - changed professor table - changed functions - changed requirements * fixed merge conflict * Fixing professor json uploaded json data json data is being uplaoded a file name, which is wrong * Professor commenting and debugging continued working and commenting integration * cleane up deleted unecessary lines * tesitng see if it fixes code factoring * code factoring error fixing fix Possible SQL injection vector through string-based query construction. * put professor into database * reveal what to do for testing added comments * located error * debugging database table creation * fixed skipping database initalization - new problem ERROR: relation "professor" already exists duplicate professor? * professor database fixed database names for professor * fixed attribute name issue * Improved security deleted api functions that won't be tested and prevented possible Possible SQL injection vector through string-based query construction * clean up and improved secuirty prevented sql inejctions * updated Department * fixed warning * fix warning * fix warning * Update professor.py * removed unnecessary functions we don't need professors' rcs id * warning fix * attempt at fixing warning * attempt at fixing warning * fix warning * fix warning * Update professor.py * fixing security error with SQL * fixing SQL errors * fixing * cleaning up function * trying to get sql injeciton errors * try again :( * does this fix it * few more changes * get professor buttons work * clean up * testing * revert * clean up deleted unecessary lines of code * clean up got rid of useless code for cleaner UI * Create ProfExplorer.vue * Switched order of prof and final * fixed backend deleted useless file * upload to JSON works * fix syntax error * attempting to fix syntax issues causing lighthouse CI to crash * Add proper professor table migration (#841) * revert changes to migration files * generate migration for professors table with updated columns * professor table: fix column names --------- Co-authored-by: ragar3 <qN%ZMi6Q3nq7Qi> Co-authored-by: Harry Tan <32246618+DarknessUnder@users.noreply.github.com> Co-authored-by: ragar3 <112728733+ragar3@users.noreply.github.com> Co-authored-by: Jun Song <40209659+Acewvrs@users.noreply.github.com> Co-authored-by: EggyRepublic <Eggyrepublic@gmail.com> Co-authored-by: dorian451 <112524240+dorian451@users.noreply.github.com>
DarknessUnder
temporarily deployed
to
yacs-rpi-prod
GitHub Actions
Inactive
* Started post request script file. * Update .gitignore * Update .gitignore * Update post_test.py * Update .gitignore * Fixed Corequisite Bugs Basically a complete rewrite * Did some final fixes and added comments. * deleted post_test from branch * made some fixes to headless_login, hopefully dorian can run it now * Fix firefox preferences not being set Co-authored-by: martig7 <martig7@rpi.edu> --------- Co-authored-by: Tevetron <friedrich.jonathan4@gmail.com> Co-authored-by: dorian451 <112524240+dorian451@users.noreply.github.com>
dorian451
had a problem deploying
to
yacs-rpi-prod
GitHub Actions
Failure
dorian451
temporarily deployed
to
yacs-rpi-prod
GitHub Actions
Inactive
dorian451
temporarily deployed
to
yacs-rpi-prod
GitHub Actions
Inactive
dorian451
had a problem deploying
to
yacs-rpi-prod
GitHub Actions
Failure
dorian451
had a problem deploying
to
yacs-rpi-prod
GitHub Actions
Error
dorian451
had a problem deploying
to
yacs-rpi-prod
GitHub Actions
Failure
* Start of finals parser * Continued creating finals parser * Fixed some issues, began commenting * Fixed a few more issues, reconsidered logging * Improved formatting and fixed bug Fixed AM/PM bug, other changes * Converted to python script * Updated with instructions on how to convert to .py * Tested updated schedule * Added logic for cross listed courses * Added cross listing logic * Added requirements.txt * Fixed bug with \ entries * Updated the .py to match * remove idea folder * dont redefine format --------- Co-authored-by: dorian451 <112524240+dorian451@users.noreply.github.com>
* Wrote functions to find all course codes and to generate links based off those codes. * Made a lot of progress but forgot to commit. * end of session commit * Wrote some formatting for the scraped data. * First draft of no login scraper works (mostly) * Started work on a script to scrape Professor Goldschmidt's course information files. * Saving the work for today. Started work on a sctipt to scrape professor data to our json format. * Got all of the professor links. * Committing my work from Friday. Finished scraping all professor data, just have to output as json. * Finished up the faculty scrape, finished up Goldschmidt parse. * Commit to work off on desktop * Changed file locations and started catalog parser. * Pulling over some work I did on HASSPathways over to YACS, with a lot of large edits and additions to make it work with my previous code and to maximize performance. * Commented my scraper functions. * oops.
dorian451
had a problem deploying
to
yacs-rpi-prod
GitHub Actions
Failure
dorian451
had a problem deploying
to
yacs-rpi-prod
GitHub Actions
Failure
dorian451
had a problem deploying
to
yacs-rpi-prod
GitHub Actions
Failure
dorian451
had a problem deploying
to
yacs-rpi-prod
GitHub Actions
Failure
dorian451
had a problem deploying
to
yacs-rpi-prod
GitHub Actions
Failure
* Adding major info data The .txt file is just notes about how to interpret the .json file. * Update major-template-data.json Added about 1500 lines of major data, which totaled to 18 new majors. I also reformatted how you pick classes from a group of options based on discussion with other YACS developers. * Update major-template-data-info.txt Apparently I did not upload this properly last week. But added some more information based on the new data added. * Update major-template-data.json Added about 12 more majors * Update major-template-data.json Made a bunch new majors (estimated 8 or so) * Update major-template-data-info.txt Changed this to reflect how you pick multiple electives from a list of choices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
add the new feature of the search bar on the professor search bar
Note which issue number(s) this Pull Request closes. All pull requests should close an issue, if one does not exists, make one. This helps us plan and discuss before we decide on implementation
Example:
Database Changes/Migrations
N/A
Example:
Test Modifications
N/A
Photos
Before:
After:
Show before and after, capture screenshot/gif of finished feature/bug
*Additional Info
More info that would help people review your change