Added flood fill in Coconut #743

Amaras · 2020-08-05T22:39:38Z

Here is the new Coconut code for the flood fill chapter.
I don't see how to make the code more functional, sadly, as it's a really iterative method.

There might be a merge conflict with the C code for now, but in the meantime, this PR is waiting for review.

* Adding flood_fill.c * Updating flood_fill.md * adding C's queue_fill to flood_fill.md

* Add code and image for huffman * Fix a missing line and a few typo

([0,radius], [0, radius]) is in the upper RIGHT quadrant, as mentioned in the explanations for Monte Carlo.

…ists#749) * Fixed infinite loop issue in "euclidean_example.py" * Changed line numbers in "euclidean_algorithm.md" for python

* fix both error of issue 739 * Update contents/huffman_encoding/code/python/huffman.py Co-authored-by: James Schloss <jrs.schloss@gmail.com>

* add floodfill in python * add name to contributors * small correction * remove unnecessary argument to color() * switch to using numpy + small corrections * improved unit testing * Apply suggestions from code review Co-authored-by: James Schloss <jrs.schloss@gmail.com>

…thm-archivists#766)

Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>

…-lisp Added Cooley-Tukey in Common Lisp

Trashtalk217

The .md file still needs some work, but the code compiles runs and succeeds.
It also feels like the Coconut features can be used slightly more.

In conclusion: I've learned a new dialect today and it's pretty neat!

Trashtalk217 · 2021-01-01T20:38:26Z

contents/flood_fill/code/coconut/flood_fill.coco

+def find_neighbours(canvas, location is Point, old_value, new_value):
+    possible_neighbours = (Point(0, 1), Point(1, 0), Point(0, -1), Point(-1, 0)) |> map$(location.__add__)
+
+    for neighbour in possible_neighbours:


Can't this be a filter, those are usually available in most functional languages

Trashtalk217 · 2021-01-01T20:46:30Z

contents/flood_fill/code/coconut/flood_fill.coco

+    min(location) >= 0 and location.x < canvas_shape[0] and location.y < canvas_shape[1]
+
+
+def colour(canvas, location is Point, old_value, new_value):


This function is no longer used in the Julia implementation for it's redundancy.

I need to rework the code to remove that function, indeed

Trashtalk217 · 2021-01-01T20:49:01Z

contents/flood_fill/code/coconut/flood_fill.coco

+        return
+    colour(canvas, location, old_value, new_value)
+
+    for neighbour in find_neighbours(canvas, location, old_value, new_value):


Looks like a perfect candidate for a map and a lambda-function:

map (x -> recursive_fill(canvas, x, old_value, new_value)) (find_neighbours etc...)

The current implementation works of course, but it seemed like you wanted to have more functionalness.

hum... something like that?

find_neighbours(canvas, location, old_value, new_value) |> map$(recursive_fill$(canvas, ?, old_value, new_value)

Probably, yes. I am not sure it won't be too confusing, though

It's definitely a little too long, splitting it up in neighbours = find_neighbours(...) and neighbours |> map$(...) is probably a good idea.

About the confusion bit. I think that maps are as intuitive as for-loops. It's just that a lot of people only know for-loops, so maps seem weird to them. I may be slightly (very) biased here, as I have some experience with functional programming, so keep that in mind.

Trashtalk217 · 2021-01-01T20:52:16Z

contents/flood_fill/code/coconut/flood_fill.coco

+    while stack:
+        current_location = stack.pop()
+        colour(canvas, current_location, old_value, new_value)
+        for neighbour in find_neighbours(canvas, current_location, old_value,


maybe use stack.extend to add all new neighbours at once

For this one, I think it's a good idea

Trashtalk217 · 2021-01-01T20:53:48Z

contents/flood_fill/code/coconut/flood_fill.coco

+            yield neighbour
+
+
+def stack_fill(canvas, location is Point, old_value, new_value):


I'll agree with you that it's better to do stack work with imperative code. Don't try to squeeze functional code into this.

Trashtalk217 · 2021-01-01T20:59:09Z

contents/flood_fill/code/coconut/flood_fill.coco

+
+    while queue:
+        current_location = queue.popleft()
+        for neighbour in find_neighbours(canvas, current_location, old_value,


same thing as above, you could do map for colour and queue.extend to add.

I am not sure I see how to do that right away. I probably need to work on it a bit more, but that seems out of my capabilities for now.

Trashtalk217 · 2021-01-01T21:04:26Z

contents/flood_fill/code/coconut/flood_fill.coco

+
+
+if __name__ == '__main__':
+    # Testing setup


Maybe try to make the tests similair to the Julia tests.

What do you mean "similar to the Julia tests"?

Disregard the thing I said. I meant to say that you should probably use the same test as in the Julia implementation, namely:

grid = zeros(5,5) grid[3,:] .= 1

But I just realize that you are already doing so. It's just that Julia indexes it's arrays starting at 1. Got confused there.

Trashtalk217 · 2021-01-01T21:06:54Z

contents/flood_fill/code/coconut/flood_fill.coco

+        print('F', end='')
+        failure_count += 1
+    else:
+        print('.', end='')


The . is a bit vague, maybe print something slightly more obvious S for succes, or maybe just full words: Success and Failure.

I made it to look like how unittest runs tests, so that's a revertible design choice

Trashtalk217 · 2021-01-01T21:13:54Z

contents/flood_fill/code/coconut/flood_fill.coco

+
+
+def find_neighbours(canvas, location is Point, old_value, new_value):
+    possible_neighbours = (Point(0, 1), Point(1, 0), Point(0, -1), Point(-1, 0)) |> map$(location.__add__)


PEP8 recommends a maximum line length of 79. And while I think 79 is a very low for line length, this line in particular is a bit long.

I'm using a 90-ish line length (following Raymond Hettinger's advice), but this is indeed quite a bit too long. It probably needs the map on the next line, along with the possible filter

Amaras

So, I know it needs rework, but some points you raised are, I think, not really valid.
I'm glad to see more people work with Coconut, though :D

Amaras · 2021-01-01T21:29:42Z

contents/flood_fill/code/coconut/flood_fill.coco

+
+
+def find_neighbours(canvas, location is Point, old_value, new_value):
+    possible_neighbours = (Point(0, 1), Point(1, 0), Point(0, -1), Point(-1, 0)) |> map$(location.__add__)


I'm using a 90-ish line length (following Raymond Hettinger's advice), but this is indeed quite a bit too long. It probably needs the map on the next line, along with the possible filter

Amaras · 2021-01-01T21:33:22Z

contents/flood_fill/code/coconut/flood_fill.coco

+        return
+    colour(canvas, location, old_value, new_value)
+
+    for neighbour in find_neighbours(canvas, location, old_value, new_value):


hum... something like that?

find_neighbours(canvas, location, old_value, new_value) |> map$(recursive_fill$(canvas, ?, old_value, new_value)

Probably, yes. I am not sure it won't be too confusing, though

Amaras · 2021-01-01T22:17:30Z

contents/flood_fill/code/coconut/flood_fill.coco

+    min(location) >= 0 and location.x < canvas_shape[0] and location.y < canvas_shape[1]
+
+
+def colour(canvas, location is Point, old_value, new_value):


I need to rework the code to remove that function, indeed

Amaras · 2021-01-01T22:19:56Z

contents/flood_fill/code/coconut/flood_fill.coco

+    while stack:
+        current_location = stack.pop()
+        colour(canvas, current_location, old_value, new_value)
+        for neighbour in find_neighbours(canvas, current_location, old_value,


For this one, I think it's a good idea

Amaras · 2021-01-01T22:22:45Z

contents/flood_fill/code/coconut/flood_fill.coco

+
+    while queue:
+        current_location = queue.popleft()
+        for neighbour in find_neighbours(canvas, current_location, old_value,


I am not sure I see how to do that right away. I probably need to work on it a bit more, but that seems out of my capabilities for now.

Amaras · 2021-01-01T22:23:41Z

contents/flood_fill/code/coconut/flood_fill.coco

+
+
+if __name__ == '__main__':
+    # Testing setup


What do you mean "similar to the Julia tests"?

Amaras · 2021-01-01T22:26:08Z

contents/flood_fill/code/coconut/flood_fill.coco

+        print('F', end='')
+        failure_count += 1
+    else:
+        print('.', end='')


I made it to look like how unittest runs tests, so that's a revertible design choice

Trashtalk217 · 2021-01-02T11:50:56Z

Sometimes I am just wrong, so feel free to call me out. It's only my first time touching the language after all.

* Added domain coloring in Python * Some cleanup

…ts#797)

…ill_coconut

Amaras · 2021-08-22T21:46:19Z

Closing to redo because I did something stupid.

Amaras and others added 6 commits August 6, 2020 00:18

Adding flood fill in Coconut

a18e7cc

Correcting copy-paste fails

7d2739b

Flood Fill in C (algorithm-archivists#741)

5da3ae8

* Adding flood_fill.c * Updating flood_fill.md * adding C's queue_fill to flood_fill.md

Huffman Encoding Scratch Implementation (algorithm-archivists#682)

d21dacd

* Add code and image for huffman * Fix a missing line and a few typo

Update monte_carlo.py (algorithm-archivists#751)

aa08db0

([0,radius], [0, radius]) is in the upper RIGHT quadrant, as mentioned in the explanations for Monte Carlo.

Fixed infinite loop issue in "euclidean_example.py" (algorithm-archiv…

a4dbc2a

…ists#749) * Fixed infinite loop issue in "euclidean_example.py" * Changed line numbers in "euclidean_algorithm.md" for python

berquist added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Oct 3, 2020

Julian and others added 2 commits October 12, 2020 18:24

fix both error of issue 739 (algorithm-archivists#756)

9dcc06f

* fix both error of issue 739 * Update contents/huffman_encoding/code/python/huffman.py Co-authored-by: James Schloss <jrs.schloss@gmail.com>

lazyprop mentioned this pull request Oct 13, 2020

Redundant Validity Checks in Flood Fill Julia and C Implementations #765

Closed

leios mentioned this pull request Oct 13, 2020

Remove color function from flood fill because it is redundant #766

Merged

leios and others added 18 commits October 14, 2020 21:54

Remove color function from flood fill because it is redundant (algori…

fee7e83

…thm-archivists#766)

Added Bogosort in Coconut (algorithm-archivists#735)

85f8e9a

Added Bubblesort in Coconut (algorithm-archivists#736)

18944ea

Add Scheme alongside Racket in EditorConfig (algorithm-archivists#779)

f1aa057

Added CSS for printing (algorithm-archivists#777)

7bc0e22

Added Cooley-Tukey in Lisp

91d5625

Make Euclid's algorithm in Nim more idiomatic (algorithm-archivists#784)

5a6ebd0

Make Verlet integration in Nim more idiomatic (algorithm-archivists#782)

153317d

Make Bogosort in Nim more idiomatic (algorithm-archivists#783)

0ca5ac6

Formatting and refactoring

7ada7da

Update contents/cooley_tukey/code/clisp/fft.lisp

c72caaf

Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>

Update contents/cooley_tukey/code/clisp/fft.lisp

70822e9

Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>

Update contents/cooley_tukey/code/clisp/fft.lisp

9d0a5bb

Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>

Update contents/cooley_tukey/code/clisp/fft.lisp

2793edf

Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>

Update contents/cooley_tukey/code/clisp/fft.lisp

8426216

Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>

Update contents/cooley_tukey/code/clisp/fft.lisp

e92bcb7

Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>

Updated line number

e631b57

Merge pull request algorithm-archivists#786 from 0xJonas/cooley-tukey…

02dd353

…-lisp Added Cooley-Tukey in Common Lisp

Trashtalk217 requested changes Jan 1, 2021

View reviewed changes

Amaras commented Jan 1, 2021

View reviewed changes

berquist and others added 8 commits January 2, 2021 16:46

Add Computus in Nim (algorithm-archivists#780)

f9a6eda

Domain Coloring in Python using Matplotlib (algorithm-archivists#788)

b49f034

* Added domain coloring in Python * Some cleanup

adding gif to show people how to change languages (algorithm-archivis…

9d7349a

…ts#797)

Adding flood fill in Coconut

5be74ec

Correcting copy-paste fails

1949a10

Addressed part of Trashtalk's review

a5c0f6b

Merge remote-tracking branch 'origin/flood_fill_coconut' into flood_f…

db00314

…ill_coconut

Got closer to Julia's code logic + reworked the line numbers

f312994

Amaras closed this Aug 22, 2021

Amaras mentioned this pull request Aug 22, 2021

Flood fill in Coconut #836

Merged

Amaras deleted the flood_fill_coconut branch August 31, 2021 21:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added flood fill in Coconut #743

Added flood fill in Coconut #743

Amaras commented Aug 5, 2020

Trashtalk217 left a comment

Trashtalk217 Jan 1, 2021

Trashtalk217 Jan 1, 2021

Amaras Jan 1, 2021

Trashtalk217 Jan 1, 2021

Amaras Jan 1, 2021

Trashtalk217 Jan 2, 2021

Trashtalk217 Jan 1, 2021

Amaras Jan 1, 2021

Trashtalk217 Jan 1, 2021

Trashtalk217 Jan 1, 2021

Amaras Jan 1, 2021

Trashtalk217 Jan 1, 2021

Amaras Jan 1, 2021

Trashtalk217 Jan 2, 2021

Trashtalk217 Jan 1, 2021

Amaras Jan 1, 2021

Trashtalk217 Jan 1, 2021

Amaras Jan 1, 2021

Amaras left a comment

Amaras Jan 1, 2021

Amaras Jan 1, 2021

Amaras Jan 1, 2021

Amaras Jan 1, 2021

Amaras Jan 1, 2021

Amaras Jan 1, 2021

Amaras Jan 1, 2021

Trashtalk217 commented Jan 2, 2021

Amaras commented Aug 22, 2021

		min(location) >= 0 and location.x < canvas_shape[0] and location.y < canvas_shape[1]


		def colour(canvas, location is Point, old_value, new_value):

		yield neighbour


		def stack_fill(canvas, location is Point, old_value, new_value):



		def find_neighbours(canvas, location is Point, old_value, new_value):
		possible_neighbours = (Point(0, 1), Point(1, 0), Point(0, -1), Point(-1, 0)) \|> map$(location.__add__)

Added flood fill in Coconut #743

Added flood fill in Coconut #743

Conversation

Amaras commented Aug 5, 2020

Trashtalk217 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Amaras left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trashtalk217 commented Jan 2, 2021

Amaras commented Aug 22, 2021