This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): use requestAnimationFrame to space out child animations #12669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2015
matsko
added a commit
to matsko/angular.js
that referenced
this pull request
Aug 25, 2015
This reverts the previous behaviour of using foreced reflows to deal with preparation classes in favour of a system that uses requestAnimationFrame (RAF). Closes angular#12669 Closes angular#12594 Closes angular#12655 Closes angular#12631 Closes angular#12612
matsko
added a commit
to matsko/angular.js
that referenced
this pull request
Aug 25, 2015
This reverts the previous behaviour of using foreced reflows to deal with preparation classes in favour of a system that uses requestAnimationFrame (RAF). Closes angular#12669 Closes angular#12594 Closes angular#12655 Closes angular#12631 Closes angular#12612 Closes angular#12187
|
Does this mean we are going back to the system that was implemented before? Or is this a new approach? |
|
This is a new approach that uses a tree data structure to fix the parent class animation blocking. |
| expect(spies.c).toHaveBeenCalled(); | ||
| expect(spies.z).toHaveBeenCalled(); | ||
|
|
||
| function spy(c) { |
There was a problem hiding this comment.
what's the purpose of the param? :)
|
the rest looks good |
matsko
added a commit
to matsko/angular.js
that referenced
this pull request
Aug 27, 2015
This reverts the previous behaviour of using foreced reflows to deal with preparation classes in favour of a system that uses requestAnimationFrame (RAF). Closes angular#12669 Closes angular#12594 Closes angular#12655 Closes angular#12631 Closes angular#12612 Closes angular#12187
This reverts the previous behaviour of using foreced reflows to deal with preparation classes in favour of a system that uses requestAnimationFrame (RAF). Closes angular#12669 Closes angular#12594 Closes angular#12655 Closes angular#12631 Closes angular#12612 Closes angular#12187
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the previous behaviour of using foreced reflows to deal
with preparation classes in favour of a system that uses
requestAnimationFrame (RAF).
Closes #12669
Closes #12594
Closes #12655
Closes #12631
Closes #12612
Closes #12187