This repository was archived by the owner on Apr 12, 2024. It is now read-only.
V1.4.x material breakage rollback #13503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hr objects Closes angular#2318 Closes angular#9319 Closes angular#12159
Do not convert to string properties multiple times.
…ed from attr interpolation Closes angular#10446
Throw when assigning to a field of a constructor. Closes angular#12860
In certain scenarios, IE10/11/Edge create unresponsive select elements. The following contribute to the bug: - There need to be at least 2 selects next to each other - The option elements are added via javascript - the option.value is accessed before it is set - the option.label is added after the option.value has been set - The first select is wrappend in an element with display: inline or display: inline-block, This cannot be tested in a unit-test or e2e test. Closes angular#11314 Closes angular#11795
If `ngMessage` tried to add a message back in that was about to be removed after an animation, the NgMessageController got confused and tried to detach the newly added message, when the pending node was destroyed. This change applies a unique `attachId` to the message object and its DOM node when it is attached. This is then checked when a DOM node is being destroyed to prevent unwanted calls to `detach`. Closes angular#12856 Closes angular#12903
Callbacks are detected within the internals of ngAnimate whenever an animation starts and ends. In order to allow the user to set callbacks the callback detection needs to happen during the next tick. Prior to this fix we used $$rAF to do the tick detection, however, with this patch we intelligently use $$postDigest to do that for us and then only issue a call to `$$rAF` if necessary.
Relying on the body node to be present right at injection has caused issues with unit testing as well as some animations on the body element. Reverting this patch fixes these issues. Closes angular#12874
Prior to this fix anchoring would allow for a container to be a document node or something higher beyond the body tag. This patch makes it fall back to body incase the rootElement node exists as a parent ancestor. Closes angular#12872
…e tests are done running This is to prevent sauce connect tunnel leaks. Closes angular#12921
…oss platforms The previous implementations (based on shell scripts) threw errors on Windows, because it was not able to `rm -rf` 'node_modules' (due to the 255 character limit in file-paths). This implementation works consistently across platforms and is heavily based on 'https://github.com/angular/angular/blob/3b9c08676a4c921bbfa847802e08566fb601ba7a/tools/npm/check-node-modules.js'. Fixes angular#11143 Closes angular#11353 Closes angular#12792
Some animations make use of the `from` and `to` styling only for the lifetime of the animation. This patch allows for those styles to be removed once the animation is closed automatically within `$animateCss`. Closes angular#12930
…tation modified `docsTabsExample` myTabs directive ctrl at [Creating Directives that Communicate Example](https://docs.angularjs.org/guide/directive#creating-directives-that-communicate) so that it uses [Inline Array Annotation](https://docs.angularjs.org/guide/di#inline-array-annotation) and is compatible with [Using Strict Dependency Injection](https://docs.angularjs.org/guide/di#using-strict-dependency-injection) Closes angular#12767
When the empty/blank option has a directive that transcludes, ngIf for example, a comment will be added into the select. Previously, ngOptions used this comment as the empty option, which would mess up the displayed options. Closes angular#12190
Linking to usage section makes it easier for beginners to find out what the config object looks like. The General Usage section now features an example that actually uses $http(config), and the Shortcut Methods section has been moved so that it appears directly after. Closes angular#12949 Closes angular#12950
…ual projects Closes angular#12982 Closes angular#12987
useLegacyPromiseExtensions's default value is true, and the legacy methods exist when it is set to true. Closes angular#12974
By manually parsing and rounding we can deal with the more tricky numbers Closes angular#13394 Closes angular#8674 Closes angular#12709 Closes angular#8705 Closes angular#12707 Closes angular#10246 Closes angular#10252
Prior to this fix the provided options object would be altered as the animation kicks off due to the underlying mechanics of ngAnimate. This patch ensures that a copy of the provided options is used instead. This patch also works for when `$animateCss` is used by itself. Fixes angular#13040 Closes angular#13175
During parent structural animations, ongoing animations on child elements are closed. These child elements are identified by their data-ng-animate attribute. If an element is the clone of an animating element, it might have this attribute, but no animation runner associated with it, so we need to ignore it. Fixes angular#11992 Closes angular#13424
Throw to prevent hard to debug errors in functions that are called later. Fixes angular#12925 Closes angular#13444
…mple The example has been expanded to make it easier to provoke the behavior that the description is talking about (rollbackViewValue and programmatic model updates) Related angular#13340
"any of the parameter value" contains plural (any of the) as well as singular (value). Fixed to be singular to match the rest of the text block. Closes angular#13448
The original statement is in the past tense (as if it were referring to a previous step of the tutorial). The mentioned changes, however, are being done in this setp. Closes angular#13452
You cannot create new objects inside Angular expressions. For example:
{{ new Date() }} expression fails.
Updated example which manually injects the filter. It matches sibling example in functionality. Also put html, js and css into separate files. Also change anchors to buttons. Closes angular#13402
Update the list of permitted chars in URLs. Closes angular#13379 Closes angular#13460
Introduced in commit angular@c90cefe Closes angular#13464
… promise This reverts commit 7170f9d. Fixes part of angular#13393.
…rted Fixes part of angular#13393.
…ning Promises never worked correctly as values for `timeout` in `$resource`, because the same value has to be re-used for multiple requests (and it is not possible to `angular.copy()` a promise). Now (in addition to ignoring a non-numeric `timeout`), a warning is logged to the console using `$log.debug()`. Partly fixes angular#13393. BREAKING CHANGE: Possible breaking change for users who updated their code to provide a `timeout` promise for a `$resource` request in version 1.4.8. Up to v1.4.7 (included), using a promise as a timeout in `$resource`, would silently fail (i.e. have no effect). In v1.4.8, using a promise as timeout would have the (buggy) behaviour described in angular#12657 (comment) (i.e. it will work as expected for the first time you resolve the promise and will cancel all subsequent requests after that - one has to re-create the resource class. This is feature was not documented.) With this change, using a promise as timeout in 1.4.9 onwsards is not allowed. It will log a warning and ignore the timeout value. If you need support for cancellable `$resource` actions, you should upgrade to version 1.5 or higher.
Previously the transition/animation end events were not removed when the animation was closed. This normally didn't matter, because the close function knows the animations are closed and won't do work twice. However, the listeners themselves do computation that could fail when the event was missing some data, for example when the event was triggered instead of natural. Closes angular#10387
Internet Explorer 11 returns '' for optgroup elements without a value attribute. We only want to skip option elements with value '' Fixes angular#13487 Closes angular#13489
ngMinErr is available during unit tests, but not in the build. There's currently no way to catch these access errors in automated testing.
Previously, the animate queue would only detect pinned elements when they were the same element as the to-be-animated element. Related angular#12617 Closes angular#13466
This reverts commit c98e08f. This commit was identified as incompatible with ng-material at Google and is causing broken builds there. Proper fix to be investigated once the immediate regression is addressed.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
pr against the wrong branch. closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.