Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly Support Auto Updates #9

Open
lukechilds opened this issue Jan 10, 2018 · 1 comment
Open

Possibly Support Auto Updates #9

lukechilds opened this issue Jan 10, 2018 · 1 comment
Labels
low priority

Comments

@lukechilds
Copy link
Member

lukechilds commented Jan 10, 2018 •
edited
Loading

This could be very beneficial for quick security patches, not just for HyperDEX but also any binaries we bundle.

However could also have security implications, if the update process was compromised then an attacker could instantly gain access to all HyperDEX users funds.

We could make an attack like this extremely unfeasible by also requiring the updates to be signed with one (or maybe multiple PGP keys). These could be owned by trusted developers, members of SuperNET etc.

An attacker would have to compromise the update process as well as all of the required PGP keys to successfully push an update.
@sindresorhus
Copy link
Contributor

Note that we should never do silent auto-updates. There should at least be a choice for the user.

@lukechilds lukechilds mentioned this issue Nov 19, 2018
Closed
jorian added a commit that referenced this issue Feb 26, 2020
@particle4dev @jorian
Use the concept of orders instead of swaps (#623)
2f769f0 
* [started #615] use-the-concept-of-orders-instead-of-swaps

* debug

* - Add new format-order-data file
- Add some unit test

* db: rename swaps2 to orders2

* api: Add myOrders method

* api: Add cancelAllOrders method

* orders data: update type of order

* db: Add removeOrder method in DB

* add formatOrder and formatSwap data

* test case: taker order is filled in 30s

* test case: maker order can has mutil swaps

* test case: maker order is filled

* swaplist: fix order css

* swap-db.js: remove getSwapCount func and add getOrdersCount

* Order: cancel all pair orders before create a new one

* Dashboard: update  ActivityList

* fix bug: swap not found

* ui: update swap Detail modal

* ui: update SwapList

* remove unused file

* fix #5: steps of swap show wrong amount

* fix #6: add cancel button for open order

* fix #4: trade history shows ongoing trade as completed

* fix #15: replace CHIPS with BTC as always-enabled-coin

* fix #3 sort orders based on price

* fix #9 trade history shows cancelled orders as completed

* fix #18: replace todo text when restoring seed phrase

* fix #13 update HUSH

* fix #13 rename InstantDEX to DEX

* fix #13 add BET

* fix #13 disable BET

* fix #12 disabling a coin should be possible again

* fix #17 ERC20 swaps give wrong error when ETH funds lack

* remove annoying log

* add base variable

* fix #19 order not cancellable, not in mm2.0 response but still visible

* fix #27 withdraw confirmation screen shows wrong information

* fix #28 withdraw full balance not working

* fix #22 clicking Price in orderbook section populates a too high buy Price

* add BET

* add HODL, disable HODLC

* add HUSH

* add preliminary MGW support

* let nonofficial mm2 coins still be enabled through electrum

* enable MGW, add COMMOD

* add LABS

* add BUSD, GIN, USDC

* re-enable OOT

* update VRSC daemons

* remove dead GIN electrum

* remove dead coins (#34)

Co-authored-by: Jorian <jorian@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @lukechilds