Add CircleCI config #6

lukechilds · 2018-01-09T09:42:03Z

Integrate with CircleCI, currently only for linting but potentially for building app releases in the future.

…working

sindresorhus · 2018-01-09T10:01:43Z

If we want to do automated builds, we have to use version 1 of the config, as version 2 doesn't support macOS yet.

lukechilds · 2018-01-09T10:03:17Z

Ah, ok. Are you able to take over on this if you've done it before then?

I just wanted to play with CircleCI 😂

Really need to crack on with CLI testing.

sindresorhus · 2018-01-09T10:07:09Z

Will do

sindresorhus · 2018-01-09T20:09:28Z

Ok, so turns CircleCI added support for macOS in v2 since the last time I tried it, but macOS support is not included the free plan. What do you want to do? If this project is planned to be open source, we can just do automated Linux and Windows builds for now, and do macOS builds when it's open source.

lukechilds · 2018-01-10T01:39:52Z

Yeah, that makes sense.

I love Travis (and now Circle) and would love to support them, but tbh for a project of this size and scale the pricing seems pretty unreasonable.

lukechilds · 2018-01-10T01:41:35Z

BTW, just out of interest, is it possible to automatically build files from CI and have CI upload them to a GitHub release pages?

So we just do a new GitHub release and CI handles the rest?

Not particularly important but would be cool af. Especially nice considering we might not be maintaining this project long term.

sindresorhus · 2018-01-10T01:57:09Z

BTW, just out of interest, is it possible to automatically build files from CI and have CI upload them to a GitHub release pages? So we just do a new GitHub release and CI handles the rest?

Yes, that's exactly what's already implemented in master for Travis, and in this PR for CircleCI. electron-builder takes care of building and uploading to a new GitHub release.

lukechilds · 2018-01-10T01:58:43Z

Awesome, any preference over Travis or Circle?

sindresorhus · 2018-01-10T02:02:12Z

You wanted CircleCI because it's free for private, right?

sindresorhus · 2018-01-10T02:03:14Z

It requires some more work to build for Windows and Linux on Linux. I'll look into it later. Need to adapt https://github.com/develar/onshape-desktop-shell/blob/675ec6d9b149866bfdafad30e3d251047e31b31c/.travis.yml#L34-L40 to CircleCI's Docker running thing.

lukechilds · 2018-01-10T02:07:45Z

You wanted CircleCI because it's free for private, right?

Yeah, but if it's a pain to setup automated build don't worry about it, just making sure yarn dist doesn't fail should be enough for now. We can just build manually for sending builds to Pondsea to test, I think he might even be comfortable using git and building himself.

Automated builds -> GH Release is only important once we're public so if that's simpler on Travis we can just switch to Travis at that point when we're public.

sindresorhus · 2018-01-10T02:11:58Z

Automated builds -> GH Release is only important once we're public so if that's simpler on Travis we can just switch to Travis at that point when we're public.

Yeah, ok, let's do that. It's simple enough to build locally for testing.

sindresorhus · 2018-01-10T02:13:17Z

Yeah, but if it's a pain to setup automated build don't worry about it, just making sure yarn dist doesn't fail should be enough for now.

Can't easily do that with CircleCI, as that runs on Linux, which requires the Docker thing, which is more work. But we can at least run linting on CircleCI for now, if that's ok?

lukechilds · 2018-01-10T03:48:23Z

It was working with my previous commit: 97c97ad

or does pack not do what I think it does?

sindresorhus · 2018-01-10T07:46:00Z

It was working with my previous commit: 97c97ad

According to the electron-builder docs it needs some apt packages installed, but I guess they already are on CircleCI.

or does pack not do what I think it does?

pack builds for the current platform and only the app, while dist builds for all platforms including the distribution formats like installers. Happy to improve the naming if you have any suggestions.

lukechilds · 2018-01-10T07:58:31Z

pack builds for the current platform and only the app, while dist builds for all platforms including the distribution formats like installers. Happy to improve the naming if you have any suggestions.

Personally I would say build is more clear. build and dist seem like a more clear distinctions purely because build is common for web projects which I'm more used to. pack and dist are easier to confuse IMO but if that's common terminology in Electron then happy to keep it, I'm sure it won't take long to get used to.

sindresorhus · 2018-01-10T09:23:00Z

build makes it seem like you're building everything to me. pack really just means, pack the JS in the Electron binary. How electron-builder works, is that it takes the Electron app bundle, which is just really an Electron demo app, and just adds in your resources and changes the metadata files. So it's really just packing our files into the Electron app bundle, but I can see how that doesn't make sense if you don't know how Electron apps are built.

lukechilds · 2018-01-10T09:35:06Z

Cool, lets stick with pack then 👍

* [started #615] use-the-concept-of-orders-instead-of-swaps * debug * - Add new format-order-data file - Add some unit test * db: rename swaps2 to orders2 * api: Add myOrders method * api: Add cancelAllOrders method * orders data: update type of order * db: Add removeOrder method in DB * add formatOrder and formatSwap data * test case: taker order is filled in 30s * test case: maker order can has mutil swaps * test case: maker order is filled * swaplist: fix order css * swap-db.js: remove getSwapCount func and add getOrdersCount * Order: cancel all pair orders before create a new one * Dashboard: update ActivityList * fix bug: swap not found * ui: update swap Detail modal * ui: update SwapList * remove unused file * fix #5: steps of swap show wrong amount * fix #6: add cancel button for open order * fix #4: trade history shows ongoing trade as completed * fix #15: replace CHIPS with BTC as always-enabled-coin * fix #3 sort orders based on price * fix #9 trade history shows cancelled orders as completed * fix #18: replace todo text when restoring seed phrase * fix #13 update HUSH * fix #13 rename InstantDEX to DEX * fix #13 add BET * fix #13 disable BET * fix #12 disabling a coin should be possible again * fix #17 ERC20 swaps give wrong error when ETH funds lack * remove annoying log * add base variable * fix #19 order not cancellable, not in mm2.0 response but still visible * fix #27 withdraw confirmation screen shows wrong information * fix #28 withdraw full balance not working * fix #22 clicking Price in orderbook section populates a too high buy Price * add BET * add HODL, disable HODLC * add HUSH * add preliminary MGW support * let nonofficial mm2 coins still be enabled through electrum * enable MGW, add COMMOD * add LABS * add BUSD, GIN, USDC * re-enable OOT * update VRSC daemons * remove dead GIN electrum * remove dead coins (#34) Co-authored-by: Jorian <jorian@outlook.com>

lukechilds added 2 commits January 9, 2018 16:36

Add CircleCI config

2ede3fb

Actually, don't cache deps we always wanna double check yarn.lock is …

11ce555

…working

lukechilds force-pushed the circleci branch 2 times, most recently from 1ed9696 to ec73e6b Compare January 9, 2018 09:53

lukechilds added 2 commits January 9, 2018 16:55

Don't explicitly set working_directory

09203a7

Remove default config comments

86f90e2

lukechilds force-pushed the circleci branch from a8f3f2e to 86f90e2 Compare January 9, 2018 09:56

Test packaging works

97c97ad

lukechilds requested a review from sindresorhus January 9, 2018 10:01

sindresorhus added 2 commits January 9, 2018 11:50

Also build the app

761f56a

Try without workflows

222b877

Revert my changes

45a6c45

Update config.yml

c2f505d

sindresorhus merged commit f005455 into master Jan 10, 2018

sindresorhus deleted the circleci branch January 10, 2018 07:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CircleCI config #6

Add CircleCI config #6

lukechilds commented Jan 9, 2018

sindresorhus commented Jan 9, 2018 •

edited

Loading

lukechilds commented Jan 9, 2018

sindresorhus commented Jan 9, 2018

sindresorhus commented Jan 9, 2018

lukechilds commented Jan 10, 2018

lukechilds commented Jan 10, 2018 •

edited

Loading

sindresorhus commented Jan 10, 2018

lukechilds commented Jan 10, 2018

sindresorhus commented Jan 10, 2018

sindresorhus commented Jan 10, 2018 •

edited

Loading

lukechilds commented Jan 10, 2018 •

edited

Loading

sindresorhus commented Jan 10, 2018

sindresorhus commented Jan 10, 2018

lukechilds commented Jan 10, 2018

sindresorhus commented Jan 10, 2018 •

edited

Loading

lukechilds commented Jan 10, 2018

sindresorhus commented Jan 10, 2018

lukechilds commented Jan 10, 2018

Add CircleCI config #6

Add CircleCI config #6

Conversation

lukechilds commented Jan 9, 2018

sindresorhus commented Jan 9, 2018 • edited Loading

lukechilds commented Jan 9, 2018

sindresorhus commented Jan 9, 2018

sindresorhus commented Jan 9, 2018

lukechilds commented Jan 10, 2018

lukechilds commented Jan 10, 2018 • edited Loading

sindresorhus commented Jan 10, 2018

lukechilds commented Jan 10, 2018

sindresorhus commented Jan 10, 2018

sindresorhus commented Jan 10, 2018 • edited Loading

lukechilds commented Jan 10, 2018 • edited Loading

sindresorhus commented Jan 10, 2018

sindresorhus commented Jan 10, 2018

lukechilds commented Jan 10, 2018

sindresorhus commented Jan 10, 2018 • edited Loading

lukechilds commented Jan 10, 2018

sindresorhus commented Jan 10, 2018

lukechilds commented Jan 10, 2018

sindresorhus commented Jan 9, 2018 •

edited

Loading

lukechilds commented Jan 10, 2018 •

edited

Loading

sindresorhus commented Jan 10, 2018 •

edited

Loading

lukechilds commented Jan 10, 2018 •

edited

Loading

sindresorhus commented Jan 10, 2018 •

edited

Loading