Add BarterDEX API client #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lukechilds
commented
Jan 8, 2018
| this.userpass = await this._userpass(); | ||
| } | ||
|
|
||
| return this._request(Object.assign({}, data, {userpass: this.userpass})); |
There was a problem hiding this comment.
Would be nice if we could use object destructuring here:
this._request({userpass: this.userpass, ...data});Is Electron really that out of date!?
There was a problem hiding this comment.
Wouldn't matter. Webpack can't handle it anyway. And I don't think it's worth complicating things by transpiling just for that.
There was a problem hiding this comment.
No definitely not, was just expecting it to work.
sindresorhus
added a commit
that referenced
this pull request
Jan 8, 2018
jorian
added a commit
that referenced
this pull request
Feb 26, 2020
* [started #615] use-the-concept-of-orders-instead-of-swaps * debug * - Add new format-order-data file - Add some unit test * db: rename swaps2 to orders2 * api: Add myOrders method * api: Add cancelAllOrders method * orders data: update type of order * db: Add removeOrder method in DB * add formatOrder and formatSwap data * test case: taker order is filled in 30s * test case: maker order can has mutil swaps * test case: maker order is filled * swaplist: fix order css * swap-db.js: remove getSwapCount func and add getOrdersCount * Order: cancel all pair orders before create a new one * Dashboard: update ActivityList * fix bug: swap not found * ui: update swap Detail modal * ui: update SwapList * remove unused file * fix #5: steps of swap show wrong amount * fix #6: add cancel button for open order * fix #4: trade history shows ongoing trade as completed * fix #15: replace CHIPS with BTC as always-enabled-coin * fix #3 sort orders based on price * fix #9 trade history shows cancelled orders as completed * fix #18: replace todo text when restoring seed phrase * fix #13 update HUSH * fix #13 rename InstantDEX to DEX * fix #13 add BET * fix #13 disable BET * fix #12 disabling a coin should be possible again * fix #17 ERC20 swaps give wrong error when ETH funds lack * remove annoying log * add base variable * fix #19 order not cancellable, not in mm2.0 response but still visible * fix #27 withdraw confirmation screen shows wrong information * fix #28 withdraw full balance not working * fix #22 clicking Price in orderbook section populates a too high buy Price * add BET * add HODL, disable HODLC * add HUSH * add preliminary MGW support * let nonofficial mm2 coins still be enabled through electrum * enable MGW, add COMMOD * add LABS * add BUSD, GIN, USDC * re-enable OOT * update VRSC daemons * remove dead GIN electrum * remove dead coins (#34) Co-authored-by: Jorian <jorian@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from #4 to run in the render process.
I've left
marketmakerout for this PR to simplify things.You'll need to run it first with: