Make the login functional #18
Conversation
|
@lukechilds This PR has a lot of wide-reaching changes, so I'm gonna merge right away again, so it won't block you from working on stuff and you won't create a lot of merge conflicts for me. Give your feedback on this PR and I'll fix it in a follow-up PR. Hope that's ok :) |
| const {portfolio} = this.props; | ||
| const {api} = portfolio; | ||
|
|
||
| (async () => { |
There was a problem hiding this comment.
I'm just using async here for simplicity. We can add some nice loading indicators later on.
| render() { | ||
| return ( | ||
| <TabView {...this.props} title="Dashboard"> | ||
| <p>Portfolio: {JSON.stringify(this.state.mmPortfolio, null, '\t')}</p> |
There was a problem hiding this comment.
This is just a demo.
| portfolioData.api = await initApi(portfolioData.seedPhrase); | ||
| this.props.setPortfolio(portfolioData); | ||
|
|
||
| // TODO: Fix the routing so this can be removed |
There was a problem hiding this comment.
I'm gonna look into this one later.
|
|
||
| this.input.value = ''; | ||
|
|
||
| const passwordError = /Authentication failed/.test(err.message) ? "Incorrect password" : err.message; |
There was a problem hiding this comment.
This is ugly I know, but I didn't know how you wanted to handle it?
| } | ||
|
|
||
| render() { | ||
| if (this.state.portfolios.length === 0) { |
There was a problem hiding this comment.
Was thinking about having a loading indicator here, but the async is so fast, it would just flicker, so I didn't see the point.
There was a problem hiding this comment.
This would mean if they don't have any portfolios yet it will show a loading spinner forever.
Also, currently with that conditional nothing will render if they don't have any portfolios so they won't be able to click the button to create their first one.
I'm already handling conditional portfolio display here: https://github.com/lukechilds/hyperdex/blob/205303dd3835052bae28521c32af498c16aff419/app/renderer/components/login.js#L156-L163
| } | ||
|
|
||
| .portfolios { | ||
| text-align: center; | ||
| } | ||
|
|
||
| .portfolio-item-container { | ||
| display: flex; |
|
Good stuff 👌
Yeah, I keep getting carried away on details when I know really we just wanna be focusing on the core |
|
+1 for |
* [started #615] use-the-concept-of-orders-instead-of-swaps * debug * - Add new format-order-data file - Add some unit test * db: rename swaps2 to orders2 * api: Add myOrders method * api: Add cancelAllOrders method * orders data: update type of order * db: Add removeOrder method in DB * add formatOrder and formatSwap data * test case: taker order is filled in 30s * test case: maker order can has mutil swaps * test case: maker order is filled * swaplist: fix order css * swap-db.js: remove getSwapCount func and add getOrdersCount * Order: cancel all pair orders before create a new one * Dashboard: update ActivityList * fix bug: swap not found * ui: update swap Detail modal * ui: update SwapList * remove unused file * fix #5: steps of swap show wrong amount * fix #6: add cancel button for open order * fix #4: trade history shows ongoing trade as completed * fix #15: replace CHIPS with BTC as always-enabled-coin * fix #3 sort orders based on price * fix #9 trade history shows cancelled orders as completed * fix #18: replace todo text when restoring seed phrase * fix #13 update HUSH * fix #13 rename InstantDEX to DEX * fix #13 add BET * fix #13 disable BET * fix #12 disabling a coin should be possible again * fix #17 ERC20 swaps give wrong error when ETH funds lack * remove annoying log * add base variable * fix #19 order not cancellable, not in mm2.0 response but still visible * fix #27 withdraw confirmation screen shows wrong information * fix #28 withdraw full balance not working * fix #22 clicking Price in orderbook section populates a too high buy Price * add BET * add HODL, disable HODLC * add HUSH * add preliminary MGW support * let nonofficial mm2 coins still be enabled through electrum * enable MGW, add COMMOD * add LABS * add BUSD, GIN, USDC * re-enable OOT * update VRSC daemons * remove dead GIN electrum * remove dead coins (#34) Co-authored-by: Jorian <jorian@outlook.com>
The login is now fully functional \o/ I've even added some info to the dashboard to show that the API communication works. Marketmaker is now only started on login and stopped on logout. I've implemented the
Log Outbutton in the HyperDEX menubar menu (Try it out).I moved all the logic for getting all the portfolios to
<Login/>, as<App/>doesn't need the knowledge. All<App/>cares about is the active portfolio. This can also help us prevent leaks between portfolios, although farfetched.Known issues:
None of the known issues are blockers though, but rather things we can perfect later on when the core functionality is done.