Add marketmaker URL preference #13
Conversation
| <input | ||
| name="marketmakerUrl" | ||
| value={this.state.marketmakerUrl} | ||
| onChange={this.handleChange.bind(this)} |
There was a problem hiding this comment.
is onChange a good event for this?
I don't think we should overwrite the URL in the config until they manually click a button like save or something.
There was a problem hiding this comment.
It's normal behavior for native apps to live save. Just try any preference on macOS. But I can change it to save on blur instead.
There was a problem hiding this comment.
You're more familiar with native dev than me so if you say it's normal behaviour then I'm happy to go with it.
There was a problem hiding this comment.
Actually, can't use blur as it's not triggered in many scenarios, like app restart. But I've added debouncing so it should be good now.
There was a problem hiding this comment.
For example, Safari prefs. No save button:
There was a problem hiding this comment.
No need for debouncing if you don't think it's necessary 👍
There was a problem hiding this comment.
Debouncing can be good as we don't write to fs for every character.
* [started #615] use-the-concept-of-orders-instead-of-swaps * debug * - Add new format-order-data file - Add some unit test * db: rename swaps2 to orders2 * api: Add myOrders method * api: Add cancelAllOrders method * orders data: update type of order * db: Add removeOrder method in DB * add formatOrder and formatSwap data * test case: taker order is filled in 30s * test case: maker order can has mutil swaps * test case: maker order is filled * swaplist: fix order css * swap-db.js: remove getSwapCount func and add getOrdersCount * Order: cancel all pair orders before create a new one * Dashboard: update ActivityList * fix bug: swap not found * ui: update swap Detail modal * ui: update SwapList * remove unused file * fix #5: steps of swap show wrong amount * fix #6: add cancel button for open order * fix #4: trade history shows ongoing trade as completed * fix #15: replace CHIPS with BTC as always-enabled-coin * fix #3 sort orders based on price * fix #9 trade history shows cancelled orders as completed * fix #18: replace todo text when restoring seed phrase * fix #13 update HUSH * fix #13 rename InstantDEX to DEX * fix #13 add BET * fix #13 disable BET * fix #12 disabling a coin should be possible again * fix #17 ERC20 swaps give wrong error when ETH funds lack * remove annoying log * add base variable * fix #19 order not cancellable, not in mm2.0 response but still visible * fix #27 withdraw confirmation screen shows wrong information * fix #28 withdraw full balance not working * fix #22 clicking Price in orderbook section populates a too high buy Price * add BET * add HODL, disable HODLC * add HUSH * add preliminary MGW support * let nonofficial mm2 coins still be enabled through electrum * enable MGW, add COMMOD * add LABS * add BUSD, GIN, USDC * re-enable OOT * update VRSC daemons * remove dead GIN electrum * remove dead coins (#34) Co-authored-by: Jorian <jorian@outlook.com>
Looks ugly, but it's fine for now, until we start implementing the design.