Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.91.0 #13211

Merged
merged 48 commits into from
Feb 23, 2021
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
a14c9da
chore(deps-dev): bump standard-version from 9.1.0 to 9.1.1 (#13124)
dependabot-preview[bot] Feb 17, 2021
46bd676
chore(deps): bump aws-sdk from 2.845.0 to 2.846.0 (#13117)
dependabot-preview[bot] Feb 17, 2021
1d0cfe1
Merge branch 'master' into merge-back/1.90.0
mergify[bot] Feb 18, 2021
25e6624
chore(merge-back): 1.90.0 (#13126)
mergify[bot] Feb 18, 2021
7a135b5
chore(deps-dev): bump esbuild from 0.8.46 to 0.8.47 (#13128)
dependabot-preview[bot] Feb 18, 2021
e042879
fix(eks): Deployment fails for the first deployment in an account (#1…
iliapolo Feb 18, 2021
384ce44
docs(rds): fix weird rendering of socketAddress property in Endpoint …
skinny85 Feb 18, 2021
a84b76a
docs: fix typos in CONTRIBUTING.md (#13116)
SoManyHs Feb 18, 2021
09afed5
feat(lambda): Code.fromDockerBuildAsset (#12258)
jogold Feb 18, 2021
a1ca3c4
chore(deps-dev): bump esbuild from 0.8.47 to 0.8.48 (#13135)
dependabot-preview[bot] Feb 18, 2021
13c9859
feat(cfnspec): cloudformation spec v28.0.0 (#13101)
aws-cdk-automation Feb 18, 2021
f7a426d
docs(s3-deployment): Reflect new stability of CloudFront and completi…
robertd Feb 18, 2021
1ce7df8
chore: enable feature flags on all integ tests (#13133)
Feb 18, 2021
3fb4600
feat(ecs-patterns): Add support for assignPublicIp for QueueProcessin…
lgvo Feb 18, 2021
ba0d1b5
chore(deps): bump aws-sdk from 2.846.0 to 2.847.0 (#13138)
dependabot-preview[bot] Feb 18, 2021
785f2f4
chore(deps-dev): bump @types/node from 10.17.52 to 10.17.53 (#13140)
dependabot-preview[bot] Feb 18, 2021
1b487cf
chore(deps-dev): bump @octokit/rest from 18.1.1 to 18.2.0 (#13141)
dependabot-preview[bot] Feb 19, 2021
cd7a3ed
fix(core): ENOTDIR invalid cwd on "cdk deploy" (#13145)
Feb 19, 2021
0c90693
chore(deps-dev): bump esbuild from 0.8.48 to 0.8.49 (#13149)
dependabot-preview[bot] Feb 19, 2021
b92188d
chore(cdk): remove expired feature flags from init templates (#13085)
Feb 19, 2021
daf4e47
fix(cfn-diff): handle Fn::If inside policies and statements (#12975)
skinny85 Feb 19, 2021
1da564e
chore(deps-dev): bump @types/node from 10.17.53 to 10.17.54 (#13161)
dependabot-preview[bot] Feb 19, 2021
96728aa
docs(appsync): fix argument in Values.projecting() call (#12855)
Feb 19, 2021
f92b65e
feat(aws-appsync): add databaseName to rdsDataSource (#12575)
monholm Feb 19, 2021
3cac1d1
Merge branch 'master' into merge-back/1.90.1
mergify[bot] Feb 20, 2021
c1f8da0
chore(merge-back): 1.90.1 (#13166)
mergify[bot] Feb 20, 2021
91366dd
chore(deps): bump aws-sdk from 2.847.0 to 2.848.0 (#13162)
dependabot-preview[bot] Feb 20, 2021
8f1cfe4
chore(deps-dev): bump lodash from 4.17.20 to 4.17.21 (#13171)
dependabot-preview[bot] Feb 20, 2021
c5e8b6d
fix(eks): `KubectlProvider` creates un-necessary security group (#13178)
iliapolo Feb 21, 2021
354306a
docs(s3-deployment): cleanup (#13143)
robertd Feb 21, 2021
17c05bc
chore(eks): Misplaced paragraph about endpoint access in the README (…
iliapolo Feb 21, 2021
eb0aabf
chore(s3): Default value documentation of `blockPublicAccess` is misl…
iliapolo Feb 21, 2021
b1c0437
chore(deps-dev): bump esbuild from 0.8.49 to 0.8.50 (#13185)
dependabot-preview[bot] Feb 21, 2021
6aac3b6
feat(synthetics): Update CloudWatch Synthetics NodeJS runtimes (#12907)
naamancampbell Feb 21, 2021
d35f032
fix(appsync): revert to allow resolver creation from data source (#12…
BryanPan342 Feb 22, 2021
0b3826a
chore: npm-check-updates && yarn upgrade (#13190)
NetaNir Feb 22, 2021
a349bf1
chore: do not use Dependabot for npm dependencies (#13047)
Feb 22, 2021
2281592
chore: fix invalid dependabot config (#13194)
Feb 22, 2021
bd3d666
chore(deps): bump actions/cache from v2 to v2.1.4 (#13196)
dependabot[bot] Feb 22, 2021
aaec660
chore(ecs): migrate tests to jest (#13198)
Feb 22, 2021
6ee2eb4
docs(aws-kms): Use back tickets in documentation (#13199)
michaelbrewer Feb 22, 2021
5a54741
fix: UserPool, Volume, ElasticSearch, FSx are now RETAIN by default (…
rix0rrr Feb 22, 2021
745fc22
docs(stepfunctions-task): fix sagemaker training job example (#12727)
zxkane Feb 22, 2021
45cf387
fix(aws-appsync): use serverlessCluster on rdsDataSource (#13206)
monholm Feb 22, 2021
296a10d
feat(stepfunctions-tasks): add EKS call to SFN-tasks (#12779)
NovakGu Feb 22, 2021
520c263
fix(lambda-nodejs): invalid sample in documentation (#12404)
mmuller88 Feb 23, 2021
bb73816
chore(release): 1.91.0
Feb 23, 2021
a694f52
Update CHANGELOG.md
rix0rrr Feb 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(appsync): revert to allow resolver creation from data source (#12973
)

* Revert to old behavior of allowing a data source to create a resolver as UNIT resolvers stem from data sources.
* Maintaining new behavior of having `GraphqlApi` create resolvers as PIPELINE resolvers stem from the `GraphqlApi` itself

Fixes #12635
Fixes #11522

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
BryanPan342 authored Feb 22, 2021
commit d35f03226d6d7fb5be246b4d3584ee9205b0ef2d
6 changes: 5 additions & 1 deletion packages/@aws-cdk/aws-appsync/lib/data-source.ts
Original file line number Diff line number Diff line change
@@ -126,7 +126,11 @@ export abstract class BaseDataSource extends CoreConstruct {
* creates a new resolver for this datasource and API using the given properties
*/
public createResolver(props: BaseResolverProps): Resolver {
return this.api.createResolver({ dataSource: this, ...props });
return new Resolver(this, `${props.typeName}${props.fieldName}Resolver`, {
api: this.api,
dataSource: this,
...props,
});
}

/**
3 changes: 1 addition & 2 deletions packages/@aws-cdk/aws-appsync/test/appsync.test.ts
Original file line number Diff line number Diff line change
@@ -55,8 +55,7 @@ test('appsync should error when creating pipeline resolver with data source', ()

// THEN
expect(() => {
api.createResolver({
dataSource: ds,
ds.createResolver({
typeName: 'test',
fieldName: 'test2',
pipelineConfig: [test1, test2],
Original file line number Diff line number Diff line change
@@ -135,7 +135,7 @@
}
}
},
"ApiQuerygetTestsResolver025B8E0A": {
"ApidsQuerygetTestsResolver952F49EE": {
"Type": "AWS::AppSync::Resolver",
"Properties": {
"ApiId": {
@@ -152,7 +152,7 @@
"Apids0DB53FEA"
]
},
"ApiMutationaddTestResolver7A08AE91": {
"ApidsMutationaddTestResolverBCF0400B": {
"Type": "AWS::AppSync::Resolver",
"Properties": {
"ApiId": {
Original file line number Diff line number Diff line change
@@ -121,7 +121,7 @@
}
}
},
"ApiQuerygetTestsResolver025B8E0A": {
"ApitestDataSourceQuerygetTestsResolverA3BBB672": {
"Type": "AWS::AppSync::Resolver",
"Properties": {
"ApiId": {
@@ -142,7 +142,7 @@
"ApitestDataSource96AE54D5"
]
},
"ApiMutationaddTestResolver7A08AE91": {
"ApitestDataSourceMutationaddTestResolver36203D6B": {
"Type": "AWS::AppSync::Resolver",
"Properties": {
"ApiId": {
Original file line number Diff line number Diff line change
@@ -150,7 +150,7 @@
}
}
},
"ApiQuerygetTestResolver4C1F8B0C": {
"ApidsQuerygetTestResolverCCED7EC2": {
"Type": "AWS::AppSync::Resolver",
"Properties": {
"ApiId": {
@@ -171,7 +171,7 @@
"ApiSchema510EECD7"
]
},
"ApiQuerygetTestsResolver025B8E0A": {
"ApidsQuerygetTestsResolver952F49EE": {
"Type": "AWS::AppSync::Resolver",
"Properties": {
"ApiId": {
@@ -192,7 +192,7 @@
"ApiSchema510EECD7"
]
},
"ApiMutationaddTestResolver7A08AE91": {
"ApidsMutationaddTestResolverBCF0400B": {
"Type": "AWS::AppSync::Resolver",
"Properties": {
"ApiId": {
@@ -400,14 +400,12 @@
]
}
},
"Handler": "iam-query.handler",
"Role": {
"Fn::GetAtt": [
"LambdaIAM687B49AF",
"Arn"
]
},
"Runtime": "nodejs12.x",
"Environment": {
"Variables": {
"APPSYNC_ENDPOINT": {
@@ -417,7 +415,9 @@
]
}
}
}
},
"Handler": "iam-query.handler",
"Runtime": "nodejs12.x"
},
"DependsOn": [
"LambdaIAMDefaultPolicy96DEA124",
@@ -496,14 +496,12 @@
]
}
},
"Handler": "iam-query.handler",
"Role": {
"Fn::GetAtt": [
"testFailServiceRole9FF22F85",
"Arn"
]
},
"Runtime": "nodejs12.x",
"Environment": {
"Variables": {
"APPSYNC_ENDPOINT": {
@@ -513,7 +511,9 @@
]
}
}
}
},
"Handler": "iam-query.handler",
"Runtime": "nodejs12.x"
},
"DependsOn": [
"testFailServiceRole9FF22F85"
Loading