-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(appmesh): clarifying the difference between constructor and method to create a resource #15237
Conversation
… and method to crete a resource
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some small wording suggestions.
@skinny85 - Thanks for the corrections! They definitely look much better and easier to understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add support for Kinesis Streams in DynamoDB tables with a new `kinesisStreamArn` table option. Closes aws#14534 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…part fails (aws#15166) New-style ARNs are of the form `'arn:aws:s4:us-west-1:12345:/resource-type/resource-name'`. We didn't handle that correctly in `parseArn()`, and instead returned an `undefined` resource, which funnily enough should never happen according to our types. Introduce the concept of ARN formats, represented by an enum in core, and replace the `Stack.parseArn()` method by a new one `Stack.splitArn()`, taking that enum as a required second argument. Spotted in https://github.com/aws/aws-cdk/pull/15140/files#r653112073 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… its properties (aws#15208) We currently do not check if inputs are token when validating them which might throw errors if it is given a `ref`, adding them in here and corresponding unit tests that do not throw validation errors when given tokens with invalid inputs. Also updated one test which had mismatched description. Also moved core to qualified import for better consistency. Testing done ------------------ * `yarn build && yarn lint & yarn test` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…aws#15140) Service Catalog AppRegistry application construct initial base version. Please note the ARNS for this construct have two '/' in them hence the slightly different ARN parsing. Testing done ------------------ * `yarn build && yarn test` * `yarn integ` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>
The `rosetta/` directory contains fixtures that may be necessary to compile code examples, and the `.lit.ts` represents module documentation that may be necessary to generate the complete module documentation site from the published artifacts. Those hence need to be included in the npm package. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Removing the `BasicAuthConfig` property from the template doesn't remove the basic auth. Explicitely set `EnableBasicAuth` to `false` instead. Closes aws#15028 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When asked to convert full hours to human strings, due to floating point errors, they get rendered as minutes. 1 hour gets converted to 60 minutes. 2 hours converts to 1 hour 60 minutes. This request fixes that by first multiplying `amount` with the `fromUnit.inMillis` before dividing by `toUnit.inMillis`. This ensures that if the amount is big enough, it gets divided properly. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…hen endpoint is a token (aws#15219) `Domain.fromDomainAttributes` throws the error "Invalid URL" when a token endpoint is provided. In this PR, the domain name is retrieved from the scope using the arn present in `DomainAttributes`, and if no name is found, we try to get it from the endpoint (as it has been done so far). Also added a test to verify that the error disappears with this change, even when it is given token attributes. closes aws#15188 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…od to create a resource (aws#15237) This closes aws#10049. #### REV - Updating the doc for`.add...()` methods to specify that the resource is created in same stack where the `Mesh` exists - Updating `README` file to clarify the difference between using the constructor and method to create a resource. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This closes #10049.
REV
.add...()
methods to specify that the resource is created in same stack where theMesh
existsREADME
file to clarify the difference between using the constructor and method to create a resource.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license