Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(appmesh): clarifying the difference between constructor and method to create a resource #15237

Merged
merged 16 commits into from
Jun 22, 2021

Commits on Jun 21, 2021

  1. doc(appmesh): clarifying the difference between using the constructor…

    … and method to crete a resource
    Seiya6329 committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    002ea17 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Configuration menu
    Copy the full SHA
    57c9820 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df76a02 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbd2e64 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5db7861 View commit details
    Browse the repository at this point in the history
  5. feat(dynamodb): allow using Kinesis stream in Table (aws#15199)

    Add support for Kinesis Streams in DynamoDB tables with a new `kinesisStreamArn` table option.
    
    Closes aws#14534
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    rrhodes authored and Seiya6329 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    9087cf2 View commit details
    Browse the repository at this point in the history
  6. fix(core): parsing an ARN with a slash after a colon in the resource …

    …part fails (aws#15166)
    
    New-style ARNs are of the form `'arn:aws:s4:us-west-1:12345:/resource-type/resource-name'`.
    We didn't handle that correctly in `parseArn()`, and instead returned an `undefined` resource,
    which funnily enough should never happen according to our types.
    Introduce the concept of ARN formats,
    represented by an enum in core,
    and replace the `Stack.parseArn()` method by a new one `Stack.splitArn()`,
    taking that enum as a required second argument.
    
    Spotted in https://github.com/aws/aws-cdk/pull/15140/files#r653112073
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    skinny85 authored and Seiya6329 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    8d048d6 View commit details
    Browse the repository at this point in the history
  7. fix(servicecatalog): Portfolio fails validation when passed Tokens as…

    … its properties (aws#15208)
    
    We currently do not check if inputs are token when validating them which might throw errors
    if it is given a `ref`, adding them in here and corresponding unit tests that do not throw validation errors
    when given tokens with invalid inputs.
    
    Also updated one test which had mismatched description.
    
    Also moved core to qualified import for better consistency. 
    
    Testing done
    ------------------
    * `yarn build && yarn lint & yarn test`
    
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    arcrank authored and Seiya6329 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    3eb0232 View commit details
    Browse the repository at this point in the history
  8. feat(servicecatalogappregistry): initial L2 construct for Application (

    …aws#15140)
    
    Service Catalog AppRegistry application construct initial base version.
    Please note the ARNS for this construct have two '/' in them hence the slightly different ARN parsing.
    
    Testing done
    ------------------
    * `yarn build && yarn test`
    * `yarn integ`
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    
    
    
    Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>
    2 people authored and Seiya6329 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    ea5fd85 View commit details
    Browse the repository at this point in the history
  9. chore: package .lit.ts files and rosetta/ (aws#15064)

    The `rosetta/` directory contains fixtures that may be necessary to
    compile code examples, and the `.lit.ts` represents module documentation
    that may be necessary to generate the complete module documentation site
    from the published artifacts. Those hence need to be included in the npm
    package.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    RomainMuller authored and Seiya6329 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    26cf1f9 View commit details
    Browse the repository at this point in the history
  10. chore(assertions): fix build for nozem 0.11.0 (aws#15251)

    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    rix0rrr authored and Seiya6329 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c0bfb71 View commit details
    Browse the repository at this point in the history
  11. fix(amplify): deployment does not remove basic auth (aws#15243)

    Removing the `BasicAuthConfig` property from the template doesn't remove
    the basic auth. Explicitely set `EnableBasicAuth` to `false` instead.
    
    Closes aws#15028
    
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    jogold authored and Seiya6329 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    249c367 View commit details
    Browse the repository at this point in the history
  12. fix(core): 1 hour renders as 60 minutes (aws#15125)

    When asked to convert full hours to human strings, due to floating point errors, they get rendered as minutes. 1 hour gets converted to 60 minutes. 2 hours converts to 1 hour 60 minutes.
    
    This request fixes that by first multiplying `amount` with the `fromUnit.inMillis` before dividing by `toUnit.inMillis`. This ensures that if the amount is big enough, it gets divided properly.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    Dolvic authored and Seiya6329 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    d4bb09a View commit details
    Browse the repository at this point in the history
  13. fix(elasticsearch): Domain.fromDomainAttributes gives "Invalid URL" w…

    …hen endpoint is a token (aws#15219)
    
    `Domain.fromDomainAttributes` throws the error "Invalid URL" when a token endpoint is provided. In this PR, the domain name is retrieved from the scope using the arn present in `DomainAttributes`, and if no name is found, we try to get it from the endpoint (as it has been done so far). Also added a test to verify that the error disappears with this change, even when it is given token attributes.
    
    closes aws#15188
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    HelioStrike authored and Seiya6329 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    bc77be7 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    8c3a9f6 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    884d499 View commit details
    Browse the repository at this point in the history