Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.129.0 #17093

Merged
merged 39 commits into from
Oct 21, 2021
Merged

chore(release): 1.129.0 #17093

merged 39 commits into from
Oct 21, 2021

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Oct 21, 2021

See CHANGELOG

Niranjan Jayakar and others added 30 commits October 14, 2021 07:08
…ified (#16781)

Lambda insights is configured as a set of layers that are then
auto-added to the lambda function when the `insightsVersion` property is
specified.

However, Lambda functions deployed as container images cannot contain
layers. Instead, the user is expected to bring a container image with
the Insights agent pre-installed.

Update the CDK code, so that the layer is not added for Lambda functions
that use container images.

fixes #16642


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…16854)

The `defaultStage` prop in `HttpApi` returns `IHttpStage`.

The `domainUrl` getter was previously added only to `HttpStage`.
Elevate this to the `IHttpStage` level so it's available from the
`HttpApi`.

closes #16638


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ckage.json files if present (#16965)

This change was already approved and merged in: #16322. It somehow got removed from the `v2-main` branch since originally being merged. This PR is just a cherry-pick of the original commit. 

---

This change sets the `version` key in each alpha module's `package.json` file to the alphaVersion that was created in this PR: #16043

And, also sets the version of each dependency on another alpha module to the same version.

Depends on: #16321

Part of: #15591

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Draft PR because I have not compiled the snippets in `ORIGINAL_API.md`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for Apache Kafka version 2.8.1 in Amazon MSK.

Announcement: https://aws.amazon.com/about-aws/whats-new/2021/10/amazon-msk-support-apache-kafka-version-2-8-1/

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
closes #16633 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…16991)

Print the node of the CFN spec where validation fails, so the erroneous
part of the spec can be located.

Currently, when a Property in a PropertyType has two "Type" fields
specified, the message looks like below. Only the resource type being
validated is printed.

```
FAIL test/filtered-specification.test.js (8.522 s)
  filteredSpecification("AWS::Synthetics::Canary")

  expect(received).toEqual(expected)

  - Expected  - 1
  + Received  + 3

  - Array []
  + Array [
  +   "Type",
  + ]
```

With this change, the message will look like -

```
FAIL test/filtered-specification.test.js (8.522 s)
  filteredSpecification("AWS::Synthetics::Canary") › PropertyType AWS::Synthetics::Canary.ArtifactConfig › Property S3Encryption

  expect(received).toEqual(expected)

  - Expected  - 1
  + Received  + 3

  - Array []
  + Array [
  +   "Type",
  + ]
```


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#16997)

This is a fix for the region issue raised by #11199 allowing multi regional ecs deployments

fixes #11199

supersedes #15944, merged master and added tests

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…finish (#16983)

Motivation - On large tables, replication takes long time to complete. CloudFormation has a hard timeout of 1 hour on the Custom Resources, to bypass this, we want to have the replication continue in background based on a property.

Fixes #16611 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Refs:
1. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-eks-cluster-kubernetesnetworkconfig.html
2. https://docs.aws.amazon.com/eks/latest/APIReference/API_KubernetesNetworkConfigRequest.html#AmazonEKS-Type-KubernetesNetworkConfigRequest-serviceIpv4Cidr

Notes:
1. Currently I have not updated the integ tests since the deployed takes a lot of time and it requires inferentia service limit increase. Do you think this change needs an integ tests updating (tried it out locally and it succeeded till auto-scaling)? 
2. Couldn't find a good place in the Readme to add this feature. Would really help if we could come up with a good explanation and place for the same.

Closes #16541 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The presence of the legacy API for CDK Pipelines confuses people who
didn't read the README or the blog post, but go from a copy/pasted
example they found on the internet and then proceed to explore the API.

Clearly deprecate the legacy classes to avoid confusion.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…SageMakerCreateTrainingJobProps` (#16792)

Closes #16779.

This PR adds an option of `EnableNetworkIsolation` to `SageMakerCreateTrainingJob` class and enables a user to use AWS Marketplace.

[Doc](https://docs.aws.amazon.com/sagemaker/latest/dg/mkt-algo-model-internet-free.html) says a user must turn the option to True when they attempt to use a machine learning model from AWS Marketplace. 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Removed duplicate word in documentation. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is the current active LTS version and is a good minimum requirement.

Re-introduction of #11964. Fixes #16438


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
* chore: run issue cleanup action more frequently

This changes the issue cleanup action to run 6 times per day (once every
four hours) insted of only once per day.

* chore: create action documentation

Documents each of the GitHub actions in the repo and their owners
Partially fixes: #5137
Related PR: #16051

**Note:** I have some concerns about duplicated code between this and the above linked PR. Please see that PR for more details.

### Changes
Adds an aspect that can enable/disable IMDSv1 on AutoScalingGroups

### Testing
Added unit tests

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Turns out, `parseFloat()` in JavaScript is even crazier than we thought,
and returns nonsense like `2021` for a string containing a Date like `'2021-10-25'`.
For that reason, add an explicit check that the string parsed looks like a number before calling `parseFloat()`.

Fixes #16444

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ZONE_ID (#17024)


https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region, hashicorp/terraform-provider-aws#21337


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fix typographical errors in the spelling of 'subnet' in the ec2 & eks modules.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…us (#17008)

fixes an issue where the generate when needed marker was not being
passed through to the physicalName

fix #14337


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This causes a rather weird effect in the docs for this class:
https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-codepipeline-actions.ServiceCatalogDeployActionBeta1.html

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
feat(events-targets): Add DLQ support for SQS target

closes #16417 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add validation to domainName property as per  https://docs.aws.amazon.com/opensearch-service/latest/developerguide/configuration-api.html#configuration-api-datatypes-domainname

Fixes #17016 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…thwest-1 (#16836)

----
AppMesh is launched in 'cn-noth-1' and 'cn-northwest-1' regions.
These regions have separate accounts for storing Envoy images in ECR. Added the ECR account information.
These regions belong to new partition 'aws-cn', removed the harcoded 'aws' partition and modified it to work for all partitions.
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
jericht and others added 8 commits October 20, 2021 09:17
Partially fixes: #5137
Related PR: #16052

**Note:** This PR and the above related PR have common code that has been duplicated across these two PRs because I decided it made more sense for these Aspects to be in the same package with the constructs they work with. However, it means I had to duplicate some of the base class code across the two PRs. Looking for an opinion on what's better here:
- Should we keep it as is (2 PRs) so these Aspects are cleanly separated? or,
- Does it make sense to either combine them in some way (e.g. a new package `@aws-cdk/aspects`) or have one reference the other (maybe the AutoScalingGroup aspect can reference the code in this PR since it already depends on this package).

### Changes
Adds an aspect that can enable/disable IMDSv1 on Instances and Launch Templates.

### Testing
Added unit tests

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The yarn lock checking script was always wrong: it would assume a
package was local if its version number was `0.0.0`... but this is
no longer true after running `align-version.sh`.

I don't understand why this doesn't fail on the build server, but
it definitely fails for me on my machine when trying to do a full
build "as if" I was the build server.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This form of executing Rosetta is not mocked by the jsii integ tests
(which try executing a CDK build using a new version of the jsii tools).

The jsii integ tests rely on passing environment variables `$CDK_BUILD_JSII`,
`$PACMAK` and `$ROSETTA` (instead of replacing symlinks in the Node module farm).

This leads to the generation of `.jsii.tabl.json` during build using the
NPM-installed version of `jsii-rosetta`, which subsequently interferes with
the run of `$PACMAK` which *is* the new version (since Rosetta tablets
are supposed to be short-lived, there is no backwards compatibility guarantee
between different versions).

There will be a supported mechanism to achieve what this single post-build command is trying to achieve,
so remove it.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
If the directory is nested deeper than one level underneath `.` or `..`,
the wrong directory gets created.

Also add in protection against the directory already existing, in which
case the same behavior would happen.

Fixes #16936.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Co-authored-by: Otavio Macedo <otaviom@amazon.com>
…Dockerfile command `npm install [package]@[version]` (#17078)

## Summary

This PR fixes an issue where the package.json file used in `lambda-layer-node-proxy-agent` was not being bundled into monocdk / CDK v2. This is due to limitations of Ubergen. Ubergen only copies .ts  files, README.md  files and some special .json files.

This PR:
- Removes the package.json from `packages/@aws-cdk/lambda-layer-node-proxy-agent/layer`
- Adds a step in the layer's Dockerfile to install a specific version of `proxy-agent` i.e. `npm install [package]@[version]`. This is so that we can do without the `package.json` file while still managing which version we bundle with the layer.

Fixes: #17061

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation added the pr/no-squash This PR should be merged instead of squash-merging it label Oct 21, 2021
@gitpod-io
Copy link

gitpod-io bot commented Oct 21, 2021

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3987808
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@otaviomacedo otaviomacedo requested a review from a team October 21, 2021 14:04
@mergify mergify bot merged commit fb43f89 into release Oct 21, 2021
@mergify mergify bot deleted the bump/1.129.0 branch October 21, 2021 14:08
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2021

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.