-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): 1.41.0 #8125
Merged
Merged
chore(release): 1.41.0 #8125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Commit Message add support for subscription DLQ in SNS fixes #7623 ### End Commit Message ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
chore: merge release/1.40.0 to master
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.679.0 to 2.681.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.679.0...v2.681.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
… and SQS (#7946) merge functionality currently modeled under task and state into a single object that represents a task state as an abstract class. Service integrations extend the base class and add service specific configuration, metrics, and policies. this commit introduces the "new" service integrations for Lambda, SNS, and SQS Motivation: The current service integrations that are offered in `aws-stepfunctions-tasks` all currently implement a `bind()` method and contribute a portion of the configuration that creates a `Task` state. However, it's often useful to configure state level properties such as paths, retries, errors based on the service integration and the pattern that has been requested. Implementation: * Duplicate the current `Task` class and merge the properties of a task state and a task service integration into a new abstract base class. * Concrete implementation per service integration class where all of the best practices and user intents can be encoded * After all the service integrations have been migrated, we will want to retire the `Task` class as well since we don't want it to be instantiated. Paves the way for: #6715 by simplifying the invocation of service integration calls. We would be able to start adding properties such as retries and errors. #6489 where we will be making service integrations consistent ### End Commit Message ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
## Commit Message fix(autoscaling): setting mappingEnabled to true results in a deployment error fixes #7242 Currently it's impossible to disable a mapping because the volume property is required on a BlockDevice object. CloudFormation will fail at deploy time with a validation failure because NoDevice can not be present at the same time as Ebs or VirtualName. ## End Commit Message --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
### Commit Message feat(secretsmanager): adds grantWrite to Secret ### End Commit Message Implements: #7682 #### Testing I deployed the following: ``` #!/usr/bin/env node import * as cdk from '@aws-cdk/core'; import * as kms from '@aws-cdk/aws-kms'; import * as secretsmanager from '@aws-cdk/aws-secretsmanager'; import * as ec2 from '@aws-cdk/aws-ec2'; const app = new cdk.App(); const stack = new cdk.Stack(app, 'Stack', {}); const key = new kms.Key(stack, 'KMS'); const secret = new secretsmanager.Secret(stack, 'Secret', { encryptionKey: key }); const secret2 = new secretsmanager.Secret(stack, 'Secret2', {}); const vpc = ec2.Vpc.fromVpcAttributes(stack, 'Vpc', { vpcId: "vpc-XXXX", availabilityZones: [ "us-west-2a" ], publicSubnetIds: [ "subnet-XXXX" ], }); const instance = new ec2.BastionHostLinux(stack, 'Bastion', { vpc: vpc }); secret.grantRead(instance); secret.grantWrite(instance); secret2.grantRead(instance); secret2.grantWrite(instance); app.synth(); ``` Then, once the stack is deployed I used ssm to connect to the bastion and ran: ``` for secret in <secret name 1> <secret name 2> do aws --region us-west-2 secretsmanager put-secret-value --secret-id ${secret} --secret-string "FooValue" aws --region us-west-2 secretsmanager get-secret-value --secret-id ${secret} done ``` Finally, I verified the contents of the two secrets in the SecretsManager console. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Rarely there is a need to use a CloudFormation intrinsic in a JSON hash key. This is impossible since intrinsics are not strings. To circumvent that, CfnJson can be used to "delay" the rendition of the object using a simple custom resource which simply parses and reflects the input value as an attribute. Required in order to implement EKS IRSA (#8084) and other federated identity use cases. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Stacks that are being deployed using roles need to be deleted while the role is still present. Our test was deleting the role before the stack was being deleted, and so would fail. This was a race condition due to a missing `await`. Fix both. Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
eladb
added
the
pr/no-squash
This PR should be merged instead of squash-merging it
label
May 21, 2020
iliapolo
approved these changes
May 21, 2020
rix0rrr
approved these changes
May 21, 2020
Thank you for contributing! Your pull request will be updated from master and then merged automatically without squashing (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see CHANGELOG