This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Implements chrome.windows.create #10796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
short-term fix for #10573
Resolves #10457 Auditors: @bsclifton Test Plan: - covered by automated tests
fix #10754 test plan 1. go to https://jsfiddle.net/y3uw6q1w/ 2. right click the link and open in new tab 3. no siteInfo popup should appear 4. switch to the new tab 5. siteInfo popup should appear 6. switch to tab 1 and back to tab 2. the siteInfo popup should not appear.
and add some comments for security-sensitive code fix #10240
Fix error when codesign --verify
Create Widevine Resources.bundle for Brave Framework.sig
Closes #10813 Test Plan: 1. Open about:preferences#shields
Resolves #7032 Auditors: Test Plan:
Resolves #10822 Auditors: Test Plan:
Fixes bookmarksToolbar webdriver tests
Resolves #10824 Auditors: Test Plan:
Add support for Ubuntu Artful
Added release notes for 0.18.29
Fixes safebrowsing interception test
Add white-space: pre-wrap to fix #10119 Remove redundant styles Auditors: @cezaraugusto Test Plan: 1. Open https://jsfiddle.net/9o5tmgst/1/ 2. Make sure the lines are wrapped 3. Open https://jsfiddle.net/c5o7arqu/ 3. Make sure everything is properly alinged
Resolves #10829 Auditors: Test Plan:
Resolves #10828 Auditors: Test Plan:
Fixes cache problem with private tabs for siteSettings
Fix #11028 Auditors: NejcZdovc
Auditors: @luixxiul
Windows are restored with the correct z-index
Update siteInfo.js to the modified BEM style
- Cite reasons why we should consider BEM - Add a hint about naming Auditors: @cezaraugusto Test Plan:
by replacing form with div. Input element does not have to have form as a parent. Closes #8457 Follow-up to #8410 Auditors: @cezaraugusto Test Plan: 1. Run `npm run test -- --grep='can selectively allow scripts'` 2. disable scripts on twitter.com. the lock icon should not disappear 3. click noscript icon 4. open browser console. you should not see any CSP errors.
Closes #11111 Requires #10951 to make the shield button non-draggable Auditors: @cezaraugusto Test Plan: 1. Open brave.com 2. Enable NoScript 3. Enable an extension 4. Make sure NoScript button, the extension button, and publisher button is not draggable
make tabTitle work for gradient calc instead of tab
Update style.md
Replace span with BrowserButton on urlbar.js, etc.
changes file:// to chrome://brave Issue #11142 Auditors: @bridiver @diracdeltas @darkdh @jonathansampson fix whitespace
Auditors: @luixxiul Test Plan: npm run test -- --grep="new private tab signal creates a new private tab" npm run test -- --grep="Pins an existing frame" npm run test -- --grep="Uses the default tab color when one is not specified" npm run test -- --grep="shows siteInfo once when switching to a new tab" npm run test -- --grep="urlBarSuggestions" npm run test -- --grep="Closing pinned tabs" npm run test -- --grep="basic tab page functionality shows no tab pages when you have only 1 page" npm run test -- --grep="focuses active tab\'s page when closing last tab on page" npm run test -- --grep="close tab" npm run test -- --grep="webview previews when tab is hovered"
Auditors: @luixxiul Fix #11135 Test Plan: npm run test -- --grep="navigationBar tests favicon Parses favicon when one is present" npm run test -- --grep="navigationBar tests themeColor Uses the default tab color when one is not specified" npm run test -- --grep="tab tests tabs with icons shows tab's icon when page is not about:blank or about:newtab" npm run test -- --grep="tab tests tabs with icons unloaded tabs should display the specified favicon" npm run test -- --grep="tab tests webview in fullscreen mode keep favicon and title after exiting fullscreen mode" npm run test -- --grep="returns true for regular tabs"
- tests pass on macOS which is careless about capital letters but fails on other OSes Auditors: @bsclifton Test Plan: npm run test -- --grep="Tabs content - Favicon" npm run test -- --grep="Tabs content - NewSessionIcon"
Resolves #9517 Auditors: Test Plan:
Auditors: Test Plan:
…op into chrome.windows.create
|
hi @jonathansampson closing this one as stale, please re-open when you have a window. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Resolves #6789
Reviewer Checklist:
Tests