Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Chromium 65 on 0.21.x #13409

Merged
merged 11 commits into from
Mar 16, 2018
Merged

Chromium 65 on 0.21.x #13409

merged 11 commits into from
Mar 16, 2018

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 9, 2018 •
edited
Loading

Fixes #13358
Fixes #13357

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.21.x w/ Chromium 65 (Beta Channel) milestone Mar 9, 2018
@bsclifton bsclifton self-assigned this Mar 9, 2018
@bsclifton bsclifton mentioned this pull request Mar 9, 2018
Closed
@bsclifton
Copy link
Member Author

NOTE: after all work is done and this is approved/merged, we'll need to prepare a similar PR for master/0.23.x/0.22.x

@bsclifton bsclifton force-pushed the 0.21.x-C65 branch 3 times, most recently from 0d38e87 to be4ee3e Compare March 13, 2018 16:24
@codecov-io
Copy link

codecov-io commented Mar 14, 2018 •
edited
Loading

Codecov Report

Merging #13409 into 0.21.x will increase coverage by 0.01%.
The diff coverage is 11.76%.

@@            Coverage Diff             @@
##           0.21.x   #13409      +/-   ##
==========================================
+ Coverage    57.1%   57.11%   +0.01%     
==========================================
  Files         280      280              
  Lines       27495    27496       +1     
  Branches     4470     4470              
==========================================
+ Hits        15700    15704       +4     
+ Misses      11795    11792       -3
Flag Coverage Δ
#unittest 57.11% <11.76%> (+0.01%) ⬆️
Impacted Files Coverage Δ
app/filtering.js 18.51% <ø> (+0.15%) ⬆️
app/renderer/components/common/browserButton.js 95.34% <ø> (ø) ⬆️
app/browser/tabs.js 25.88% <ø> (+0.1%) ⬆️
js/constants/appConfig.js 100% <ø> (ø) ⬆️
js/constants/windowConstants.js 100% <ø> (ø) ⬆️
js/stores/windowStore.js 27.63% <0%> (-0.17%) ⬇️
js/actions/windowActions.js 5% <0%> (-0.06%) ⬇️
app/browser/reducers/ledgerReducer.js 44.33% <28.57%> (+0.17%) ⬆️
app/common/state/contextMenuState.js 39.02% <28.57%> (+1.18%) ⬆️
... and 2 more

bsclifton and others added 11 commits March 15, 2018 23:46
@bsclifton
Update Muon version to 4.9.2
db97bb4 
Fixes #13357

Auditors: @bridiver, @darkdh
@bsclifton
Update Muon and Chromedriver for Chromium 65
bfda54c 
- bump nan to 2.8.0
- update level

Auditors: @darkdh
@hferreiro @bsclifton
Use the new Muon crash reporting API
edca175 
brave/muon@c155e50
@bsclifton
Newer node version on Windows was choking with error when empty array…
b48f53d 
…: `TypeError: "file" argument must be a non-empty string`

Auditors: @darkdh
@bsclifton
Fix border issue on Brave buttons
3c8d2fb 
Fixes #13371

Auditors: @bradleyrichter, @cezaraugusto
@bsclifton
Resize viewport associated with SVGs to 11x11. For some reason, DPI >…
298f8ab 
… 100% was not scaling these properly (chopping off 1 pixel).

Tested on 100% DPI and 125% DPI

Fixes #13349

Auditors: @srirambv, @petemill
@cezaraugusto @bsclifton
make bookmarked item content respect parent's contextMenu size
5ed8630 
-
fix #13373
@darkdh @bsclifton
Avoid serializing Function in array template
77e3671 
fix #13421
fix #11576

Auditors: @bridiver

Test Plan:
1. Set `sessionSaveInterval` to `1` in js/constants/appConfig.js
2. Playing around with bookmark toolbar folder
3. Playing around with auotfill menu(fill with entry and clear)
4. Playing around with hamburger menu
5. Playing around with back/forward long pressed menu
6. There shouldn't be any exceptions about "function can be cloned"
@ltilve @bsclifton
Move close download fix to muon
861b22e
@darkdh @bsclifton
Add BRAVE_SESSION_SAVE_INTERVAL for release test
86bfed2 
(interval measure is second)

Auditors: @bsclifton

Test Plan:
1. Put env BRAVE_SESSION_SAVE_INTERVAL=1 before executing Brave
2. See session file should be modified every seconds
@darkdh @bsclifton
Deprecate did-get-response-details
338fb4e 
brave/muon@00d729f

Auditors: @bridiver, @bsclifton, @NejcZdovc
@bsclifton bsclifton requested review from darkdh and bridiver March 16, 2018 06:52
darkdh
darkdh approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 8b8bd18 into 0.21.x Mar 16, 2018
@bsclifton bsclifton deleted the 0.21.x-C65 branch March 16, 2018 06:58
@bsclifton bsclifton mentioned this pull request Mar 16, 2018
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkdh darkdh darkdh approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
0.21.x w/ Chromium 65 (Release Channel)
Development

Successfully merging this pull request may close these issues.
6 participants
@bsclifton @codecov-io @darkdh @hferreiro @cezaraugusto @ltilve