This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
C65 master #13473
Merged
C65 master #13473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump nan to 2.8.0 - update level Auditors: @darkdh
…: `TypeError: "file" argument must be a non-empty string` Auditors: @darkdh
Fixes #13371 Auditors: @bradleyrichter, @cezaraugusto
fix #13421 fix #11576 Auditors: @bridiver Test Plan: 1. Set `sessionSaveInterval` to `1` in js/constants/appConfig.js 2. Playing around with bookmark toolbar folder 3. Playing around with auotfill menu(fill with entry and clear) 4. Playing around with hamburger menu 5. Playing around with back/forward long pressed menu 6. There shouldn't be any exceptions about "function can be cloned"
(interval measure is second) Auditors: @bsclifton Test Plan: 1. Put env BRAVE_SESSION_SAVE_INTERVAL=1 before executing Brave 2. See session file should be modified every seconds
bsclifton
requested review from
bridiver,
hferreiro,
ltilve,
cezaraugusto and
darkdh
Codecov Report
@@ Coverage Diff @@
## master #13473 +/- ##
==========================================
+ Coverage 56.59% 56.6% +0.01%
==========================================
Files 284 284
Lines 28676 28676
Branches 4744 4744
==========================================
+ Hits 16228 16232 +4
+ Misses 12448 12444 -4
|
hferreiro
reviewed
Mar 16, 2018
package.json
Outdated
| @@ -121,6 +123,7 @@ | |||
| "react-dom": "^15.5.4", | |||
| "react-select": "^0.9.1", | |||
| "react-transition-group": "^2.2.1", | |||
| "sha3": "hferreiro/node-sha3", | |||
There was a problem hiding this comment.
This repo should be moved to brave/
Fork was done and https://github.com/hferreiro/node-sha3/commit/7520f2a2d0e80abe5e4494ea134800e07cef2732 was cherry-picked in Auditors: @hferreiro, @darkdh
- this is the master branch fix for #13373
Auditors: @bridiver, @bsclifton
cezaraugusto
force-pushed
the
C65-master
branch
from
1f35d72
to
6494edb
Compare
darkdh
approved these changes
Mar 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Chromium 65 on master (and 0.23.x, 0.22.x)
Original PR for 0.21.x submitted with #13409
TODOS before we can accept this PR
2.35and Muon to new (see db97bb4 for example)sha3. Should we change this?After PR is merged checklist